September 2015 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: improve balance selection of vm for migration
by rgolan＠redhat.com 13 Sep '15

13 Sep '15

Roy Golan has submitted this change and it was merged. Change subject: core: improve balance selection of vm for migration ...................................................................... core: improve balance selection of vm for migration Iterate over source hosts, to find vm that can be migrated, without over utilize memory or CPU of destination host. Before was selected some random source host, and from this host was selected single vm with minimum cpu usage, but maybe with big amount of memory usage and so over utilizied destination host memory. In result we had that balancing not migrate any of vms. Change-Id: I67947fa4463b8bb12d04ee8f4126fa93683c9e14 Bug-Url: https://bugzilla.redhat.com/1258780 Signed-off-by: Artyom Lukianov <alukiano(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/FindVmAndDestinations.java 1 file changed, 21 insertions(+), 41 deletions(-) Approvals: Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Artyom Lukianov: Verified -- To view, visit https://gerrit.ovirt.org/45574 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67947fa4463b8bb12d04ee8f4126fa93683c9e14 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: engine: Add lock on Extend SD command
by amureini＠redhat.com 13 Sep '15

13 Sep '15

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Add lock on Extend SD command ...................................................................... engine: Add lock on Extend SD command In order to prevent to run the Extend Storage Domain command twice at the same time, an exclusive lock is added to the command. Running this command twice will put the VG in a partial state, creating a PV twice on the same device. Change-Id: Ib9062ba235daa1d25298f1d295b17d15e1528c80 Backport-To: 3.6 Bug-Url: https://bugzilla.redhat.com/1258632 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendSANStorageDomainCommand.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/46082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9062ba235daa1d25298f1d295b17d15e1528c80 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: EventsSupported configuratoin. check the EventsSupported con...
by ofrenkel＠redhat.com 13 Sep '15

13 Sep '15

Omer Frenkel has submitted this change and it was merged. Change subject: EventsSupported configuratoin. check the EventsSupported configuratoin for cross object type support and not just for vms. ...................................................................... EventsSupported configuratoin. check the EventsSupported configuratoin for cross object type support and not just for vms. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1258812 Change-Id: I1ed2c87047b515c670d8bd0ea5d88c452087aa50 Signed-off-by: emarcian <emarcian(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/RefresherFactory.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45580 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ed2c87047b515c670d8bd0ea5d88c452087aa50 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eldad Marciano <emarcian(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eldad Marciano <emarcian(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: wrong validation order and wrong translation.
by tnisan＠redhat.com 13 Sep '15

13 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: wrong validation order and wrong translation. ...................................................................... core: wrong validation order and wrong translation. Change-Id: Ia3c327dc5b02d68e3f17a2884b57a66d4be3f570 Bug-Url: https://bugzilla.redhat.com/1217943 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMacPoolCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3c327dc5b02d68e3f17a2884b57a66d4be3f570 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: unable to remove unmanaged network
by tnisan＠redhat.com 13 Sep '15

13 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: unable to remove unmanaged network ...................................................................... webadmin: unable to remove unmanaged network Change-Id: Ia3730e394bacb74741922d773758c8d1d34ff6d5 Bug-Url: https://bugzilla.redhat.com/1257027 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46007 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3730e394bacb74741922d773758c8d1d34ff6d5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: fill-in default bonding options if no options are spec...
by tnisan＠redhat.com 13 Sep '15

13 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: fill-in default bonding options if no options are specified ...................................................................... core: fill-in default bonding options if no options are specified when some bond in given modified_bonds collection does not have bond option set (is null or empty string), set it to default "mode=4 miimon=100" Change-Id: I8b5f8e598cfefea1365ec11855bc7d7a638b39f0 Bug-Url: https://bugzilla.redhat.com/1249119 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46015 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b5f8e598cfefea1365ec11855bc7d7a638b39f0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: end-migration of powering up vm
by tnisan＠redhat.com 13 Sep '15

13 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: end-migration of powering up vm ...................................................................... core: end-migration of powering up vm The monitoring didn't recognize a transition of powering up on the source host to powering up on the destination host as successful migration. Therefore, runningSucceeded method of the migrate-command was not called and in case of a migration between different clusters, the cluster of the VM was not updated. Change-Id: Ifbafd0b22d8a9c1d5e1635321ee21ce9bb7f2aa3 Bug-Url: https://bugzilla.redhat.com/1177236 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java 1 file changed, 17 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/46080 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbafd0b22d8a9c1d5e1635321ee21ce9bb7f2aa3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: fix graphics on import
by tnisan＠redhat.com 13 Sep '15

13 Sep '15

Tal Nisan has submitted this change and it was merged. Change subject: core: fix graphics on import ...................................................................... core: fix graphics on import 1. restore display type values: the values for cirrus (vnc) and qxl changed, this breaks backward compatibility with previously exported vms, so restored to original values. 2. the code that create graphics device on import was called too soon, and device was removed while reloading the vm from export domain during canDoAction, so moved the call to a better place. 3. fixed that code to select spice for qxl, if os support it, to match the previous values in the engine (qxl was always spice) Change-Id: I3fd8351a3f18428cfe905a39221756608b64da05 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1261446 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DisplayType.java A packaging/dbscripts/upgrade/03_06_1820_fix_display_type_numbers.sql 4 files changed, 19 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Omer Frenkel: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45969 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fd8351a3f18428cfe905a39221756608b64da05 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: balloon always reset when editing VM from REST
by ofrenkel＠redhat.com 13 Sep '15

13 Sep '15

Omer Frenkel has submitted this change and it was merged. Change subject: core: balloon always reset when editing VM from REST ...................................................................... core: balloon always reset when editing VM from REST Since the balloonEnabled in VmTemplateParametersBase was small boolean, it was not possible to decide if the passed false means really "false" or remove. Fixed the same way as it it done on the update VM case. Change-Id: I16adef671bc77e26f56657add59621a1aa9b1c4a Bug-Url: https://bugzilla.redhat.com/1241279 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateParametersBase.java 2 files changed, 19 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Omer Frenkel: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16adef671bc77e26f56657add59621a1aa9b1c4a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core: fill-in default bonding options if no options are spec...
by alkaplan＠redhat.com 13 Sep '15

13 Sep '15

Alona Kaplan has submitted this change and it was merged. Change subject: core: fill-in default bonding options if no options are specified ...................................................................... core: fill-in default bonding options if no options are specified when some bond in given modified_bonds collection does not have bond option set (is null or empty string), set it to default "mode=4 miimon=100" Change-Id: I8b5f8e598cfefea1365ec11855bc7d7a638b39f0 Bug-Url: https://bugzilla.redhat.com/1249119 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/44342 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b5f8e598cfefea1365ec11855bc7d7a638b39f0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0