May 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Enforce Clone for template import without base
by tjelinek＠redhat.com 30 May '16

30 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Enforce Clone for template import without base ...................................................................... webadmin: Enforce Clone for template import without base Import of a template without existing base template has to be performed by cloning. Enforced on front-end. Change-Id: I1d1168daaab129a37dc8b31945214fc38a1624cd Bug-Url: https://bugzilla.redhat.com/1328725 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportEntityData.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 4 files changed, 27 insertions(+), 5 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/58181 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d1168daaab129a37dc8b31945214fc38a1624cd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: mask fencing alerts when disabled in cluster
by mperina＠redhat.com 30 May '16

30 May '16

Martin Peřina has submitted this change and it was merged. Change subject: core: mask fencing alerts when disabled in cluster ...................................................................... core: mask fencing alerts when disabled in cluster This patch masks the following when fencing is disabled in the cluster level: 1) Exclamation icon when host power management is not configured 2) Alert appearing in the alert tab when power management is not configured for a host 3) The popup form warning the user that power management was not configured when adding a new host In order to do that the VDS entity was expanded to include the fencing_enabled flag from the cluster settings. This flag was added only to the VDS view and is still taken from the cluster properties` Change-Id: I500ae184ade108ddbe1c10eaf3bc5b51e4a5c9ce Bug-Url : https://bugzilla.redhat.com/show_bug.cgi?id=1145240 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/HostStatusCell.java M packaging/dbscripts/create_views.sql 8 files changed, 54 insertions(+), 23 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I500ae184ade108ddbe1c10eaf3bc5b51e4a5c9ce Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: host-deploy: Support deploying Hosted Engine components
by rgolan＠redhat.com 29 May '16

29 May '16

Roy Golan has submitted this change and it was merged. Change subject: host-deploy: Support deploying Hosted Engine components ...................................................................... host-deploy: Support deploying Hosted Engine components Till today a hosts with hosted engine components were added manually by script on the hosts themselves. This patch will enable to install and configure the relevant components by passing all the relevant information from the engine. The prerequisite for that is to have the hosted engine VM imported into the engine. Otherwise we can't gather all the info for the installation. So now a user can select to Deploy/Remove hosted engine agent or leave with no change(see Action) In order to deploy an additional Hosted Engine host we need to provide the configuration that was used by the 1st host and just assign it with a differnt unique host_id. For that we download the configuration from a special disk on the special domain and extract the configuration from it. This behaviour is composed under the HostedEngineConfigFetcher.java utility. Wiki: http://www.ovirt.org/develop/release-management/features/hosted-engine-add-… Change-Id: I535bdfeba41b03c86520408e72abfa914fe3e1be Bug-Url: https://bugzilla.redhat.com/1167262 Signed-off-by: Roy Golan <rgolan(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployHostedEngineUnit.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineConfigFetcher.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/UpdateHostValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineConfigFetcherTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/HostValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/UpdateHostValidatorTest.java A backend/manager/modules/bll/src/test/resources/hosted-engine-config.tar A backend/manager/modules/bll/src/test/resources/hosted-engine.conf A backend/manager/modules/bll/src/test/resources/not-a-valid-hosted-engine-config-tar.tar M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/hostdeploy/InstallVdsParameters.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HostedEngineDeployConfiguration.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties 20 files changed, 771 insertions(+), 158 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I535bdfeba41b03c86520408e72abfa914fe3e1be Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: fixing 4.0 publisher to push to 4.0 and not master
by eedri＠redhat.com 29 May '16

29 May '16

Eyal Edri has submitted this change and it was merged. Change subject: fixing 4.0 publisher to push to 4.0 and not master ...................................................................... fixing 4.0 publisher to push to 4.0 and not master Change-Id: I1fe7adaad2d6ea3324c12cb3c550fb0de084daed Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Eyal Edri: Ready for merge Barak Korren: Verified; Looks good to me; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1fe7adaad2d6ea3324c12cb3c550fb0de084daed Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.7]: webadmin: Fix of custom properties
by tnisan＠redhat.com 29 May '16

29 May '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix of custom properties ...................................................................... webadmin: Fix of custom properties This patch fixes two problems: * When user (not admin@internal) with VmCreator role tried to create new VM from snapshot (clone) it failed with "User is not authorized to perform this action." * When admin@internal tried to create new VM from snapshot (clone) and changed some custom properties in "Clone VM from Snapshot" dialog the new VM was anyway created without any custom properties. The cause was confusion between abandoned UnitVmModel#customProperties and UnitVmModel#customPropertySheet during model -> business entity serialization. #customPropertySheet is serialized in CoreUnitToVmBaseBuilder Change-Id: I78292af0754bfec8938fe63ea44e71a108684d4e Bug-Url: https://bugzilla.redhat.com/1338943 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78292af0754bfec8938fe63ea44e71a108684d4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.7 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in migrate command
by ahadas＠redhat.com 29 May '16

29 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in migrate command ...................................................................... core: cleanup in migrate command Minor cleanup in MigrateVDSCommand: 1. Use VmDynamic instead of VM since all migration related data that needs to be updated resides in VmDynamic. 2. Remove unused VmDao (VmDynamicDao was unused before) 3. Styling issues Change-Id: Ic76b418f0d71c4a59a9af401110830c4566a282d Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java 1 file changed, 14 insertions(+), 16 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/58089 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic76b418f0d71c4a59a9af401110830c4566a282d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Avoid an infinite loop when untar an entry
by rgolan＠redhat.com 29 May '16

29 May '16

Roy Golan has submitted this change and it was merged. Change subject: core: Avoid an infinite loop when untar an entry ...................................................................... core: Avoid an infinite loop when untar an entry Avoid going into infinite loop in case there is an error during an entry extraction from a tar archive. For example if the tar contains a corrupted or simply an empty file, this will trigger the infinite loop. The fix will just skip to the next entry and will add empty files into the archive (we reflect the tar entries and not ignoring them) Change-Id: I64a8d019cb5c13df19ee21eecb2ab81b42a9b3cc Bug-Url: https://bugzilla.redhat.com/1167262 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/archivers/tar/TarInMemoryExport.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/archivers/tar/TarInMemoryExportTest.java A backend/manager/modules/utils/src/test/resources/mixed-content.tar A backend/manager/modules/utils/src/test/resources/non-empty.tar A backend/manager/modules/utils/src/test/resources/tar-with-empty-file.tar 6 files changed, 83 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57855 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64a8d019cb5c13df19ee21eecb2ab81b42a9b3cc Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: VdsCommandsHelper - avoid relying on injections
by laravot＠redhat.com 29 May '16

29 May '16

Liron Aravot has submitted this change and it was merged. Change subject: VdsCommandsHelper - avoid relying on injections ...................................................................... VdsCommandsHelper - avoid relying on injections Change-Id: Ib38c138e143935e54611dbcfeb3a04c1a907166e Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/utils/VdsCommandsHelper.java 1 file changed, 9 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57652 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib38c138e143935e54611dbcfeb3a04c1a907166e Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: AllocateImageGroupVolumeCommand - moved to entity spec...
by laravot＠redhat.com 29 May '16

29 May '16

Liron Aravot has submitted this change and it was merged. Change subject: core: AllocateImageGroupVolumeCommand - moved to entity specific package ...................................................................... core: AllocateImageGroupVolumeCommand - moved to entity specific package moving AllocateImageGroupVolumeCommand to org.ovirt.engine.core.bll.storage.disk.image instead of the general bll package. Change-Id: I518c2f7a07dd3f60b121b70464d287cbddff455f Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AllocateImageGroupVolumeCommand.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57651 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I518c2f7a07dd3f60b121b70464d287cbddff455f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CreateVolumeVDSCommandParameters - ctor params order
by laravot＠redhat.com 29 May '16

29 May '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CreateVolumeVDSCommandParameters - ctor params order ...................................................................... core: CreateVolumeVDSCommandParameters - ctor params order changed the ctor params order so it'll be more trivial. Change-Id: I65844406105934e4be4af305c66f67db82a04c8d Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateVolumeVDSCommandParameters.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65844406105934e4be4af305c66f67db82a04c8d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0