May 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: userportal: New VM dialog offers each VM template twice
by tnisan＠redhat.com 26 May '16

26 May '16

Tal Nisan has submitted this change and it was merged. Change subject: userportal: New VM dialog offers each VM template twice ...................................................................... userportal: New VM dialog offers each VM template twice The decision to show also the "latest" templates has to be done according to the fact if the VM is stateless or not. This has been implemented and used in webadmin but forgotten to be used it for userportal. Change-Id: Iffb7f3d172cf769f9bef78a4dd067b30e952282b Bug-Url: https://bugzilla.redhat.com/1293154 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewVmModelBehavior.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffb7f3d172cf769f9bef78a4dd067b30e952282b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: userportal: GetAllMigrationPolicies user query
by tnisan＠redhat.com 26 May '16

26 May '16

Tal Nisan has submitted this change and it was merged. Change subject: userportal: GetAllMigrationPolicies user query ...................................................................... userportal: GetAllMigrationPolicies user query It is inited in user poral and needed during creating a new VM. Without this it is not possible to create a new VM in user portal. Change-Id: Idd1522ef6fa79301ca00c41e38d373f061c02ac9 Bug-Url: https://bugzilla.redhat.com/1339668 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd1522ef6fa79301ca00c41e38d373f061c02ac9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetAllAttachableDisksForVmQuery's DbFacade
by amureini＠redhat.com 26 May '16

26 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetAllAttachableDisksForVmQuery's DbFacade ...................................................................... core: GetAllAttachableDisksForVmQuery's DbFacade Use getDbFacade() instead of DbFacade.getInstance() to make writing tests easier. Change-Id: Id471eafd0dd2bd1378d041b877c5dca6cefb679e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetAllAttachableDisksForVmQuery.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/58139 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id471eafd0dd2bd1378d041b877c5dca6cefb679e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GetAllAttachableDisksForVmQuery branching
by amureini＠redhat.com 26 May '16

26 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetAllAttachableDisksForVmQuery branching ...................................................................... core: GetAllAttachableDisksForVmQuery branching Removed a useless if from GetAllAttachableDisksForVmQuery#executeQueryCommand. Since entering and not entering the if has the same effect, it's useless, and can safely be removed. This patch fixes Coverity issue 1355578. Change-Id: If6afa979b5fb4375bfa344ee8711b1a155e2d848 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/GetAllAttachableDisksForVmQuery.java 1 file changed, 2 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/58138 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6afa979b5fb4375bfa344ee8711b1a155e2d848 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Fix a policy unit db upgrade script according to oVirt style...
by rgolan＠redhat.com 26 May '16

26 May '16

Roy Golan has submitted this change and it was merged. Change subject: Fix a policy unit db upgrade script according to oVirt style rules ...................................................................... Fix a policy unit db upgrade script according to oVirt style rules Change-Id: I86f05058abc7fa5c591f1cecb68981277705e85e Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M packaging/dbscripts/upgrade/04_00_0150_remove_internal_policy_units.sql 1 file changed, 18 insertions(+), 10 deletions(-) Approvals: Martin Sivák: Verified Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86f05058abc7fa5c591f1cecb68981277705e85e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal: New VM dialog offers each VM template twice
by tjelinek＠redhat.com 26 May '16

26 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: New VM dialog offers each VM template twice ...................................................................... userportal: New VM dialog offers each VM template twice The decision to show also the "latest" templates has to be done according to the fact if the VM is stateless or not. This has been implemented and used in webadmin but forgotten to be used it for userportal. Change-Id: Iffb7f3d172cf769f9bef78a4dd067b30e952282b Bug-Url: https://bugzilla.redhat.com/1293154 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewVmModelBehavior.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58076 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffb7f3d172cf769f9bef78a4dd067b30e952282b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal: GetAllMigrationPolicies user query
by tjelinek＠redhat.com 26 May '16

26 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: GetAllMigrationPolicies user query ...................................................................... userportal: GetAllMigrationPolicies user query It is inited in user poral and needed during creating a new VM. Without this it is not possible to create a new VM in user portal. Change-Id: Idd1522ef6fa79301ca00c41e38d373f061c02ac9 Bug-Url: https://bugzilla.redhat.com/1339668 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58074 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd1522ef6fa79301ca00c41e38d373f061c02ac9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: added reporting of current cmd line
by tnisan＠redhat.com 26 May '16

26 May '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: added reporting of current cmd line ...................................................................... webadmin: added reporting of current cmd line Added the current kernel cmd line reporting to the edit host dialog. Change-Id: I862ddddd1f7d268425786cded42c6d3ef9c0c6d2 Bug-Url: https://bugzilla.redhat.com/1339539 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 5 files changed, 29 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/58035 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I862ddddd1f7d268425786cded42c6d3ef9c0c6d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: PKIResources type inference
by amureini＠redhat.com 26 May '16

26 May '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: PKIResources type inference ...................................................................... core: PKIResources type inference Change-Id: I2aecceb634c9e6235ce899fb941fefd26a8a7959 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/58100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2aecceb634c9e6235ce899fb941fefd26a8a7959 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.0]: build: move to 4.0 branch
by sbonazzo＠redhat.com 26 May '16

26 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: move to 4.0 branch ...................................................................... build: move to 4.0 branch Change-Id: Idd9860eaef9d8037293c7925389ef676c8d87972 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in M ovirt-engine-setup-plugin-live/configure.ac M ovirt-engine-setup-plugin-live/ovirt-engine-setup-plugin-live.spec.in M ovirt-live-artwork/ovirt-live-artwork.spec.in 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58028 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd9860eaef9d8037293c7925389ef676c8d87972 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0