June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.7]: core: Fix task completion after removing a snapshot
by piotr.kliczewski＠gmail.com 20 Jun '16

20 Jun '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Fix task completion after removing a snapshot ...................................................................... core: Fix task completion after removing a snapshot When removing a snapshot or disk snapshot, the task neither removed from the database nor from the UI. This patch fixes this behavior by calling ExecutionHandler.endJob after the command completes. Note: this fix is not required on master branch because the framework handles this behavior. Change-Id: Ic6eefaa6ee18994321319b27d1d66fed9fd41677 Bug-Url: https://bugzilla.redhat.com/1344479 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/59454 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6eefaa6ee18994321319b27d1d66fed9fd41677 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.7 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Fix task completion after removing a snapshot
by piotr.kliczewski＠gmail.com 20 Jun '16

20 Jun '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Fix task completion after removing a snapshot ...................................................................... core: Fix task completion after removing a snapshot When removing a snapshot or disk snapshot, the task neither removed from the database nor from the UI. This patch fixes this behavior by calling ExecutionHandler.endJob after the command completes. Note: this fix is not required on master branch because the framework handles this behavior. Change-Id: Ic6eefaa6ee18994321319b27d1d66fed9fd41677 Bug-Url: https://bugzilla.redhat.com/1344479 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/59451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6eefaa6ee18994321319b27d1d66fed9fd41677 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Wrong validation on update SAN SD
by piotr.kliczewski＠gmail.com 20 Jun '16

20 Jun '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Wrong validation on update SAN SD ...................................................................... webadmin: Wrong validation on update SAN SD If the user edits an existing SAN storage domain, and changes only the name, a wrong and uneeded check is done on all LUNs of the SD. In this patch, the validation is done only in case the user had extended the SD by adding additional LUNs. Change-Id: Id2085e95c577ffab016f0695706d4f970172e038 Bug-Url: https://bugzilla.redhat.com/1347974 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/59446 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2085e95c577ffab016f0695706d4f970172e038 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Populate V3 snapshot type correctly
by juan.hernandez＠redhat.com 20 Jun '16

20 Jun '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Populate V3 snapshot type correctly ...................................................................... restapi: Populate V3 snapshot type correctly In version 3 of the API the VmBase#type attribute had two different meanings, depending on the context: the type of virtual machine (desktop of server) when used with virtual machines or templates, and the type of snapshot (regular, active, etc) when sued with snapshots. In version 4 of the API this isn't possible because each attribute has attribute has exactly one type. To handle that a new `snapshot_type` attribute was added to the snapshot entity. But the version 3 compatibility layer didn't take this into account, and as a result the old `type` attribute wasn't populated. This patch fixes that, so the old `type` attribute is populated correctly. Change-Id: I8b50b994533135fbc0a5d924a3df958b4b6cb584 Bug-Url: https://bugzilla.redhat.com/1348138 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3SnapshotInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3SnapshotOutAdapter.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59462 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b50b994533135fbc0a5d924a3df958b4b6cb584 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Fix the V3 graphics console
by oourfali＠redhat.com 20 Jun '16

20 Jun '16

Oved Ourfali has submitted this change and it was merged. Change subject: restapi: Fix the V3 graphics console ...................................................................... restapi: Fix the V3 graphics console The GET and DELETE methods for virtual machine graphics consoles are missing in the version 3 compatibility layer. This patch adds them. Change-Id: I51855d7f89bb4acd8542aab7246b4d637fd54c81 Bug-Url: https://bugzilla.redhat.com/1347155 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 141e0f1d1006b1e370682fbba93d3620c8190b17) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmGraphicsConsoleServer.java 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59457 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51855d7f89bb4acd8542aab7246b4d637fd54c81 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: node: add requirement for vdsm hook fcoe
by fabiand＠redhat.com 20 Jun '16

20 Jun '16

Fabian Deutsch has submitted this change and it was merged. Change subject: node: add requirement for vdsm hook fcoe ...................................................................... node: add requirement for vdsm hook fcoe Change-Id: Ic9c14a7f47ee7d8728a36fff5294f567f0a24005 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1347588 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M ovirt-release-master.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Fabian Deutsch: Looks good to me, approved; Passed CI tests Douglas Schilling Landgraf: Verified -- To view, visit https://gerrit.ovirt.org/59394 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9c14a7f47ee7d8728a36fff5294f567f0a24005 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Extract katello 2.1 provider into class
by masayag＠redhat.com 20 Jun '16

20 Jun '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extract katello 2.1 provider into class ...................................................................... engine: Extract katello 2.1 provider into class The Katello 2.1 API was changed in Katello 3.0. In order to support Katello 3.0, a refactor work is required. This patch extracts the Katello 2.1 provider into its own class. Change-Id: I9cd825fcdc95759b7797ef176e9978f2e0158937 Bug-Url: https://bugzilla.redhat.com/1346263 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/ContentHostProvider.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/HostProviderProxy.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/FilteredErrataRelativeUrlBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/KatelloV21Provider.java 5 files changed, 212 insertions(+), 159 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59377 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cd825fcdc95759b7797ef176e9978f2e0158937 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Support Katello 3.x version
by masayag＠redhat.com 20 Jun '16

20 Jun '16

Moti Asayag has submitted this change and it was merged. Change subject: engine: Support Katello 3.x version ...................................................................... engine: Support Katello 3.x version In addition to Katello 2.1, the Katello 3.1 support is added to ovirt-engine. In order to detect the Katello version, an api call for /api/v2/status will be sent, and by the return value, the provider version is detected: 1. 1.11 and above - Katello 3.1 2. less than 1.11 - Katello 2 Change-Id: I36dfcd325a199294cb1a8e281ccccadbd13607b3 Bug-Url: https://bugzilla.redhat.com/1346263 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/ContentHostProvider.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ContentHostV30.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ContentHostsV30Wrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/EngineForemanProviderFinder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/FilteredErrataRelativeUrlBuilder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostProviderProxy.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/KatelloProvider.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/KatelloV21Provider.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/KatelloV30Provider.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ReportedForemanStatus.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/host/provider/foreman/FilteredErrataRelativeUrlBuilderTest.java A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonCustomDateDeserializer.java 12 files changed, 419 insertions(+), 156 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36dfcd325a199294cb1a8e281ccccadbd13607b3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Sync db scripts numbering between master and ovirt-eng...
by mperina＠redhat.com 20 Jun '16

20 Jun '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Sync db scripts numbering between master and ovirt-engine-4.0 ...................................................................... core: Sync db scripts numbering between master and ovirt-engine-4.0 Synchronizes database upgrade scripts numbering between master and ovirt-engine-4.0 branch. This should fix database upgrade issues from ovirt-engine-4.0 to master. Change-Id: I06be3f818636ab065bb71b382595cc804ca74369 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- R packaging/dbscripts/upgrade/04_00_0750_change_cluster_default_policy.sql R packaging/dbscripts/upgrade/04_00_0760_add_mac_pool_id_to_vds_group.sql R packaging/dbscripts/upgrade/04_00_0770_empty_current_cd_to_null.sql R packaging/dbscripts/upgrade/04_00_0780_remove_mac_pool_id_from_storage_pool.sql R packaging/dbscripts/upgrade/04_00_0790_move_guest_mem_fields_to_statistics.sql R packaging/dbscripts/upgrade/04_00_0800_remove_el7_upgrade_policy_units.sql R packaging/dbscripts/upgrade/04_00_0810_add_switch_type_to_vds_interface_and_cluster.sql 7 files changed, 0 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Verified Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59459 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06be3f818636ab065bb71b382595cc804ca74369 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: utils: print path of constraint violation in validation
by mperina＠redhat.com 20 Jun '16

20 Jun '16

Martin Peřina has submitted this change and it was merged. Change subject: core: utils: print path of constraint violation in validation ...................................................................... core: utils: print path of constraint violation in validation Log: WARN [org.ovirt.engine.core.bll.network.dc.AddNetworkCommand] (default task-43) [5507170a] Validation of action 'AddNetwork' failed for user admin@internal-authz. Reasons: VAR__TYPE__NETWORK,VAR__ACTION__ADD,MTU_VALUE_INVALID, ACTION_TYPE_FAILED_ATTRIBUTE_PATH,$path network.mtu ERROR [org.ovirt.engine.api.restapi.resource.AbstractBackendResource] (default task-43) [] Operation Failed: [mtu value invalid, Attribute: network.mtu] REST API: <?xml version="1.0" encoding="UTF-8" standalone="yes"?> <fault> <detail>[mtu value invalid, Attribute: network.mtu]</detail> <reason>Operation Failed</reason> </fault> UI Error: Error while executing action: nic: * Name must be formed of alphanumeric characters, numbers or "-_.". * Attribute: nic.name Change-Id: I3f4c2978913af7f0f9348c480c705c2cdc917627 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1295678 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 14 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f4c2978913af7f0f9348c480c705c2cdc917627 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0