June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: uutils: ssh: Reformat code
by mperina＠redhat.com 20 Jun '16

20 Jun '16

Martin Peřina has submitted this change and it was merged. Change subject: uutils: ssh: Reformat code ...................................................................... uutils: ssh: Reformat code Reformats code using project settings. Change-Id: I119dd97ae3139f8ef4fa06d5feefeb6a601a5d6b Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ConstraintByteArrayOutputStream.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtils.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ProgressInputStream.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ProgressOutputStream.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHClient.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHDialog.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/BasicTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/CommandTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/ConstraintByteArrayOutputStreamTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtilsTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHD.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHDialogTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TestCommon.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TimeoutTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TransferTest.java 15 files changed, 746 insertions(+), 873 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59360 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I119dd97ae3139f8ef4fa06d5feefeb6a601a5d6b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: uutils: ssh: Optimize condition
by mperina＠redhat.com 20 Jun '16

20 Jun '16

Martin Peřina has submitted this change and it was merged. Change subject: uutils: ssh: Optimize condition ...................................................................... uutils: ssh: Optimize condition Removes redundant '|| false' from condition. Change-Id: I68123f818632a3f9c91a891e47d7c943888ff400 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHClient.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59365 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68123f818632a3f9c91a891e47d7c943888ff400 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine: add default IPv[46] values
by piotr.kliczewski＠gmail.com 20 Jun '16

20 Jun '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: add default IPv[46] values ...................................................................... engine: add default IPv[46] values In case the user-supplied IpConfiguration is incomplete, add defaults (boot_proto=NONE) for both IPv4 and IPv6. Change-Id: I32b1c5491bac91a13a35fbc5a41399acd912fe37 Bug-Url: https://bugzilla.redhat.com/1340644 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/IpConfigurationCompleter.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/IpConfigurationCompleterTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/NetworkCommonUtils.java 4 files changed, 192 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/59330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32b1c5491bac91a13a35fbc5a41399acd912fe37 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: DomainPoolMap race - domain in 'detaching' as attached
by piotr.kliczewski＠gmail.com 20 Jun '16

20 Jun '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: DomainPoolMap race - domain in 'detaching' as attached ...................................................................... core: DomainPoolMap race - domain in 'detaching' as attached When executing connectStoragePool/reconstructMaster verbs the engine build the domain map and passes it to vdsm. When deactivating domain its status is changed to 'Detaching' in the begining of the operation, domains in that status aren't included in the built domain map. If multiple domain deactivations are performed concurrently the following scenario could occur: 1. domain A deactivation start -> status changed to Deactivating 2. domain B deactivation start -> status changed to Deactivating 3. DeactiveStorageDomainVdsCommand executed for domain A 4. ConnectStoragePool is executed as part as domain A deactivation flow. Both domains A and B aren't sent as part of the domain pool map as they are in Deactivating status. 5. DeactiveStorageDomainVdsCommand executed for domain B and fails as the domain isn't part of the pool domains anymore (as it wasn't sent as part of the ConnectStoragePool call). 6. As part of the pool metadata synchronization domain B is marked as detached altough its metadata wasn't updated to reflect that its not a part of a storage pool. The current solution to this race condition is to send domains in Deactivating status as 'attached', domains in 'attached' status aren't being accessed by the host anyway and the last deactivation pool metadata refresh should contain the updated information to all the hosts. Additionally, if the detach operation fails on the spm - this will allow to activate the domain again. Change-Id: I5e45ce1bbd37f3562c988a427026ec07c471d7e2 Bug-Url: https://bugzilla.redhat.com/1324076 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DetachStorageDomainFromPoolCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/59440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e45ce1bbd37f3562c988a427026ec07c471d7e2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: RemovesSnapshot - Disk snapshots attached to other vms...
by piotr.kliczewski＠gmail.com 20 Jun '16

20 Jun '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: RemovesSnapshot - Disk snapshots attached to other vms validation ...................................................................... core: RemovesSnapshot - Disk snapshots attached to other vms validation The validation of whether disk snapshots from the removed snapshots was mistakenly removed in change I1bc597f, this patch restores it. Change-Id: Ia7e1ba391e928911cf0ef8d27001d757d88f969d Bug-Url: https://bugzilla.redhat.com/1342783 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/59428 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7e1ba391e928911cf0ef8d27001d757d88f969d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: spec: require python3-dnf-plugins-extras-versionlock
by sbonazzo＠redhat.com 20 Jun '16

20 Jun '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: spec: require python3-dnf-plugins-extras-versionlock ...................................................................... packaging: spec: require python3-dnf-plugins-extras-versionlock In fedora 23, dnf is using python3. Bug-Url: https://bugzilla.redhat.com/1348073 Change-Id: I7d2f4c499c60e71eb8b201cb4bc2a0838bd1a73a Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/58739 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d2f4c499c60e71eb8b201cb4bc2a0838bd1a73a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[otopi-1.5]: automation: export built packages
by didi＠redhat.com 20 Jun '16

20 Jun '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: automation: export built packages ...................................................................... automation: export built packages Change-Id: I130892f4ac6e6d827ab4e8cbb60c27888a6413cc Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit cf9a6fe108bcae4b1b05cb877d7656532e84b66c) --- M automation/check-patch.packages M automation/check-patch.sh 2 files changed, 15 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59445 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I130892f4ac6e6d827ab4e8cbb60c27888a6413cc Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: gluster sync - fix covertity issue
by sabose＠redhat.com 20 Jun '16

20 Jun '16

Sahina Bose has submitted this change and it was merged. Change subject: engine: gluster sync - fix covertity issue ...................................................................... engine: gluster sync - fix covertity issue Fix possible NPE reported by coverity Change-Id: I8743bee7f9044b60da9bf9d7bd660b36a8bd5465 Bug-Url: https://bugzilla.redhat.com/1300095 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java 1 file changed, 46 insertions(+), 40 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Verified Moti Asayag: Looks good to me, approved Ramesh N: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8743bee7f9044b60da9bf9d7bd660b36a8bd5465 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: automation: export built packages
by didi＠redhat.com 19 Jun '16

19 Jun '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: automation: export built packages ...................................................................... automation: export built packages Change-Id: I130892f4ac6e6d827ab4e8cbb60c27888a6413cc Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M automation/check-patch.packages M automation/check-patch.sh 2 files changed, 15 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59443 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I130892f4ac6e6d827ab4e8cbb60c27888a6413cc Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Wrong validation on update SAN SD
by amureini＠redhat.com 19 Jun '16

19 Jun '16

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Wrong validation on update SAN SD ...................................................................... webadmin: Wrong validation on update SAN SD If the user edits an existing SAN storage domain, and changes only the name, a wrong and uneeded check is done on all LUNs of the SD. In this patch, the validation is done only in case the user had extended the SD by adding additional LUNs. Change-Id: Id2085e95c577ffab016f0695706d4f970172e038 Bug-Url: https://bugzilla.redhat.com/1347974 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/59442 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2085e95c577ffab016f0695706d4f970172e038 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0