June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix wrong db initialization
by alkaplan＠redhat.com 20 Jun '16

20 Jun '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: Fix wrong db initialization ...................................................................... core: Fix wrong db initialization Before this patch, when pool got empty during its initialization, and tried to write log about it into AuditLog, NPE was thrown, because DbFacade wasn't initialized yet. Such NPE brought several singletons down blocking ear from being deployed. The reason for that is probably that there's a code using org.ovirt.engine.core.dal.dbbroker.DbFacade#getInstance which gets initialized only after DbFacade bean is properly constructed. Injecting DbFacade into MacPoolPerCluster seems to fix the issue, since DbFacade gets initialized during inject and thus getInstance will return correct non-null instance when called. Change-Id: I3e44d5da98b31f502252f9418a068cb509408d4d Bug-Url: https://bugzilla.redhat.com/1343332 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolPerCluster.java 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests Moti Asayag: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/58769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e44d5da98b31f502252f9418a068cb509408d4d Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Don't ignore All-Content header in VirtOnly mode
by juan.hernandez＠redhat.com 20 Jun '16

20 Jun '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Don't ignore All-Content header in VirtOnly mode ...................................................................... restapi: Don't ignore All-Content header in VirtOnly mode Currently when the value of the "ApplicationMode" configuration value is "VirtOnly" the "All-Content" header is ignored by the clusters resource. This patch fixes that issue. Change-Id: Ib049ca38fc245772cda12e387031371c39452dad Bug-Url: https://bugzilla.redhat.com/1346247 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClustersResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59372 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib049ca38fc245772cda12e387031371c39452dad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Fix the V3 graphics console
by juan.hernandez＠redhat.com 20 Jun '16

20 Jun '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix the V3 graphics console ...................................................................... restapi: Fix the V3 graphics console The GET and DELETE methods for virtual machine graphics consoles are missing in the version 3 compatibility layer. This patch adds them. Change-Id: I51855d7f89bb4acd8542aab7246b4d637fd54c81 Bug-Url: https://bugzilla.redhat.com/1347155 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmGraphicsConsoleServer.java 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51855d7f89bb4acd8542aab7246b4d637fd54c81 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add status/shared status support in search
by mperina＠redhat.com 20 Jun '16

20 Jun '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Add status/shared status support in search ...................................................................... core: Add status/shared status support in search Problem was that StorageDomainFieldAutoCompleter was addressing StorageDomainStatus while using auto-complete from the StorageDomainSharedStatus enum. This patch adds correct support for both status and shared_status fields using StorageDomainStatus enum values to validate status and StorageDomainSharedStatus enum values to validate the shared status. Change-Id: Ic496e15516fc90928589232ebad08fe234c0499e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1347007 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatus.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StorageDomainFieldAutoCompleter.java 2 files changed, 9 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic496e15516fc90928589232ebad08fe234c0499e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: uutils: ssh: Rename attributes to match JCC
by mperina＠redhat.com 20 Jun '16

20 Jun '16

Martin Peřina has submitted this change and it was merged. Change subject: uutils: ssh: Rename attributes to match JCC ...................................................................... uutils: ssh: Rename attributes to match JCC Renames attributes to match Java Coding Conventions. Change-Id: If336b400c7e30c82edb65d444f9d94602fae9918 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/EngineSSHDialog.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ConstraintByteArrayOutputStream.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ProgressInputStream.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ProgressOutputStream.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHClient.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHDialog.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/BasicTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHD.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHDialogTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TimeoutTest.java 10 files changed, 302 insertions(+), 302 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59359 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If336b400c7e30c82edb65d444f9d94602fae9918 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: uutils: ssh: Remove redundant public keyword
by mperina＠redhat.com 20 Jun '16

20 Jun '16

Martin Peřina has submitted this change and it was merged. Change subject: uutils: ssh: Remove redundant public keyword ...................................................................... uutils: ssh: Remove redundant public keyword Removes redundant public keyword from interface methods. Change-Id: If7ce07a7575604efac5ddf9204ca47fbd3d2b552 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHDialog.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59358 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7ce07a7575604efac5ddf9204ca47fbd3d2b552 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: uutils: ssh: Remove unused variables
by mperina＠redhat.com 20 Jun '16

20 Jun '16

Martin Peřina has submitted this change and it was merged. Change subject: uutils: ssh: Remove unused variables ...................................................................... uutils: ssh: Remove unused variables Removes unused variables from SSHClient and SSHD classes. Change-Id: I079329f0ed83ed9eb165a0a3827ba75cde131a73 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/SSHClient.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHD.java 2 files changed, 3 insertions(+), 13 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I079329f0ed83ed9eb165a0a3827ba75cde131a73 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: uutils: ssh: Replace for loop with foreach
by mperina＠redhat.com 20 Jun '16

20 Jun '16

Martin Peřina has submitted this change and it was merged. Change subject: uutils: ssh: Replace for loop with foreach ...................................................................... uutils: ssh: Replace for loop with foreach Replaces for loop with foreach to simplify code. Change-Id: I80486cc2c7fcc6420656cfac786b347aa472867d Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/OpenSSHUtils.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59363 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80486cc2c7fcc6420656cfac786b347aa472867d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: uutils: ssh: Adds missing @NotNull
by mperina＠redhat.com 20 Jun '16

20 Jun '16

Martin Peřina has submitted this change and it was merged. Change subject: uutils: ssh: Adds missing @NotNull ...................................................................... uutils: ssh: Adds missing @NotNull Adds missing @NotNull annotation for overridden methods. Change-Id: I605e3a0b159baa242fec3bb18a65ff67668b47c4 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ConstraintByteArrayOutputStream.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ProgressInputStream.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/ssh/ProgressOutputStream.java 3 files changed, 6 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59362 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I605e3a0b159baa242fec3bb18a65ff67668b47c4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: uutils: ssh: Remove redundant Exception from throws definition
by mperina＠redhat.com 20 Jun '16

20 Jun '16

Martin Peřina has submitted this change and it was merged. Change subject: uutils: ssh: Remove redundant Exception from throws definition ...................................................................... uutils: ssh: Remove redundant Exception from throws definition Removes FileNotFoundException from throws definition, because its parent IOException is already contained in the same throws definition. Change-Id: I81e831553aa16920e85a8cd66e72c0dc5ad2ab69 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TransferTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81e831553aa16920e85a8cd66e72c0dc5ad2ab69 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0