July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: GlusterBrickValidatorTest whitespaces
by amureini＠redhat.com 05 Jul '16

05 Jul '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GlusterBrickValidatorTest whitespaces ...................................................................... core: GlusterBrickValidatorTest whitespaces Removed redundant empty lines at the end of methods. This empty lines just bloat the code and do nothing to improve the code's readability. Change-Id: I946a797d014dd40b3a6af206fdb770f436737e02 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/GlusterBrickValidatorTest.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/60175 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I946a797d014dd40b3a6af206fdb770f436737e02 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: GlusterBrickValidatorTest assertions
by amureini＠redhat.com 05 Jul '16

05 Jul '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: GlusterBrickValidatorTest assertions ...................................................................... core: GlusterBrickValidatorTest assertions Modernize the assertions in this test class using the assertThat syntax with the custom matchers from org.ovirt.engine.core.bll.validator.ValidationResultMatchers. This lends towards making the code more readable and the failure messages clearer. Change-Id: I957166c0514ad1a33d804fd69259c2e22c4277e7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/GlusterBrickValidatorTest.java 1 file changed, 27 insertions(+), 30 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/60174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I957166c0514ad1a33d804fd69259c2e22c4277e7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Adding pretty name to OS version format
by emesika＠redhat.com 05 Jul '16

05 Jul '16

Eli Mesika has submitted this change and it was merged. Change subject: core: Adding pretty name to OS version format ...................................................................... core: Adding pretty name to OS version format This patch adds pretty_name to vds_dynamic table and to the data access layer. This field is filled by the VDSM and sent to the engine's VdsBroker which persist it to the database. The pretty name is a friendly representation of the OS release/version and is displayed as a separate field in the UI Host->General->Software sub tab and is also available from the API when getting the host information. Change-Id: I0b1cc2fa4f9e351eae1b855670b3ffe505a2c618 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1346782 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDaoImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralSoftwareView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_01_0120_add_vds_dynamic_pretty_name.sql M packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql M packaging/dbscripts/vds_sp.sql 15 files changed, 66 insertions(+), 7 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59804 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b1cc2fa4f9e351eae1b855670b3ffe505a2c618 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[cli_3.6]: cli: Prepare for next release
by juan.hernandez＠redhat.com 05 Jul '16

05 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Prepare for next release ...................................................................... cli: Prepare for next release In preparation for the next release this patch increases the version number and sets the RPM release number to 0.1. Change-Id: Ib12dafc5174acdcf0b9d3858cdc62c342a91af62 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M setup.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60187 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib12dafc5174acdcf0b9d3858cdc62c342a91af62 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[cli_3.6]: cli: Release 3.6.8.0
by juan.hernandez＠redhat.com 05 Jul '16

05 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Release 3.6.8.0 ...................................................................... cli: Release 3.6.8.0 Change-Id: Id922a74c6896e68d92a9e519a07b90edb20c06ea Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M ovirt-engine-cli.spec.in M setup.py 3 files changed, 6 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60186 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id922a74c6896e68d92a9e519a07b90edb20c06ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: build: ovirt-engine-3.6.8
by tnisan＠redhat.com 05 Jul '16

05 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: build: ovirt-engine-3.6.8 ...................................................................... build: ovirt-engine-3.6.8 Change-Id: If0cb51c7667ec4cd1e44b30c53a9cf00d82a97cb Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M ovirt-engine.spec.in M pom.xml M version.mak 59 files changed, 65 insertions(+), 64 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Eyal Edri: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60177 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0cb51c7667ec4cd1e44b30c53a9cf00d82a97cb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: build: post ovirt-engine-3.6.8
by tnisan＠redhat.com 05 Jul '16

05 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: build: post ovirt-engine-3.6.8 ...................................................................... build: post ovirt-engine-3.6.8 Change-Id: I64027f290e6125d4f99781a97d9603cda2f8055e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M pom.xml M version.mak 58 files changed, 65 insertions(+), 63 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64027f290e6125d4f99781a97d9603cda2f8055e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.6]: Make ovirt-engine-cli more portable: - replace sys.platform ...
by juan.hernandez＠redhat.com 05 Jul '16

05 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: Make ovirt-engine-cli more portable: - replace sys.platform with os.name posix ...................................................................... Make ovirt-engine-cli more portable: - replace sys.platform with os.name posix Tested on OpenBSD. Change-Id: I721c51df0ec5f1ccb78b621535d87185c15ce799 Bug-Url: https://bugzilla.redhat.com/1304643 Signed-off-by: Jiri Belka <jbelka(a)redhat.com> Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 96eba69f7ec65e1e7fdb9671a9891e0e64e7670c) --- M src/cli/platform/__init__.py M src/ovirtcli/platform/__init__.py M src/ovirtcli/platform/windows/__init__.py 3 files changed, 9 insertions(+), 9 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/59740 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I721c51df0ec5f1ccb78b621535d87185c15ce799 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jiri Belka <jbelka(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-cli[cli_3.6]: cli: Don' flush input streams
by juan.hernandez＠redhat.com 05 Jul '16

05 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: cli: Don' flush input streams ...................................................................... cli: Don' flush input streams Flushing the input stream doesn't have any effect in the CLI, except that it throws an unexpected exception in some platforms, namely in Mac OS. This patch removes that flushing. Change-Id: Icee9677795f32ebc09cca16191962b0f4c1a012a Bug-Url: https://bugzilla.redhat.com/1303635 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit ded440f8b7b56d09ecce8fb95f622c3aed79bea8) --- M src/cli/context.py 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/59741 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icee9677795f32ebc09cca16191962b0f4c1a012a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jiri Belka <jbelka(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-4.0]: packaging: setup: Do not write db password to answerfile if ...
by Shirly Radco 05 Jul '16

05 Jul '16

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: Do not write db password to answerfile if provisioning ...................................................................... packaging: setup: Do not write db password to answerfile if provisioning Change-Id: I24691c6a845a85bcdc54c00d27fcad5d27cfc555 Bug-Url: https://bugzilla.redhat.com/1332892 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit d14cdd655b451a57dbdd528434cc6094117a0a9c) --- M packaging/setup/ovirt_engine_setup/dwh/constants.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/60176 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24691c6a845a85bcdc54c00d27fcad5d27cfc555 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-4.0 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0