July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: setup: Do not write dwh db password to answerfile...
by sbonazzo＠redhat.com 05 Jul '16

05 Jul '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Do not write dwh db password to answerfile if provisioning ...................................................................... packaging: setup: Do not write dwh db password to answerfile if provisioning Bug-Url: https://bugzilla.redhat.com/1351668 Change-Id: Ib012449a631b78f5c116aab135ab8fad668431b6 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/60029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib012449a631b78f5c116aab135ab8fad668431b6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Convert job and step status to upper case
by tnisan＠redhat.com 04 Jul '16

04 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Convert job and step status to upper case ...................................................................... restapi: Convert job and step status to upper case In version 4 of the API all the enums are represented using lower case, including the job and steps status. The values are by default copied without modification by the version 3 adapters. But some enums used to be represented using upper case in version 3 of the API, in particular job and step status used to be upper case, so we need to convert them. Change-Id: I237ce19f5995ce27647650bdf085227ae89e7d2d Bug-Url: https://bugzilla.redhat.com/1352575 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 96850da1bba491bba64c5a63229c36f182a03114) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3JobOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3StepOutAdapter.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/60163 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I237ce19f5995ce27647650bdf085227ae89e7d2d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Convert job and step status to upper case
by juan.hernandez＠redhat.com 04 Jul '16

04 Jul '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Convert job and step status to upper case ...................................................................... restapi: Convert job and step status to upper case In version 4 of the API all the enums are represented using lower case, including the job and steps status. The values are by default copied without modification by the version 3 adapters. But some enums used to be represented using upper case in version 3 of the API, in particular job and step status used to be upper case, so we need to convert them. Change-Id: I237ce19f5995ce27647650bdf085227ae89e7d2d Bug-Url: https://bugzilla.redhat.com/1352575 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3JobOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3StepOutAdapter.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60135 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I237ce19f5995ce27647650bdf085227ae89e7d2d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.1]: core: Take VM lock before assigning a pooled VM to user
by tnisan＠redhat.com 04 Jul '16

04 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Take VM lock before assigning a pooled VM to user ...................................................................... core: Take VM lock before assigning a pooled VM to user In AttachUserToVmFromPoolAndRunCommand, take an exclusive lock on the VM before setting user's ownership on it. This prevents other commands to act on this VM before it is run as the result of AttachUserToVmFromPoolAndRunCommand. On another side, if the VM is already locked by some other command (e.g. RunVmCommand), AttachUserToVmFromPoolAndRunCommand will not be able to lock it and will be forced to take another VM from the pool. Change-Id: Id2290f7b229041b989011f2acd4bf96af51357f9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1349049 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java 1 file changed, 107 insertions(+), 44 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60143 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2290f7b229041b989011f2acd4bf96af51357f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.1 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: fix HE disk unassigned status
by tnisan＠redhat.com 04 Jul '16

04 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: fix HE disk unassigned status ...................................................................... core: fix HE disk unassigned status Hosted engine disk status is unassigned although it is working correctly. fix : on hosted engine import VM - set the disk status to OK upgrade script : move all hosted engine disk images from unassigned status to OK when the VM is plugged. Change-Id: I0386843a7e23e89425c9bf5be075c1344c159eaf Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1339660 Signed-off-by: yquinn <yquinn(a)redhat.com> (cherry picked from commit 1b691ea) Signed-off-by: yquinn <yquinn(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HostedEngineImporter.java A packaging/dbscripts/upgrade/04_00_0790_change_disk_status_to_ok.sql 2 files changed, 14 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/60136 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0386843a7e23e89425c9bf5be075c1344c159eaf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.1]: core: Add parenthesis to sql remove query
by tnisan＠redhat.com 04 Jul '16

04 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Add parenthesis to sql remove query ...................................................................... core: Add parenthesis to sql remove query Once we remove old unreigstered disks of a storage domain the query should use parenthesis. Change-Id: I968d5a59039038089e9690a2e5f7c18f03195159 Bug-Url: https://bugzilla.redhat.com/1302780 Signed-off-by: Maor Lipchuk <maorlipchuk(a)gmail.com> --- M packaging/dbscripts/unregistered_disks_sp.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I968d5a59039038089e9690a2e5f7c18f03195159 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.1]: core: Pass storage pool ID to disk images on storage validation
by tnisan＠redhat.com 04 Jul '16

04 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Pass storage pool ID to disk images on storage validation ...................................................................... core: Pass storage pool ID to disk images on storage validation Commit 2c6791 introduced a refactoring of whether images exist on storage check, however it used the storage pool ID taken from the images where in the case of import the image storage pool ID contains the original storage pool the images resided on which may not be the storage pool we import the image to. The storage pool ID was restored from the original behavior and is now taken from the parameters of the commands. Change-Id: I505a70ccb142030d5db140c9da7b03eab939f646 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1352422 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidator.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60140 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I505a70ccb142030d5db140c9da7b03eab939f646 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cleanup in restore stateless vm
by ahadas＠redhat.com 04 Jul '16

04 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cleanup in restore stateless vm ...................................................................... core: cleanup in restore stateless vm Extract the code that detaches disks that are not part of the stateless snapshot to another method and the instantiation of the parameters for the DetachDiskFromVm to a separate method as well. Change-Id: I3fd4b2d3ace2d15071d50897f221b9990b8e1d67 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreStatelessVmCommand.java 1 file changed, 31 insertions(+), 17 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/59472 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fd4b2d3ace2d15071d50897f221b9990b8e1d67 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Pass storage pool ID to disk images on storage validation
by tnisan＠redhat.com 04 Jul '16

04 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Pass storage pool ID to disk images on storage validation ...................................................................... core: Pass storage pool ID to disk images on storage validation Commit 2c6791 introduced a refactoring of whether images exist on storage check, however it used the storage pool ID taken from the images where in the case of import the image storage pool ID contains the original storage pool the images resided on which may not be the storage pool we import the image to. The storage pool ID was restored from the original behavior and is now taken from the parameters of the commands. Change-Id: I505a70ccb142030d5db140c9da7b03eab939f646 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1352422 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ImportValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskImagesValidator.java 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60137 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I505a70ccb142030d5db140c9da7b03eab939f646 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: userportal: fix missing keys
by tnisan＠redhat.com 04 Jul '16

04 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: userportal: fix missing keys ...................................................................... userportal: fix missing keys Fix build errors due to missing keys Change-Id: I046d2237127ac72d4c446453c2b5f338db246cf1 Bug-Url: https://bugzilla.redhat.com/1255590 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Sahina Bose: Verified -- To view, visit https://gerrit.ovirt.org/60130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I046d2237127ac72d4c446453c2b5f338db246cf1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0