September 2016 - Engine-commits - oVirt List Archives

Change in jenkins[master]: Configure standard automation for mom
by eedri＠redhat.com 05 Sep '16

05 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: Configure standard automation for mom ...................................................................... Configure standard automation for mom Change-Id: I72af538767cfdef7f755fecccae612c9fa72ece8 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- D jobs/confs/projects/mom/mom_create-rpms.yaml A jobs/confs/projects/mom/mom_standard.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-3.6.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 5 files changed, 40 insertions(+), 72 deletions(-) Approvals: Martin Sivák: Looks good to me Sharon Naftaly: Verified; Looks good to me Eyal Edri: Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/62826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72af538767cfdef7f755fecccae612c9fa72ece8 Gerrit-PatchSet: 7 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add Ruby SDK builds and tests on ppc64le
by eedri＠redhat.com 05 Sep '16

05 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: Add Ruby SDK builds and tests on ppc64le ...................................................................... Add Ruby SDK builds and tests on ppc64le Also removed check-merged jobs as they do almost exactly the same thing as the build-artifacts jobs Change-Id: Ia78aaadff89e2e4bff682997337358e389c6ffdf Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- R jobs/confs/projects/ovirt-engine-sdk-ruby/ovirt-engine-sdk-ruby_standard.yaml 1 file changed, 12 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Looks good to me Eyal Edri: Verified; Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia78aaadff89e2e4bff682997337358e389c6ffdf Gerrit-PatchSet: 7 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Allow null cpu_profile_id in the DB
by tnisan＠redhat.com 05 Sep '16

05 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Allow null cpu_profile_id in the DB ...................................................................... core: Allow null cpu_profile_id in the DB Will not throw NPE if VM has null cpu_profile_id in the DB. Change-Id: Iad6281415ab0e9637bc12ecc0b9a9cfe8529f93e Bug-Url: https://bugzilla.redhat.com/1373090 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVmClusterValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelper.java 4 files changed, 30 insertions(+), 12 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/63296 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad6281415ab0e9637bc12ecc0b9a9cfe8529f93e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: restapi: Don't add V3 guest IP to links
by tnisan＠redhat.com 05 Sep '16

05 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Don't add V3 guest IP to links ...................................................................... restapi: Don't add V3 guest IP to links Currently the V3 compatibility layer tries to add the guest IP to all the returned objects of type "vm". That is wrong, as links, for example, shouldn't include such information. To solve the problem this patch changes the API so that the population of the guest IP is performed only for objects of type "vm" returned by the "list", "get", and "update" operations of the services that manage virtual machines. Change-Id: I68bfbb75cb3ef733625b2b11a9f744a664a69cda Bug-Url: https://bugzilla.redhat.com/1368552 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 371894f4b19605ebe10fe0e5e2cddd0146482c4a) (cherry picked from commit 3593f106ced78cb0daf6591b46c9de02970fcee8) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmsServer.java 4 files changed, 71 insertions(+), 57 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68bfbb75cb3ef733625b2b11a9f744a664a69cda Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: restapi: Ignore failures fetching additional disk data
by tnisan＠redhat.com 05 Sep '16

05 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Ignore failures fetching additional disk data ...................................................................... restapi: Ignore failures fetching additional disk data When disks are retrieved using version 3 of the API additional data is required, like the disk attachments. If the user doesn't have permission for the additional data then the complete operation fails. This is a problem for users that may not have permission for that additional data. In order to avoid that this patch changes the API so that failures to retrieve the additional data are just ignored. Change-Id: I37159aaa3d767df6c83e666bfcd70ad4ff503e87 Bug-Url: https://bugzilla.redhat.com/1368552 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit d4c500b16549b74839220c8a44b35de4ba9da6ee) (cherry picked from commit a4244b201386e1d2e0db4f92a99171bd5e2cd1ee) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDisksServer.java 3 files changed, 60 insertions(+), 15 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63321 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37159aaa3d767df6c83e666bfcd70ad4ff503e87 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: restapi: Don't add V3 disk attachment details to links
by tnisan＠redhat.com 05 Sep '16

05 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Don't add V3 disk attachment details to links ...................................................................... restapi: Don't add V3 disk attachment details to links Currently the V3 compatibility layer tries to add the attachment details (bootable, etc) to all the returned objects of type "disk". That is wrong, as links, for example, shoundn't include such information. To solve the problem this patch changes the API so that the population of these details is performed only for objects of type "disk" returned by the "list", "get", and "update" operations of the services that manage virtual machine disks. Change-Id: Ic8bc7e4b498d3d7ee7d09b60432b08f12be669c3 Bug-Url: https://bugzilla.redhat.com/1368552 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 9aa386f4ea54dd69e96fe87176a394ef6113d3ef) (cherry picked from commit c555df2ad30c9659a362d27e670d4192837ac4a0) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskOutAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDiskServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDisksServer.java 4 files changed, 49 insertions(+), 79 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63323 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8bc7e4b498d3d7ee7d09b60432b08f12be669c3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: frontend: Fix NPE in ImportVmFromExternalSourceModel
by tnisan＠redhat.com 05 Sep '16

05 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Fix NPE in ImportVmFromExternalSourceModel ...................................................................... frontend: Fix NPE in ImportVmFromExternalSourceModel Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373103 Change-Id: If400d25ac485d2ab94d670543773c41ff41c7f26 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalSourceModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/63311 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If400d25ac485d2ab94d670543773c41ff41c7f26 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: frontend: Fix NPE in ImportVmFromExternalSourceModel
by tnisan＠redhat.com 05 Sep '16

05 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: frontend: Fix NPE in ImportVmFromExternalSourceModel ...................................................................... frontend: Fix NPE in ImportVmFromExternalSourceModel Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373103 Change-Id: If400d25ac485d2ab94d670543773c41ff41c7f26 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalSourceModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Verified -- To view, visit https://gerrit.ovirt.org/63309 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If400d25ac485d2ab94d670543773c41ff41c7f26 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: [maven-release-plugin] prepare release 4.0.1
by omachace＠redhat.com 05 Sep '16

05 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare release 4.0.1 ...................................................................... [maven-release-plugin] prepare release 4.0.1 Change-Id: I21e436f994ff5ba9658881ac7dcdb4828fa9bc7e Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M automation/build-artifacts.sh M generator/pom.xml M packaging/build.sh M pom.xml M sdk/CHANGES.adoc M sdk/pom.xml 6 files changed, 22 insertions(+), 8 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21e436f994ff5ba9658881ac7dcdb4828fa9bc7e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: Fix tag names of action parameters
by omachace＠redhat.com 05 Sep '16

05 Sep '16

Ondra Machacek has submitted this change and it was merged. Change subject: Fix tag names of action parameters ...................................................................... Fix tag names of action parameters Currently when the SDK generates the XML document to invoke an action method it assumes that the names of the elements inside the 'action' match the names of the types of the parameters. This isn't correct, they should match the names of the parameters, not the names of the types. For example, the 'Host.iscsi_discover' action method has a parameter of type 'IscsiDetails' and name 'iscsi', so the tag should be 'iscsi', not 'iscsi_details'. To solve this issue this patch chages the SDK so that the implementation of action methods create an instance of the 'Action' type, and render it uusing the 'ActionWriter' class, which knows how to write it correctly. Change-Id: I25494bc638e3dc1098b1086bad94901ca03a72c9 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/java/ServicesImplGenerator.java 1 file changed, 9 insertions(+), 34 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63324 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25494bc638e3dc1098b1086bad94901ca03a72c9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0