January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Use 'Integer' instead of 'Fixnum'
by Code Review 31 Jan '17

31 Jan '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Use 'Integer' instead of 'Fixnum' ...................................................................... Use 'Integer' instead of 'Fixnum' Version 2.4 of Ruby unified the integer types into one single 'Integer' type. This patch adapts the SDK so that it uses it (mostly for documentation). Change-Id: Ie9c4b445c4f9f07184008c301b01f4f6ce0dfdd9 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 2a2b58ba3d64b2363a6339946ac7d23df2540c1f) --- M generator/src/main/java/org/ovirt/sdk/ruby/YardDoc.java M sdk/lib/ovirtsdk4/reader.rb M sdk/lib/ovirtsdk4/writer.rb M sdk/spec/reader_spec.rb 4 files changed, 7 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/71431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9c4b445c4f9f07184008c301b01f4f6ce0dfdd9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Use 'Integer' instead of 'Fixnum'
by Code Review 31 Jan '17

31 Jan '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Use 'Integer' instead of 'Fixnum' ...................................................................... Use 'Integer' instead of 'Fixnum' Version 2.4 of Ruby unified the integer types into one single 'Integer' type. This patch adapts the SDK so that it uses it (mostly for documentation). Change-Id: Ie9c4b445c4f9f07184008c301b01f4f6ce0dfdd9 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/YardDoc.java M sdk/lib/ovirtsdk4/reader.rb M sdk/lib/ovirtsdk4/writer.rb M sdk/spec/reader_spec.rb 4 files changed, 7 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71389 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9c4b445c4f9f07184008c301b01f4f6ce0dfdd9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: rename "Pass Discard" to "Enable Discard"
by Code Review 31 Jan '17

31 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: rename "Pass Discard" to "Enable Discard" ...................................................................... core: rename "Pass Discard" to "Enable Discard" Since the meaning of "Pass Discard" might not be clear enough, this patch renames the ui phrase to "Enable Discard", hoping that it will be easier to understand that the engine doesn't pass anything anywhere, but it does enable the discard functionality between the vm and the underlying storage. Change-Id: I366b32fd52881b1f9eec88bc852a821f4a429a23 Bug-Url: https://bugzilla.redhat.com/1416340 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 33 insertions(+), 33 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/71281 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I366b32fd52881b1f9eec88bc852a821f4a429a23 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: extract methods from the overloaded VM class
by Code Review 31 Jan '17

31 Jan '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: extract methods from the overloaded VM class ...................................................................... core: extract methods from the overloaded VM class The methods isSysprepUsed and isCloudInitUsed that are used only on run-VM are moved from the VM class to CreateVmVDSCommand. Change-Id: I45c8f5d4a32c2ba69684c6c1e337cb8df2ac5d62 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java 2 files changed, 16 insertions(+), 15 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/71426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45c8f5d4a32c2ba69684c6c1e337cb8df2ac5d62 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: vdsm: restore fc24 for master
by Code Review 31 Jan '17

31 Jan '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: vdsm: restore fc24 for master ...................................................................... vdsm: restore fc24 for master Change-Id: Ib0a3ab5ced4ba111c7d63ee7329d774a4b445f6e Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/vdsm/vdsm_standard.yaml 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71401 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0a3ab5ced4ba111c7d63ee7329d774a4b445f6e Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: remove redundant declarations from MacPoolPerCluster
by Code Review 31 Jan '17

31 Jan '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: remove redundant declarations from MacPoolPerCluster ...................................................................... engine: remove redundant declarations from MacPoolPerCluster Change-Id: I66ae92a147d9722a0cac27d24793c363232370ac Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolPerCluster.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/71405 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66ae92a147d9722a0cac27d24793c363232370ac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.1]: centos7: Fix collectd package conflict issue
by Code Review 30 Jan '17

30 Jan '17

>From Lev Veyde <lveyde(a)redhat.com>: Lev Veyde has submitted this change and it was merged. Change subject: centos7: Fix collectd package conflict issue ...................................................................... centos7: Fix collectd package conflict issue Change-Id: I14011ef26c189d404a533385b2d66540ca7f736d Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/kickstart/centos-7-livecd.cfg 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lev Veyde: Verified; Looks good to me, approved; Passed CI tests Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71386 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14011ef26c189d404a533385b2d66540ca7f736d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Poll vms stats on relevant statuses
by Code Review 30 Jan '17

30 Jan '17

>From Roy Golan <rgolan(a)redhat.com>: Roy Golan has submitted this change and it was merged. Change subject: core: Poll vms stats on relevant statuses ...................................................................... core: Poll vms stats on relevant statuses Motivation: When a host isn't really active its usless to try to fetch vm stats. Those attempts also add useless reports to handleNetworkException (cause the host is down or there is no connection yet) Change: Stop the code sharing with Host monitoring, and have a relevant set of statuses for stats refresh. Result: Fewer network failures handling, fewer calls to refresh stats. Also on engine startup, the stats poll isn't executed along with the activation of a host, which adds contention on the vdsmanager lock. Change-Id: I9bf1c92593dea587ff0cd887f5f33725729157e6 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/PollVmStatsRefresher.java A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/PollVmStatsRefresherTest.java 3 files changed, 113 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71364 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bf1c92593dea587ff0cd887f5f33725729157e6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Hide tracebacks in engine.log by upgrading non respo...
by Code Review 30 Jan '17

30 Jan '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: engine: Hide tracebacks in engine.log by upgrading non responsive host ...................................................................... engine: Hide tracebacks in engine.log by upgrading non responsive host During host upgrade process if a host is unreachable, engine shows the stacktrace in engine logs. The stacktrace can be in debug logs. Change-Id: If7a6ba98de04ee0d3a4f1a5f6334d6bcea366366 Bug-Url: https://bugzilla.redhat.com/1414787 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/HostUpgradeManager.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7a6ba98de04ee0d3a4f1a5f6334d6bcea366366 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: Always add console device
by Code Review 30 Jan '17

30 Jan '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: Always add console device ...................................................................... Always add console device When reading the vm ovf the console device was ignored. This patch adds the console device if it exists in the ovf and creates a stubbed device in case the ovf is missing it. That way the console commands will not fail. Change-Id: Id860888421097336a41b5a4612e58668de20c917 Bug-Url:https://bugzilla.redhat.com/1364132 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams_test.py 2 files changed, 17 insertions(+), 3 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Phillip Bailey: Looks good to me, but someone else must approve Jenny Tokar: Verified Martin Polednik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/71263 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id860888421097336a41b5a4612e58668de20c917 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0