January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: userportal: Remove disk confirmation doesn't fail
by Code Review 30 Jan '17

30 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: userportal: Remove disk confirmation doesn't fail ...................................................................... userportal: Remove disk confirmation doesn't fail Problem: Edit VM dialog threw ClassCastException when "-" button was clicked to remove VM disk in userportal extended. The problem was that there weren't registered special confirmation model popup provider and the default confirmation view (DefaultConfirmationPopupView) expects to work with String-s but DiskModel instance was provided in RemoveDiskModel#initialize(). Solution: Copied from webadmin: From now on the confirmation dialog is handled by VmDiskRemovePopupPresenterWidget the view of which can work work with DiskModel instances. Change-Id: Ic735419f4465bc1ac85b8be7b87962b5a68d3dd1 Bug-Url: https://bugzilla.redhat.com/1414455 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/UserPortalListProvider.java 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71388 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic735419f4465bc1ac85b8be7b87962b5a68d3dd1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: Add event type for updates check already running
by Code Review 30 Jan '17

30 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: Add event type for updates check already running ...................................................................... engine: Add event type for updates check already running A new event type was introduced with warning severity for the case of a check for available updates process is already running. Change-Id: I9ee347faec29f3fbc24c958893db6b77739c7a9e Bug-Url: https://bugzilla.redhat.com/1400500 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/HostUpdatesChecker.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 3 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Verified Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71371 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ee347faec29f3fbc24c958893db6b77739c7a9e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CreateUserSessionCommand type inference
by Code Review 30 Jan '17

30 Jan '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: CreateUserSessionCommand type inference ...................................................................... core: CreateUserSessionCommand type inference Change-Id: I183d7b3236b4f330643560cfa42f1cc894770179 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/CreateUserSessionCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/71224 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I183d7b3236b4f330643560cfa42f1cc894770179 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove redundant helper method
by Code Review 30 Jan '17

30 Jan '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: remove redundant helper method ...................................................................... core: remove redundant helper method Remove VmDeviceCommonUtils#updateVmDevicesBootOrder(VM, List<VmDevice>). Change-Id: I05404772d89f68c6985ed29f3a9c3430983e2f53 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtilsTest.java 3 files changed, 2 insertions(+), 10 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/71375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05404772d89f68c6985ed29f3a9c3430983e2f53 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Prevent users from using spaces in NFS paths
by Code Review 30 Jan '17

30 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Prevent users from using spaces in NFS paths ...................................................................... core: Prevent users from using spaces in NFS paths Add a check to make sure no spaces are present in the NFS mount path when adding a new storage domain Change-Id: Ib7f5c9accfec262e774be7fbb1ea086a38b7958c Bug-Url: https://bugzilla.redhat.com/1323663 Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com> (cherry picked from commit f727c310a133180e73db695493f376ffe0a23d35) --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NfsMountPointConstraint.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/NFSMountPointConstraintTest.java 3 files changed, 8 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Benny Zlotnik: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71381 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7f5c9accfec262e774be7fbb1ea086a38b7958c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fix potential bug in tooltip mechanism
by Code Review 30 Jan '17

30 Jan '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. Change subject: webadmin: fix potential bug in tooltip mechanism ...................................................................... webadmin: fix potential bug in tooltip mechanism Model.java has two overloading methods for setIsChangeable: 1. setIsChangeable(boolean value) 2. setIsChangeable(boolean value, String reason) If setIsChangeable(false, "reason") is called and right afterwards setIsChangeable(false) is called, then the model is indeed not changeable, but it also has an unwanted tooltip, "reason". This patch orders the mess with these methods and their overloading ones. Change-Id: I530ddd99c4f44287d46ffab45659a61a2a526ee3 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EntityModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java 2 files changed, 6 insertions(+), 14 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/71279 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I530ddd99c4f44287d46ffab45659a61a2a526ee3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Prevent the usage of spaces in the NFS path
by Code Review 30 Jan '17

30 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Prevent the usage of spaces in the NFS path ...................................................................... webadmin: Prevent the usage of spaces in the NFS path Add the NoSpacesValidation validation to NfsStorageModel.validate() in order to prevent users form entering spaces in the Export Path field in the "New Domain" window. Change-Id: Id2319ceb7883b7316c8568a30efbbe64ac97a99b Bug-Url: https://bugzilla.redhat.com/1323663 Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved; Passed CI tests Benny Zlotnik: Verified -- To view, visit https://gerrit.ovirt.org/71382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2319ceb7883b7316c8568a30efbbe64ac97a99b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: add VM snapshot ID to templates imported from a reposi...
by Code Review 30 Jan '17

30 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: add VM snapshot ID to templates imported from a repository ...................................................................... core: add VM snapshot ID to templates imported from a repository Imported templates from an image repository had no VM snapshot ID because there is no active snapshot. This patch adds a VM snapshot GUID to those templates in order to allow importing exported templates, a flow which was currently failing because of an empty GUID. Change-Id: I460a5f490ce47db119c873de35e9870a754acbcc Bug-Url: https://bugzilla.redhat.com/1399603 Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCommand.java 2 files changed, 8 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Benny Zlotnik: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71369 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I460a5f490ce47db119c873de35e9870a754acbcc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: packaging: requiring vds-client instead of vds-cli
by Code Review 30 Jan '17

30 Jan '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: requiring vds-client instead of vds-cli ...................................................................... packaging: requiring vds-client instead of vds-cli On master vds-cli hs been removed in favor of vds-client. Fixing the dependecy. Change-Id: I830605ea391a168e9ad48bdee81387e9e3f08d89 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-hosted-engine-ha.spec.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Yuval Turgeman: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I830605ea391a168e9ad48bdee81387e9e3f08d89 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: always compute boot order on run vm
by Code Review 30 Jan '17

30 Jan '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: always compute boot order on run vm ...................................................................... core: always compute boot order on run vm On regular run-VM we used to rely on the boot order that is set on each device, while on run-once we computed the boot order according to the given boot sequence (if it is different than the default boot sequence that is defined for the VM, otherwise it behaved as regular run). With this patch we always compute the boot order, not only on run-once flow (on regular run it is done according to the VM's default boot sequence). That way, we don't rely on the boot order that is set on each device, so it enables us to remove this field and get rid of the duplicated data whose management tends to complicate addition, update and removal of bootable devices. Change-Id: I20b6ad6c2002a857b073dd81a32be064415fbbcc Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java 2 files changed, 16 insertions(+), 41 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/71333 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20b6ad6c2002a857b073dd81a32be064415fbbcc Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0