January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: Add next run field messages
by Code Review 30 Jan '17

30 Jan '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: Add next run field messages ...................................................................... Add next run field messages On next run warning we display code fields such as 'minAllocatedMem' instead of 'Minimum Allocated Memory' Change-Id: If876d4f2dfa74de62b5b75e7949d3b1e3ced38c2 Bug-Url: https://bugzilla.redhat.com/1347356 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.java A frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/NextRunFieldMessages.java A frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/NextRunFieldMessages.properties 3 files changed, 28 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71000 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If876d4f2dfa74de62b5b75e7949d3b1e3ced38c2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: Cold Merge: Use volume generation
by Code Review 30 Jan '17

30 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: Cold Merge: Use volume generation ...................................................................... Cold Merge: Use volume generation Generation support is used to enhance error handling for jobs on non-responsive hosts and decide about job status: started, didn't start, failed or completed. Based on generation and volume lease, we could decide whether to fence the job. Change-Id: I9923e99207fe2ba72b16c145e707c1672a5b6a13 Bug-Url: https://bugzilla.redhat.com/1417458 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ColdMergeCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/SubchainInfo.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SubchainInfoHelper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java 7 files changed, 61 insertions(+), 15 deletions(-) Approvals: Jenkins CI: Passed CI tests Ala Hino: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9923e99207fe2ba72b16c145e707c1672a5b6a13 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Cold Merge: Fix SubchainInfo.toString
by Code Review 30 Jan '17

30 Jan '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: Cold Merge: Fix SubchainInfo.toString ...................................................................... Cold Merge: Fix SubchainInfo.toString Change-Id: I2cb5df19467d0a622e6e4337f973ed9f52a0f87b Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/SubchainInfo.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Ala Hino: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71348 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cb5df19467d0a622e6e4337f973ed9f52a0f87b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: order VMs by uptime doesn't work
by Code Review 30 Jan '17

30 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: order VMs by uptime doesn't work ...................................................................... core: order VMs by uptime doesn't work commit 166f43c3776a2332ce9cdf377795220fdb17f6e1 removed uptime which is needed by the search for sorting VMs by time elapsed Change-Id: Ibceac1cd71db90e16909def12e58b6b0ef189a96 Bug-Url: https://bugzilla.redhat.com/1416837 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStatisticsDaoImpl.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_01_0750_add_elapset_time_to_vm_statistics.sql M packaging/dbscripts/vms_sp.sql 5 files changed, 19 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Shahar Havivi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71330 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibceac1cd71db90e16909def12e58b6b0ef189a96 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Add event type for updates check already running
by Code Review 30 Jan '17

30 Jan '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Add event type for updates check already running ...................................................................... engine: Add event type for updates check already running A new event type was introduced with warning severity for the case of a check for available updates process is already running. Change-Id: I9ee347faec29f3fbc24c958893db6b77739c7a9e Bug-Url: https://bugzilla.redhat.com/1400500 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/HostUpdatesChecker.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 3 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/71250 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ee347faec29f3fbc24c958893db6b77739c7a9e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: setup: let vmconsole proxy be stopped on cleanup
by Code Review 30 Jan '17

30 Jan '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: setup: let vmconsole proxy be stopped on cleanup ...................................................................... setup: let vmconsole proxy be stopped on cleanup We must make sure that engine-cleanup actually cleans up the ovirt-vmconsole-proxy. This means stopping the service, if running. Change-Id: I5910b214470a69ffd3d2fc5fdc546ec6de32e402 Bug-Url: https://bugzilla.redhat.com/1276670 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/vmconsole_proxy_helper/constants.py M packaging/setup/plugins/ovirt-engine-common/vmconsole_proxy_helper/core.py A packaging/setup/plugins/ovirt-engine-remove/vmconsole_proxy_helper/__init__.py A packaging/setup/plugins/ovirt-engine-remove/vmconsole_proxy_helper/misc.py M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/config.py 5 files changed, 141 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/65968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5910b214470a69ffd3d2fc5fdc546ec6de32e402 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Cold Merge: Use volume generation
by Code Review 29 Jan '17

29 Jan '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: Cold Merge: Use volume generation ...................................................................... Cold Merge: Use volume generation Generation support is used to enhance error handling for jobs on non-responsive hosts and decide about job status: started, didn't start, failed or completed. Based on generation and volume lease, we could decide whether to fence the job. Change-Id: I9923e99207fe2ba72b16c145e707c1672a5b6a13 Signed-off-by: Ala Hino <ahino(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ColdMergeCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/SubchainInfo.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SubchainInfoHelper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java 7 files changed, 61 insertions(+), 15 deletions(-) Approvals: Jenkins CI: Passed CI tests Ala Hino: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9923e99207fe2ba72b16c145e707c1672a5b6a13 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: add "shared" lock for the AddVmTemplateCommand
by Code Review 29 Jan '17

29 Jan '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: backend: add "shared" lock for the AddVmTemplateCommand ...................................................................... backend: add "shared" lock for the AddVmTemplateCommand On AddVmTemplateCommand we added a lock ("shared") for the VM. Change-Id: If4822f781b2c426c9fc26ed9af6e52605065497b Bug-Url: https://bugzilla.redhat.com/1364137 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 14 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Sharon Gratch: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71008 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4822f781b2c426c9fc26ed9af6e52605065497b Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: do not treat video device as bootable device
by Code Review 29 Jan '17

29 Jan '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: do not treat video device as bootable device ...................................................................... core: do not treat video device as bootable device Recent change in VmInfoBuilderImpl added video device to the collection named managedDevices. This collection is only used to set the boot order on bootable devices. Since video device is not a bootable device, it should be added to that collection. The name of the collection is confusing, thus this patch renames it so it will better reflect its intended use. Change-Id: If2108bd0b25015c8bd9a3ba9344dc5954bba90c2 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java 1 file changed, 11 insertions(+), 12 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/71332 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2108bd0b25015c8bd9a3ba9344dc5954bba90c2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: avoid failing on "no free macs" when no re-assign
by Code Review 29 Jan '17

29 Jan '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: avoid failing on "no free macs" when no re-assign ...................................................................... engine: avoid failing on "no free macs" when no re-assign Avoid failing on MAC_POOL_NOT_ENOUGH_MAC_ADDRESSES when no re-assign was requested. Change-Id: Ia19513f5c11fc03fb80d75259a91749e71fc930e Bug-Url: https://bugzilla.redhat.com/1390575 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicMacsUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmNicMacsUtilsTest.java 4 files changed, 72 insertions(+), 10 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/71195 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia19513f5c11fc03fb80d75259a91749e71fc930e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0