February 2017 - Engine-commits - oVirt List Archives

Change in jenkins[master]: cockpit-ovirt: fix exclude list and add fc25
by Code Review 02 Feb '17

02 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: cockpit-ovirt: fix exclude list and add fc25 ...................................................................... cockpit-ovirt: fix exclude list and add fc25 Change-Id: I5b667896bde45a7c007b6c0e56a96bf14d3d256f Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/cockpit-ovirt/cockpit-ovirt.yaml 1 file changed, 20 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71592 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b667896bde45a7c007b6c0e56a96bf14d3d256f Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1.0.z]: core: treat template's actual disk size as editable field
by Code Review 02 Feb '17

02 Feb '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: treat template's actual disk size as editable field ...................................................................... core: treat template's actual disk size as editable field This field is not being set anyway (it is generated from the template's disks) so there is no problem in setting it as editable just for the reflection-based validation to pass on update template. Proper fix, however, will be to remove the actual disks size from the template. Change-Id: I216ca19c1a060e0931390d681da8217da316a00a Bug-Url: https://bugzilla.redhat.com/1417597 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> (cherry picked from commit 689eeeb016f84b874308ca7df4e21f050778e28d) --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/71591 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I216ca19c1a060e0931390d681da8217da316a00a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1.0.z Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: fedora: add fc25 support
by Code Review 02 Feb '17

02 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: fedora: add fc25 support ...................................................................... fedora: add fc25 support Change-Id: Ie30abac61f5840f381a6335272d7bd506bb7c3bc Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M Makefile.am M configure.ac A ovirt-f25-deps.repo.in M ovirt-release-master.spec.in 4 files changed, 59 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/71563 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie30abac61f5840f381a6335272d7bd506bb7c3bc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: do not persist VmDevice#bootOrder
by Code Review 02 Feb '17

02 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: do not persist VmDevice#bootOrder ...................................................................... core: do not persist VmDevice#bootOrder Now that we don't rely on the persisted value of 'bootOrder' of VmDevice (since the boot order is being computed on each run according to the VM's default boot sequence or the boot sequence that is specified on run-once flow, see I20b6ad), it can be removed from the database. Change-Id: Ibcabcc281698fa51b7b8f403010b8d57fbf9a574 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotSetAmountOfMemoryCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ConvertVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/DetachDiskFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetWatchdogQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/RemoveImageCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtilsTest.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoringTest.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmDevicesListModelTable.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_02_0130_remove_boot_order.sql M packaging/dbscripts/vm_device_sp.sql 37 files changed, 80 insertions(+), 267 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/71346 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcabcc281698fa51b7b8f403010b8d57fbf9a574 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: automation: fix repositories handling
by Code Review 02 Feb '17

02 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: fix repositories handling ...................................................................... automation: fix repositories handling we had issues with yum repositories due to conflicts between epel and CentOS OpsTool Change-Id: Ie801c8f7aeec25358b149c65ff7f53411c986a25 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/check-patch.sh 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/71567 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie801c8f7aeec25358b149c65ff7f53411c986a25 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Awkward attempted login error
by Code Review 02 Feb '17

02 Feb '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: aaa: Awkward attempted login error ...................................................................... aaa: Awkward attempted login error Remove error page for showing errors and display them on welcome page using patternfly alert pattern. Change-Id: I20ed60f116a5f23f4dc1ac21c071092ffd7e380e Bug-Url: https://bugzilla.redhat.com/1412687 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/LoginServlet.java M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeServlet.java M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeUtils.java D backend/manager/modules/welcome/src/main/webapp/WEB-INF/error.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml M packaging/services/ovirt-engine/ovirt-engine.conf.in 7 files changed, 28 insertions(+), 90 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71126 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20ed60f116a5f23f4dc1ac21c071092ffd7e380e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-release_standard: add fc25 support
by Code Review 02 Feb '17

02 Feb '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-release_standard: add fc25 support ...................................................................... ovirt-release_standard: add fc25 support Change-Id: I4d18af28053618698c770698e26392d3bbba5f99 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-release/ovirt-release_standard.yaml 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71574 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d18af28053618698c770698e26392d3bbba5f99 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: switching ovirt-engine-nodejs to use standard CI (2 of 2)
by Code Review 02 Feb '17

02 Feb '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: switching ovirt-engine-nodejs to use standard CI (2 of 2) ...................................................................... switching ovirt-engine-nodejs to use standard CI (2 of 2) - this patch deletes the old jobs - also remove job from nightly publishers Change-Id: I77a2970f105702aeaea5f3a9739e13ce775ab562 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- D jobs/confs/projects/ovirt-engine-nodejs/ovirt-engine-nodejs.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-4.1.yaml M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml 4 files changed, 0 insertions(+), 71 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Passed CI tests; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71541 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77a2970f105702aeaea5f3a9739e13ce775ab562 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: switching ovirt-engine-nodejs-modules to use standard CI (1 ...
by Code Review 02 Feb '17

02 Feb '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: switching ovirt-engine-nodejs-modules to use standard CI (1 of 2) ...................................................................... switching ovirt-engine-nodejs-modules to use standard CI (1 of 2) - this patch adds the new jobs Change-Id: Ibdebb94031c309900519b2a5135e923a48d114a3 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- A jobs/confs/projects/ovirt-engine-nodejs-modules/ovirt-engine-nodejs-modules_standard.yaml A jobs/confs/yaml/scms/ovirt-engine-nodejs-modules.yaml 2 files changed, 33 insertions(+), 0 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Ready for merge Barak Korren: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71413 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdebb94031c309900519b2a5135e923a48d114a3 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <david(a)dcaro.es> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pavel(a)zhukoff.net> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: aaa: Username is mandatory for LoginOnBehalf
by Code Review 02 Feb '17

02 Feb '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: aaa: Username is mandatory for LoginOnBehalf ...................................................................... aaa: Username is mandatory for LoginOnBehalf If user name is not passed for LoginOnBehalf SSO should reject the request and return an error message. Change-Id: I85cc8b5788b0d451eb9016bcb03c33ced5db5a77 Bug-Url: https://bugzilla.redhat.com/1414083 Signed-off-by: Ravi Nori <rnori(a)redhat.com> (cherry picked from commit 84d39b612e2f3cd79ef9e24a28c8985ce3b2eb28) --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenServlet.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70721 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85cc8b5788b0d451eb9016bcb03c33ced5db5a77 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0