May 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[master]: Add VM pool create example
by Code Review 12 May '17

12 May '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add VM pool create example ...................................................................... Add VM pool create example This patch add example how to create VM pool. Change-Id: Ieee3f0a47aceb8610ada304eabf9c1072f89df00 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- A sdk/examples/add_vm_pool.py 1 file changed, 61 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieee3f0a47aceb8610ada304eabf9c1072f89df00 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Add VM pool create example
by Code Review 12 May '17

12 May '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add VM pool create example ...................................................................... Add VM pool create example This patch add example how to create VM pool. Change-Id: Ieee3f0a47aceb8610ada304eabf9c1072f89df00 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- A sdk/examples/add_vm_pool.py 1 file changed, 61 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76755 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieee3f0a47aceb8610ada304eabf9c1072f89df00 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Actions can return HTTP 201 and 202 response code
by Code Review 11 May '17

11 May '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Actions can return HTTP 201 and 202 response code ...................................................................... Actions can return HTTP 201 and 202 response code The API actions can return HTTP reponse codes 201 and 202, this patch ensure we handle those codes. Change-Id: I0c6a566fd755f7057e3ac5ff2cf66f1f41641c09 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M sdk/lib/ovirtsdk4/service.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76720 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c6a566fd755f7057e3ac5ff2cf66f1f41641c09 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Lock the wait method for multithreaded execution
by Code Review 11 May '17

11 May '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Lock the wait method for multithreaded execution ...................................................................... Lock the wait method for multithreaded execution Recently introduced asynchronous support for Python SDK introduced wait method, which are sending request via cURL library. This method needs to be locked while executing with same lock as 'send' method, as the CurlMutli can't be changed while executing the perform operation. Change-Id: I4c672b140b61e0d7d9f18f461a6e725a8943af55 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit cd0adb4774f7c4bcfcd14a1d09504ddce795fd06) --- M sdk/lib/ovirtsdk4/__init__.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76714 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c672b140b61e0d7d9f18f461a6e725a8943af55 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Lock the wait method for multithreaded execution
by Code Review 11 May '17

11 May '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Lock the wait method for multithreaded execution ...................................................................... Lock the wait method for multithreaded execution Recently introduced asynchronous support for Python SDK introduced wait method, which are sending request via cURL library. This method needs to be locked while executing with same lock as 'send' method, as the CurlMutli can't be changed while executing the perform operation. Change-Id: I4c672b140b61e0d7d9f18f461a6e725a8943af55 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M sdk/lib/ovirtsdk4/__init__.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76713 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c672b140b61e0d7d9f18f461a6e725a8943af55 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Use DBUnit flat format
by Code Review 11 May '17

11 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Use DBUnit flat format ...................................................................... core: Use DBUnit flat format This patch converts fixtures.xml from the DBUnit's old XML format to the newer flat XML format. The motivation here is maintainability - each row becomes self-descriptive, and can be read and understood independently, instead of having to scroll up several (dozens, if not hundreds of) rows to read the column definition. Comparing the size of the file before and after this patch could give a good idea about the improved maintainability. Before the patch, this file weighed 424KB and contained 10091 rows. After applying this patch, it weighs 268KB (~37% less) and contains only 743 rows (~93% less). The process: 1. The file was converted using DBUnit Transformer [1] 2. The code was changed to load a flat XML instead of the traditional XML. 3. Empty rows were added between each table to make the resulting file easier to read. 4. FixturesTest, which is no longer needed with the new format, was removed. 5. The DAO tests were run to assure they were not broken, naturally. [1] https://github.com/mureinik/dbunit-transformer Change-Id: I48c1de98385c39890002ec3d06f7928bab2cb2aa Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/FixturesTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDaoTestCase.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 3 files changed, 625 insertions(+), 10,070 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48c1de98385c39890002ec3d06f7928bab2cb2aa Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Upgrade to DBUnit 2.5.3
by Code Review 11 May '17

11 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Upgrade to DBUnit 2.5.3 ...................................................................... core: Upgrade to DBUnit 2.5.3 DBUnit 2.4.8 we used to use is more than six years old(!), and it's time to retire it. The newer version improves the native support for Postgres and modern Java versions, and offers a bunch of bugfixes and performance enhancements. Note that DBUnit 2.5.3 is stricter than 2.4.8, and requires some minor changes to make the test suite pass: 1. The non-default DatabaseConfig.FEATURE_ALLOW_EMPTY_FIELDS property needs to be set to true in order to allow <value></value> entries. 2. Timezone and offsets seem to be broken in PostgreSQL. Since these values don't seem to affect the tests themselves, the timezones and offsets were cleared from the dataset. Change-Id: I2966ffdfae0cbdd7412f7288ba8217246f9ae0a9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/pom.xml M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDaoTestCase.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 3 files changed, 10 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Verified; Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2966ffdfae0cbdd7412f7288ba8217246f9ae0a9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove explicit nulls from fixtures.xml
by Code Review 11 May '17

11 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove explicit nulls from fixtures.xml ...................................................................... core: Remove explicit nulls from fixtures.xml Explicitly stating null column values in DBUnit's flat XML is usually redundant at best (assuming the column doesn't have a non-null default) or confusing at worst (as it's unclear whether mycolumn="null" means the column should get a null value or the string literal 'null'). This patch cleans up the fixtures file by removing these nulls. Change-Id: Ifd9258c67483312f47bd66dc33f48ae4a1c47e46 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/dal/src/test/resources/fixtures.xml 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/76680 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd9258c67483312f47bd66dc33f48ae4a1c47e46 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: SSO token used for the API expires when running only qu...
by Code Review 11 May '17

11 May '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: aaa: SSO token used for the API expires when running only queries ...................................................................... aaa: SSO token used for the API expires when running only queries The session soft limit should be updated for all queries executed by ovirt-app-api scope. Change-Id: I33d298275f44b89e49c0fb0021454f567f6f9093 Bug-Url: https://bugzilla.redhat.com/1434605 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76683 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33d298275f44b89e49c0fb0021454f567f6f9093 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core,webadmin: new business entities
by Code Review 11 May '17

11 May '17

>From Alona Kaplan <alkaplan(a)redhat.com>: Alona Kaplan has submitted this change and it was merged. Change subject: core,webadmin: new business entities ...................................................................... core,webadmin: new business entities Change-Id: I93ef28e908a7b6701ea992081bb0706bdd9ac060 Bug-Url: https://bugzilla.redhat.com/1160667 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/DnsResolverConfiguration.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NameServer.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/network/DnsResolverConfigurationTest.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 5 files changed, 148 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/65431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93ef28e908a7b6701ea992081bb0706bdd9ac060 Gerrit-PatchSet: 33 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0