May 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: core: Free VM lock if attaching a VM from pool failed
by Code Review 01 May '17

01 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Free VM lock if attaching a VM from pool failed ...................................................................... core: Free VM lock if attaching a VM from pool failed If VM is allocated to user from a VM Pool and the VM is not prestarted, lock is taken on it early to prevent race condition between AttachUserToVmFromPoolAndRunCommand and VmPoolMonitor. In regular flow, this lock is freed by RunVmCommand. But if validation of AttachUserToVmFromPoolAndRunCommand is failed or exception is thrown for some reason, this lock must be freed explicitly. Change-Id: I6d13d3196dd7e2557390675066e0b861071d846f Bug-Url: https://bugzilla.redhat.com/1433924 Bug-Url: https://bugzilla.redhat.com/1432105 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76246 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d13d3196dd7e2557390675066e0b861071d846f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Set action message parameters in RemoveVmPoolCommand
by Code Review 01 May '17

01 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Set action message parameters in RemoveVmPoolCommand ...................................................................... core: Set action message parameters in RemoveVmPoolCommand Action and type variables must be set in RemoveVmPoolCommand to be substituted in error messages. Change-Id: Id4a5065bc08aa97b63afcddd8c1b33452e7a218e Bug-Url: https://bugzilla.redhat.com/1418290 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmPoolCommand.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76245 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4a5065bc08aa97b63afcddd8c1b33452e7a218e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Avoid injection in SchedulingManager
by Code Review 01 May '17

01 May '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Avoid injection in SchedulingManager ...................................................................... engine: Avoid injection in SchedulingManager Since all of the data to be logged is already present at the creating of the audit-log entity, there is no need to inject any beans to the AuditLogableBase and it can be replaced with a leaner and more efficient implementation of the AuditLogable. Change-Id: I5f869bd6655398244ae41f65f23f99f0328bc303 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AlertDirector.java 2 files changed, 12 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/75718 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f869bd6655398244ae41f65f23f99f0328bc303 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: no need to initialize a field before it is being set
by Code Review 01 May '17

01 May '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: no need to initialize a field before it is being set ...................................................................... engine: no need to initialize a field before it is being set Change-Id: Ie6696bb7cf49c764c94e96fbd186eb9beaded0a3 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscovery.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Looks good to me, but someone else must approve Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/76106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6696bb7cf49c764c94e96fbd186eb9beaded0a3 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Remove 3.6 and 4.0 findbugs jobs
by Code Review 01 May '17

01 May '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Remove 3.6 and 4.0 findbugs jobs ...................................................................... Remove 3.6 and 4.0 findbugs jobs Change-Id: Ic552319ae095f52555e93574ee1f06d6f7591991 Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_findbugs.yaml M jobs/confs/yaml/templates/find-bugs.yaml 2 files changed, 0 insertions(+), 34 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests Daniel Belenky: Ready for review -- To view, visit https://gerrit.ovirt.org/76269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic552319ae095f52555e93574ee1f06d6f7591991 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Remove unused DbFacade mock
by Code Review 01 May '17

01 May '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: engine: Remove unused DbFacade mock ...................................................................... engine: Remove unused DbFacade mock In MigrateVmCommandTest the DbFacade mock is not needed. Change-Id: I2b9118997bc9aabdc30ec7ef25c54eeec3cc1e88 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MigrateVmCommandTest.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Freddy Rolland: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76238 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b9118997bc9aabdc30ec7ef25c54eeec3cc1e88 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Removed ovirt-engine_master_find-bugs jobs
by Code Review 01 May '17

01 May '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Removed ovirt-engine_master_find-bugs jobs ...................................................................... Removed ovirt-engine_master_find-bugs jobs As the functionality of exporting findbugs files was moved to std ci, and ovirt-engine (master) was patched to execute findbugs during it's check-patch and check-merged phases, I'm removing the dedicated job. Change-Id: Iad1681a74a8be0c2f1a98ce026c4d8e1c8399174 Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_findbugs.yaml M jobs/confs/yaml/templates/find-bugs.yaml 2 files changed, 0 insertions(+), 34 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Daniel Belenky: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad1681a74a8be0c2f1a98ce026c4d8e1c8399174 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0