May 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: One less reduandant method
by Code Review 03 May '17

03 May '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: One less reduandant method ...................................................................... engine: One less reduandant method Change-Id: I72fa6b02ae769194aa342d04e438540c619aee97 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalEventCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AlertDirector.java 2 files changed, 1 insertion(+), 6 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/76201 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72fa6b02ae769194aa342d04e438540c619aee97 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Simplify logging in AuditLogDirector
by Code Review 03 May '17

03 May '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Simplify logging in AuditLogDirector ...................................................................... engine: Simplify logging in AuditLogDirector Change-Id: If205bf9d98d81d7d3bde1109d5da70fe255a74e5 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 1 file changed, 18 insertions(+), 14 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/76200 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If205bf9d98d81d7d3bde1109d5da70fe255a74e5 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Use conventional AuditLogDirector log method
by Code Review 03 May '17

03 May '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Use conventional AuditLogDirector log method ...................................................................... engine: Use conventional AuditLogDirector log method The AuditLogDirector.log() which expects unformat message is too complex and its usage is less clear, especially when it can be totally avoided. NetworkConfigurator error handling is updated to avoid it. Change-Id: Id03c91d2837178480653756bfa030dbae042110f Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/NetworkConfiguratorTest.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 6 insertions(+), 18 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/76199 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id03c91d2837178480653756bfa030dbae042110f Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: Add to unremovable only files we wrote
by Code Review 03 May '17

03 May '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Add to unremovable only files we wrote ...................................................................... packaging: setup: Add to unremovable only files we wrote Without this, /etc/exports is always added to uninstall.d, even if engine-setup is exiting early. Change-Id: Ia68b1295cb4bad1b5d5498cc03fbe42b7f54e100 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/base/core/uninstall.py 1 file changed, 18 insertions(+), 14 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Ido Rosenzwig: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/76105 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia68b1295cb4bad1b5d5498cc03fbe42b7f54e100 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: automation: build on check-patch
by Code Review 02 May '17

02 May '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: build on check-patch ...................................................................... automation: build on check-patch as last test on check-patch, perform a build. Change-Id: I795c90c015953a2a4aa9a125f3ccc345e8c5feb4 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/check-patch.packages M automation/check-patch.sh 2 files changed, 7 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I795c90c015953a2a4aa9a125f3ccc345e8c5feb4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: restore: forcing status on HA VMs at restore time
by Code Review 02 May '17

02 May '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: restore: forcing status on HA VMs at restore time ...................................................................... restore: forcing status on HA VMs at restore time Forcing status on HA VMs at restore time to avoid the engine restarting them just after the restore with corruption risks. Change-Id: I8b90e54522ac294399db77317b6841ce810e8d88 Bug-Url: https://bugzilla.redhat.com/1446055 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/bin/engine-backup.sh.in 1 file changed, 21 insertions(+), 2 deletions(-) Approvals: Lev Veyde: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76166 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b90e54522ac294399db77317b6841ce810e8d88 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restore: forcing status on HA VMs at restore time
by Code Review 02 May '17

02 May '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: restore: forcing status on HA VMs at restore time ...................................................................... restore: forcing status on HA VMs at restore time Forcing status on HA VMs at restore time to avoid the engine restarting them just after the restore with corruption risks. Change-Id: I8b90e54522ac294399db77317b6841ce810e8d88 Bug-Url: https://bugzilla.redhat.com/1441322 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M packaging/bin/engine-backup.sh.in 1 file changed, 21 insertions(+), 2 deletions(-) Approvals: Lev Veyde: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76145 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b90e54522ac294399db77317b6841ce810e8d88 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: engine-backup: Allow setting temp dir
by Code Review 02 May '17

02 May '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: packaging: engine-backup: Allow setting temp dir ...................................................................... packaging: engine-backup: Allow setting temp dir Add an option --tmpdir=DIR to set the parent of the temporary directory that's created. Defaults to $TMPDIR if set, otherwise to /tmp. Change-Id: I13f07418329fd6347e3ec86f52438db220da393f Bug-Url: https://bugzilla.redhat.com/1445631 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh.in M packaging/man/man8/engine-backup.8 2 files changed, 20 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/76060 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13f07418329fd6347e3ec86f52438db220da393f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Reuse code and prefer AuditLogableImpl
by Code Review 01 May '17

01 May '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Reuse code and prefer AuditLogableImpl ...................................................................... engine: Reuse code and prefer AuditLogableImpl Change-Id: Id282885c4ed36dd6a677769be5132b9caaf60405 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/NetworkConfiguratorTest.java 2 files changed, 11 insertions(+), 9 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/76174 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id282885c4ed36dd6a677769be5132b9caaf60405 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Avoid log injection in HostNetworkTopologyPersisterImpl
by Code Review 01 May '17

01 May '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Avoid log injection in HostNetworkTopologyPersisterImpl ...................................................................... engine: Avoid log injection in HostNetworkTopologyPersisterImpl Since all of the data to be logged is already present at the creating of the audit-log entity, there is no need to inject any beans to the AuditLogableBase and it can be replaced with a leaner and more efficient implementation of the AuditLogable. Change-Id: If19f402976dbe76a9534fd547dba4a63467b826b Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostNetworkTopologyPersisterImpl.java 1 file changed, 11 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76129 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If19f402976dbe76a9534fd547dba4a63467b826b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0