7:22 p.m.
--7AUc2qLy4jB3hD7Z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hi everyone!
Lately there have been found issues with the findbugs job:
http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-bugs_merged/1373/
It turns out that it was running only on fc20 hosts, and there it ran well,=
but
fc20 hosts have been removed (not supported anymore) and the test started
running on el6/el7 hosts, and the version there is slightly different and it
started complaining about issues it did not complain before.
The quick fix is to solve the issue:
BackendApiResource.java:264, DE_MIGHT_IGNORE, Priority: Low
org.ovirt.engine.api.restapi.resource.BackendApiResource.getSchema() might =
ignore java.io.IOException
But that leaves another question, which plataforms should we run findbugs o=
n?
should we use a matrix of platforms? always the same?
It's your call, so please let me know what you want to do (I'll just pin it=
to
el7 host for now, to avoid flaky tests).
Thanks!!
--=20
David Caro
Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605
Email: dcaro(a)redhat.com
Web: www.redhat.com
RHT Global #: 82-62605
--7AUc2qLy4jB3hD7Z
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJV0cP/AAoJEEBxx+HSYmnDJWYH/3N8Zf+yg7iqfn6WteZrKupd
1gdT2jqTv6d6XyfkZW8izj+tjfL5iqL5tUBgxCyNkxM+Ewh5zetVLNDqHkNakONF
NNxH4BFvx2D8SM1XK89bz9la1DMPkalhOFMj+VPR3bHniyXfWmNwjF+3M6pbDbp1
XTSeC1J6b0OgQfnJn0fkuhFogdw9LjlVeVc+975Sve9qp28xfT50wmK7ul3FUuxy
C+OKsXbF2vRDDw3wc2K4dqgCn456bq2rPZYNq225/Qo49QiTb511zP+Duzrhi06U
Pu1cw8VHHv9uVWNDbKERXWXCVYVFm5lSdNeBk32ATAbjLaVmDn4gPWpLn+ZvmWQ=
=DNfT
-----END PGP SIGNATURE-----
--7AUc2qLy4jB3hD7Z--
8:45 p.m.
*Also worth mentioning:*
"job1": http://jenkins.ovirt.org/job/ovirt-engine_3.5_dao-unit-tests_gerrit,
does:
1. does some sql-foo to create a db with some data
2. runs maven as follows:
export MAVEN_OPTS=" -XX:MaxPermSize=512m"
mvn \
-P enable-dao-tests \
-D engine.db.username=engine \
-D engine.db.password=engine \
-s
/home/jenkins/workspace/ovirt-engine_3.5_dao-unit-tests_gerrit/artifactory-ovirt-org-settings.xml
\
-Dengine.db.url=jdbc:postgresql://localhost/ovirt_engine_3_5_dao_unit_tests_gerrit_369
\
install
"job2": http://jenkins.ovirt.org/job/ovirt-engine_3.5_unit_tests_gerrit,
does:
1. Run maven (I've "beautified" this just to ease on comparison, and
it's indirect run via wrapped up make target):
mvn \
-f ovirt-engine/pom.xml \
-s
/home/jenkins/workspace/ovirt-engine_3.5_unit_tests_gerrit/artifactory-ovirt-org-settings.xml
\
-DGERRIT_HOST=gerrit.ovirt.org \
-DGERRIT_PATCHSET_UPLOADER="Alon Bar-Lev <alonbl(a)redhat.com>" \
-DGERRIT_EVENT_ACCOUNT_NAME="Alon Bar-Lev" \
-DGERRIT_EVENT_TYPE=patchset-created \
-DGERRIT_CHANGE_ID=I97fa20e0f5205ebddb6aff1cbfebf3f2879fa34e \
-DGERRIT_TOPIC=host-deploy \
-DGERRIT_CHANGE_NUMBER=44875 \
-DGERRIT_VERSION="2.10.3.1" \
-DGERRIT_PATCHSET_UPLOADER_NAME="Alon Bar-Lev" \
-DGERRIT_CHANGE_COMMIT_MESSAGE=aG9zdC1kZXBsb3k6IHJlbW92ZSB0aW1lc3RhbXAgY2FjaGUgY2hlY2sgZm9yIHRhcmJhbGwKCndoZW4gbXVsdGlwbGUgcGFja2FnZXMgbWFuYWdlIHRoZSBkaXJlY3RvcnkgdHJlZSwgdGhlIGxhc3QgZmlsZQp0aW1lc3RhbXAgY2Fubm90IGJlIHVzZWQgYXMgcmVmZXJlbmNlIHRvIGNhY2hlIGludGVncml0eSBhcyBhbiBvbGRlcgpwYWNrYWdlIG1heSBiZSBhcHBsaWVkIGFmdGVyIG5ld2VyIG9uZS4KCndlIGNvdWxkIGhhdmUgdXNlZCBoYXNoIG1lY2hhbmlzbSwgYnV0IHRoZW4gd2UgaGFkIHRvIHJlYWQgZmlsZXMgb25jZQpwZXIgaGFzaCBhbmQgb25jZSBwZXIgY3JlYXRpb24sIHNvIGJldHRlciB0byBqdXN0IGNyZWF0ZSB0aGUgdGFyYmFsbCBhdApkZXNpZ25hdGVkIGludGVydmFsLgoKQnVnLVVybDogaHR0cHM6Ly9idWd6aWxsYS5yZWRoYXQuY29tL3Nob3dfYnVnLmNnaT9pZD0xMjUyMzY0CkNoYW5nZS1JZDogSTk3ZmEyMGUwZjUyMDVlYmRkYjZhZmYxY2JmZWJmM2YyODc5ZmEzNGUKU2lnbmVkLW9mZi1ieTogQWxvbiBCYXItTGV2IDxhbG9uYmxAcmVkaGF0LmNvbT4K
\
-DGERRIT_PATCHSET_UPLOADER_EMAIL=alonbl(a)redhat.com \
-DGERRIT_BRANCH=ovirt-engine-3.5 \
-DGERRIT_EVENT_HASH=-1504677913 \
-DGERRIT_PORT=29418 \
-DGERRIT_NAME=gerrit.ovirt.org \
-DGERRIT_CHANGE_OWNER_NAME="Alon Bar-Lev" \
-DGERRIT_EVENT_ACCOUNT="Alon Bar-Lev <alonbl(a)redhat.com>" \
-DGERRIT_EVENT_ACCOUNT_EMAIL=alonbl(a)redhat.com \
-DGERRIT_CHANGE_OWNER="Alon Bar-Lev <alonbl(a)redhat.com>" \
-DGERRIT_CHANGE_URL=https://gerrit.ovirt.org/44875 \
-DGERRIT_SCHEME=ssh \
-DGERRIT_CHANGE_SUBJECT="host-deploy: remove timestamp cache check
for tarball" \
-DGERRIT_REFSPEC=refs/changes/75/44875/1 \
-DGERRIT_PATCHSET_NUMBER=1 \
-DGERRIT_PATCHSET_REVISION=fb26eba4f8ebe696a31c584e162edca9c17ef801 \
-DGERRIT_PROJECT=ovirt-engine \
-DGERRIT_CHANGE_OWNER_EMAIL=alonbl(a)redhat.com \
-Dmaven.repo.local=/home/jenkins/workspace/ovirt-engine_3.5_unit_tests_gerrit/.repository
\
test
Maybe we could do as follows: sequential run of combined job doing
1. maybe in parallel:
1. run: sql foo
2. job2 run - general unit tests: mvn clean test <with params of job2>
2. wait for 1.1 and 1.2. to complete, and then job1 run:mvn test -P
enable-dao-tests <with params of job1>
The above could theoretically reduce total runtime of job1+job2 by 1/3.
Given: job1 runs ~16m, job2 runs ~15m [most time ~10m is spent waiting
for artifactory downloads, IIRC]
Expected outcome:
we could save 10m, reaching 21m, or even more, if the 2nd mvn run
could probably reuse some of already compiled .class files, we'd could
be even faster than 20m.
Possible Pitfals:
1. problems combining tests result reports [if it indeed happens.
*devs*, please comment]
2. we might need to be able to run job1 and job2 separately:
- Workaround:
- split job1 into II parts: job1.sql-foo and job1.mvn
- run "workflow" (sharing workspace):
parallel(job1.sql-foo,job2) ==> run job1.mvn
WDYT?
On Mon, Aug 17, 2015 at 2:22 PM, David Caro <dcaro(a)redhat.com> wrote:
Hi everyone!
Lately there have been found issues with the findbugs job:
http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-bugs_merged/1373/
It turns out that it was running only on fc20 hosts, and there it ran
well, but
fc20 hosts have been removed (not supported anymore) and the test started
running on el6/el7 hosts, and the version there is slightly different and
it
started complaining about issues it did not complain before.
The quick fix is to solve the issue:
BackendApiResource.java:264, DE_MIGHT_IGNORE, Priority: Low
org.ovirt.engine.api.restapi.resource.BackendApiResource.getSchema() might
ignore java.io.IOException
But that leaves another question, which plataforms should we run findbugs
on?
should we use a matrix of platforms? always the same?
It's your call, so please let me know what you want to do (I'll just pin
it to
el7 host for now, to avoid flaky tests).
Thanks!!
--
David Caro
Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605
Email: dcaro(a)redhat.com
Web: www.redhat.com
RHT Global #: 82-62605
_______________________________________________
Devel mailing list
Devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
--
Max Kovgan
Senior Software Engineer
Red Hat - EMEA ENG Virtualization R&D
Tel.: +972 9769 2060
Email: mkovgan [at] redhat [dot] com
Web: http://www.redhat.com
RHT Global #: 82-72060
9:37 p.m.
--7mxbaLlpDEyR1+x6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 08/17, Max Kovgan wrote:
*Also worth mentioning:*
=20
=20
"job1": http://jenkins.ovirt.org/job/ovirt-engine_3.5_dao-unit-tests_gerr=
it,
does:
=20
1. does some sql-foo to create a db with some data
2. runs maven as follows:
=20
export MAVEN_OPTS=3D" -XX:MaxPermSize=3D512m"
mvn \
-P enable-dao-tests \
-D engine.db.username=3Dengine \
-D engine.db.password=3Dengine \
-s
/home/jenkins/workspace/ovirt-engine_3.5_dao-unit-tests_gerrit/artifactor=
y-ovirt-org-settings.xml
\
-Dengine.db.url=3Djdbc:postgresql://localhost/ovirt_engine_3_5_dao_unit_t=
ests_gerrit_369
\
install
=20
"job2": http://jenkins.ovirt.org/job/ovirt-engine_3.5_unit_tests_gerrit,
does:
=20
1. Run maven (I've "beautified" this just to ease on comparison, and
it's indirect run via wrapped up make target):
=20
mvn \
=20
-f ovirt-engine/pom.xml \
=20
-s /home/jenkins/workspace/ovirt-engine_3.5_unit_tests_gerrit/artifactor=
y-ovirt-org-settings.xml
\
=20
-DGERRIT_HOST=3Dgerrit.ovirt.org \
=20
-DGERRIT_PATCHSET_UPLOADER=3D"Alon Bar-Lev <alonbl(a)redhat.com>" \
=20
-DGERRIT_EVENT_ACCOUNT_NAME=3D"Alon Bar-Lev" \
=20
-DGERRIT_EVENT_TYPE=3Dpatchset-created \
=20
-DGERRIT_CHANGE_ID=3DI97fa20e0f5205ebddb6aff1cbfebf3f2879fa34e \
=20
-DGERRIT_TOPIC=3Dhost-deploy \
=20
-DGERRIT_CHANGE_NUMBER=3D44875 \
=20
-DGERRIT_VERSION=3D"2.10.3.1" \
=20
-DGERRIT_PATCHSET_UPLOADER_NAME=3D"Alon Bar-Lev" \
=20
-DGERRIT_CHANGE_COMMIT_MESSAGE=3DaG9zdC1kZXBsb3k6IHJlbW92ZSB0aW1lc3RhbXA=
gY2FjaGUgY2hlY2sgZm9yIHRhcmJhbGwKCndoZW4gbXVsdGlwbGUgcGFja2FnZXMgbWFuYWdlIH=
RoZSBkaXJlY3RvcnkgdHJlZSwgdGhlIGxhc3QgZmlsZQp0aW1lc3RhbXAgY2Fubm90IGJlIHVzZ=
WQgYXMgcmVmZXJlbmNlIHRvIGNhY2hlIGludGVncml0eSBhcyBhbiBvbGRlcgpwYWNrYWdlIG1h=
eSBiZSBhcHBsaWVkIGFmdGVyIG5ld2VyIG9uZS4KCndlIGNvdWxkIGhhdmUgdXNlZCBoYXNoIG1=
lY2hhbmlzbSwgYnV0IHRoZW4gd2UgaGFkIHRvIHJlYWQgZmlsZXMgb25jZQpwZXIgaGFzaCBhbm=
Qgb25jZSBwZXIgY3JlYXRpb24sIHNvIGJldHRlciB0byBqdXN0IGNyZWF0ZSB0aGUgdGFyYmFsb=
CBhdApkZXNpZ25hdGVkIGludGVydmFsLgoKQnVnLVVybDogaHR0cHM6Ly9idWd6aWxsYS5yZWRo=
YXQuY29tL3Nob3dfYnVnLmNnaT9pZD0xMjUyMzY0CkNoYW5nZS1JZDogSTk3ZmEyMGUwZjUyMDV=
lYmRkYjZhZmYxY2JmZWJmM2YyODc5ZmEzNGUKU2lnbmVkLW9mZi1ieTogQWxvbiBCYXItTGV2ID=
xhbG9uYmxAcmVkaGF0LmNvbT4K
\
=20
-DGERRIT_PATCHSET_UPLOADER_EMAIL=3Dalonbl(a)redhat.com \
=20
-DGERRIT_BRANCH=3Dovirt-engine-3.5 \
=20
-DGERRIT_EVENT_HASH=3D-1504677913 \
=20
-DGERRIT_PORT=3D29418 \
=20
-DGERRIT_NAME=3Dgerrit.ovirt.org \
=20
-DGERRIT_CHANGE_OWNER_NAME=3D"Alon Bar-Lev" \
=20
-DGERRIT_EVENT_ACCOUNT=3D"Alon Bar-Lev <alonbl(a)redhat.com>" \
=20
-DGERRIT_EVENT_ACCOUNT_EMAIL=3Dalonbl(a)redhat.com \
=20
-DGERRIT_CHANGE_OWNER=3D"Alon Bar-Lev <alonbl(a)redhat.com>" \
=20
-DGERRIT_CHANGE_URL=3Dhttps://gerrit.ovirt.org/44875 \
=20
-DGERRIT_SCHEME=3Dssh \
=20
-DGERRIT_CHANGE_SUBJECT=3D"host-deploy: remove timestamp cache check
for tarball" \
=20
-DGERRIT_REFSPEC=3Drefs/changes/75/44875/1 \
=20
-DGERRIT_PATCHSET_NUMBER=3D1 \
=20
-DGERRIT_PATCHSET_REVISION=3Dfb26eba4f8ebe696a31c584e162edca9c17ef801 \
=20
-DGERRIT_PROJECT=3Dovirt-engine \
=20
-DGERRIT_CHANGE_OWNER_EMAIL=3Dalonbl(a)redhat.com \
=20
-Dmaven.repo.local=3D/home/jenkins/workspace/ovirt-engine_3.5_unit_tests=
_gerrit/.repository
\
=20
test
=20
=20
=20
Maybe we could do as follows: sequential run of combined job doing
=20
=20
1. maybe in parallel:
1. run: sql foo
2. job2 run - general unit tests: mvn clean test <with params of jo=
b2>
2. wait for 1.1 and 1.2. to complete, and then job1 run:mvn test
-P
enable-dao-tests <with params of job1>
=20
=20
The above could theoretically reduce total runtime of job1+job2 by 1/3.
=20
Given: job1 runs ~16m, job2 runs ~15m [most time ~10m is spent waiting
for artifactory downloads, IIRC]
Expected outcome:
we could save 10m, reaching 21m, or even more, if the 2nd mvn run
could probably reuse some of already compiled .class files, we'd could
be even faster than 20m.
=20
Possible Pitfals:
=20
1. problems combining tests result reports [if it indeed happens.
*devs*, please comment]
2. we might need to be able to run job1 and job2 separately:
- Workaround:
- split job1 into II parts: job1.sql-foo and job1.mvn
- run "workflow" (sharing workspace):
parallel(job1.sql-foo,job2) =3D=3D> run job1.mvn
=20
WDYT?
I'd wait until we have a proper pipeline, and try to generalize the definit=
ion
of the test ordering putting it in the same repo as the project. Adding this
right now will increase the maintenance of the overall setup, and will
complicate the migration to a pipeline.
Though, if you can do all that inside a bash script, we can use it as
check-patch.sh for the ovirt-engine project and use that, though I suppose =
that
you might prefer letting jenkins do the job orchestration instead of having=
to
rewrite that code in bash.
=20
=20
=20
On Mon, Aug 17, 2015 at 2:22 PM, David Caro <dcaro(a)redhat.com> wrote:
=20
>
> Hi everyone!
>
> Lately there have been found issues with the findbugs job:
> http://jenkins.ovirt.org/job/ovirt-engine_3.5_find-bugs_merged/1373/
>
> It turns out that it was running only on fc20 hosts, and there it ran
> well, but
> fc20 hosts have been removed (not supported anymore) and the test start=
ed
> running on el6/el7 hosts, and the version there is slightly
different a=
nd
> it
> started complaining about issues it did not complain before.
>
> The quick fix is to solve the issue:
>
> BackendApiResource.java:264, DE_MIGHT_IGNORE, Priority: Low
> org.ovirt.engine.api.restapi.resource.BackendApiResource.getSchema() mi=
ght
> ignore java.io.IOException
>
>
> But that leaves another question, which plataforms should we run findbu=
gs
> on?
> should we use a matrix of platforms? always the same?
>
> It's your call, so please let me know what you want to do (I'll just pin
> it to
> el7 host for now, to avoid flaky tests).
>
> Thanks!!
>
>
> --
> David Caro
>
> Red Hat S.L.
> Continuous Integration Engineer - EMEA ENG Virtualization R&D
>
> Tel.: +420 532 294 605
> Email: dcaro(a)redhat.com
> Web: www.redhat.com
> RHT Global #: 82-62605
>
> _______________________________________________
> Devel mailing list
> Devel(a)ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>
=20
=20
=20
--=20
Max Kovgan
=20
Senior Software Engineer
Red Hat - EMEA ENG Virtualization R&D
Tel.: +972 9769 2060
Email: mkovgan [at] redhat [dot] com
Web: http://www.redhat.com
RHT Global #: 82-72060
_______________________________________________
Devel mailing list
Devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
--=20
David Caro
Red Hat S.L.
Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605
Email: dcaro(a)redhat.com
Web: www.redhat.com
RHT Global #: 82-62605
--7mxbaLlpDEyR1+x6
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAEBAgAGBQJV0eOmAAoJEEBxx+HSYmnD4kkH/2UpMyvRYwui8p/xow2+PSiN
yKdSwz8jfvse05RJXSRpFbZtlgI+E4sPqJkq3nsxEv9DQZJYGWZngv/aFvy3Ink6
9wA6L6NLFJ2jPyfLK3YaNAozFCrBIK+JA7+WqoRu5Ph267nKHY6VeUkddEn3pPD6
PR92UUgjU1/TUNIPu+lanewyktwPiwwN4zevLjHHpZ7hNMgLyGgn2AqXU321JoAI
ay40LYh2c51xP5G3ZRko+W7yjueNug1qpCM+/35LVcn1TZBsBQoz/GEbUvI1GtPg
va6dW8MXrVkAaXAOyAaj/JAhNm1WyUEd8yPlS428b+DnZP19EOs6iexZhdry8G4=
=V8aS
-----END PGP SIGNATURE-----
--7mxbaLlpDEyR1+x6--
3176
days inactive
3176
days old
2 comments
2 participants
participants (2)
-
David Caro -
Max Kovgan