as announced we are going to have oVirt online conference coming in
I would like to give usual community updates in and as part of that I'd
like to report about oVirt downstream products (such as Red Hat
Virtualization and Oracle Linux Virtualization Manager) and about companies
I could just go googling and guessing by e-mail traffic on oVirt users list
but I want to try a different approach this year.
So, if you are shipping an oVirt downstream or if you're using oVirt and
you'd like to get the company nominated during the community reports please
let me know off-list.
Also I'd like to remind that oVirt site has a section dedicated to user
stories, if you want to share yours you can either push it to
https://github.com/oVirt/ovirt-site or get in touch with me off-list to get
help getting your story published.
MANAGER, SOFTWARE ENGINEERING, EMEA R&D RHV
Red Hat EMEA <https://www.redhat.com/>
*Red Hat respects your work life balance. Therefore there is no need to
answer this email out of your office hours.*
We have several different styles of where/how to import fixtures in
- import directly inside the test code
- import in conftest.py
- import in fixtures modules
- For all of above, both 'import *' and importing specific fixtures
I think we should try to agree on a specific style and then follow it.
One drawback of importing directly in test/fixtures code is that it's
then impossible to override them in conftest.py.
A drawback of importing '*' and/or doing this in conftest.py is that
you might inadvertently import more than you want, or this might
happen eventually (after more stuff are added), that this makes it
harder to find what uses what, and that it risks unintended collisions
in names - as opposed to intended overrides.
A related issue is having to update many places if you add/change something.
If there is some kind of "best practices" document somewhere that
people are happy with, perhaps we should follow it. Otherwise, we
should come up with our own.
Personally I think I'd like to have a single file with all the
imports, of specific fixtures (not '*'), and import this file from
conftest.py of all the suites. Didn't actually try this and no idea
what complications it might bring.
Comments/ideas/opinions/decisions are welcome :-)
Today we've tagged what will be 4.4.7 RC build, to maintain stability and
to allow work on 4.4.8 we have branched 4.4.7 in case of bugs found on the
RC Build that need to be fixed.
The general guidelines:
For your 4.4.8 work - just push to master
For 4.4.7 work (blockers/exceptions only!) - push to master and once it's
merged backport to the ovirt-engine-4.4.7.z branch
On Wed, Jun 23, 2021 at 1:03 PM Code Review <gerrit(a)ovirt.org> wrote:
> From Jenkins CI <jenkins(a)ovirt.org>:
> Jenkins CI has posted comments on this change. ( https://gerrit.ovirt.org/c/ovirt-system-tests/+/115191 )
> Change subject: Make the ansible_inventory fixture backend-independent
> Patch Set 16: Continuous-Integration-1
> Build Failed
> https://jenkins.ovirt.org/job/ovirt-system-tests_standard-check-patch/17451/ : FAILURE
Can someone please have a look and decide if this failure is reasonable?
The screenshot of the failed "Open cluster list view" does not show
anything suspicious at all , to me, but not sure how it should
otherwise look - e.g. should it include a pointer, which might imply
where we tried to move, etc. It timed out 3 minutes after a successful
If it's not supposed to include a pointer, perhaps we should try to
make selenium do include a pointer in the screenshots - I have a
feeling this can help debug other UI issues. But I don't know this
code at all...
Thanks and best regards,
> To view, visit https://gerrit.ovirt.org/c/ovirt-system-tests/+/115191
> To unsubscribe, or for help writing mail filters, visit https://gerrit.ovirt.org/settings
> Gerrit-Project: ovirt-system-tests
> Gerrit-Branch: master
> Gerrit-Change-Id: Id07012f8fc3a972a3b62d32f2271d5747514e13a
> Gerrit-Change-Number: 115191
> Gerrit-PatchSet: 16
> Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
> Gerrit-Reviewer: Andrej Cernek <acernek(a)redhat.com>
> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
> Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com>
> Gerrit-Reviewer: Dusan Fodor <dfodor(a)redhat.com>
> Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com>
> Gerrit-Reviewer: Galit Rosenthal <grosenth(a)redhat.com>
> Gerrit-Reviewer: Jenkins CI <jenkins(a)ovirt.org>
> Gerrit-Reviewer: Marcin Sobczyk <msobczyk(a)redhat.com>
> Gerrit-Reviewer: Name of user not set #1001916
> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
> Gerrit-Comment-Date: Wed, 23 Jun 2021 10:03:15 +0000
> Gerrit-HasComments: No
> Gerrit-Has-Labels: Yes
> Gerrit-MessageType: comment
In ovirt-imageio developer docs, we ask to install the commit-msg hook
wget -P .git/hooks https://gerrit.ovirt.org/tools/hooks/commit-msg
This downloads now a broken script that does not add a ChangeId header.
In the past I think it returned something like the attached file,
without the code for
I suggest to replace the current file at:
Or if we want to keep the default file for some reason, add:
This file contains the code for adding the signed-off-by header, so so
do not need to add this manually:
# Add Signed-off-by trailer.
sob=$(git var GIT_AUTHOR_IDENT | sed -n 's/^\(.*>\).*$/Signed-off-by: \1/p')
git interpret-trailers --in-place --trailer "$sob" "$1"
Later we need to replace this ugly shell script with proper code.