May 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: GetNextAvailableDiskAliasNameByVMIdQueryTest
by mlipchuk＠redhat.com 15 May '12

15 May '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: GetNextAvailableDiskAliasNameByVMIdQueryTest ...................................................................... core: GetNextAvailableDiskAliasNameByVMIdQueryTest Removed PowerMock dependency for better performance. Change-Id: I58d067ddce89e0652e9ec4aba5feaf55151a0a03 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetNextAvailableDiskAliasNameByVMIdQueryTest.java 2 files changed, 23 insertions(+), 18 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, but someone else must approve Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58d067ddce89e0652e9ec4aba5feaf55151a0a03 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Mappers for Gluster entities
by oliel＠redhat.com 15 May '12

15 May '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Mappers for Gluster entities ...................................................................... restapi: Mappers for Gluster entities Mappers and JUnit tests for: - Gluster Volume - Gluster Brick Introduced following utility method and JUnit tests for the same: EnumUtils#enumCollectionToStringList Change-Id: I364d853106eda1a956241eb7210ce85781ee88b9 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/EnumUtils.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GlusterBrickMapper.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GlusterVolumeMapper.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/GlusterBrickMapperTest.java A backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/GlusterVolumeMapperTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/EnumUtilsTest.java 6 files changed, 371 insertions(+), 1 deletion(-) Approvals: Ori Liel: Verified; Looks good to me, approved Shireesh Anjal: Verified -- To view, visit http://gerrit.ovirt.org/3385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I364d853106eda1a956241eb7210ce85781ee88b9 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Eoghan Glynn <eoghan.glynn(a)gmail.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Preview snapshot with allow snapshot attribute
by mlipchuk＠redhat.com 15 May '12

15 May '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Preview snapshot with allow snapshot attribute ...................................................................... core: Preview snapshot with allow snapshot attribute Disk which are not allowed to be snapshot, should not be part of the snapshot operation. Those disks are static and should not be changed, they should only be reflected in the VM whether the VM is in snapshot mode or not. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I4d0e5bd4dff1898022f78e379ffa30824912ed1f --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java 2 files changed, 20 insertions(+), 5 deletions(-) Approvals: Michael Kublin: Looks good to me, approved Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d0e5bd4dff1898022f78e379ffa30824912ed1f Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add diskAlias and description to OVF.
by mlipchuk＠redhat.com 15 May '12

15 May '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add diskAlias and description to OVF. ...................................................................... core: Add diskAlias and description to OVF. Adding support for alias name and description for disk when export/import a VM or template Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: Iefb9b5d9805fb316096557321f8cd6e0c925245a --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java 2 files changed, 18 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefb9b5d9805fb316096557321f8cd6e0c925245a Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Introduce allow snapshot attribute for disk
by mlipchuk＠redhat.com 15 May '12

15 May '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Introduce allow snapshot attribute for disk ...................................................................... core: Introduce allow snapshot attribute for disk Adding field of allow snapshot to disk entity. For now this field will be used for shared disk and direct lun. In the future it should indicate which disk will be snapshot in the VM or not. Disk which will have false allow snapshot attribute will be static in the VM, which means there will be no representation in time of the disk. When VM will be previewed and commited or rollbacked after that, the disk will still be part of the VM. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I99caa62cd6f966fe6867fb2f42bcf5019fa65ee5 --- M backend/manager/dbscripts/base_disks_sp.sql M backend/manager/dbscripts/create_views.sql A backend/manager/dbscripts/upgrade/03_01_1080_add_allow_snapshot.sql M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmByVmIdQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LunDisk.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AbstractDiskRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BaseDiskDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDiskDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 12 files changed, 72 insertions(+), 15 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99caa62cd6f966fe6867fb2f42bcf5019fa65ee5 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: rest: Add shareable and allow snapshot properties
by mlipchuk＠redhat.com 15 May '12

15 May '12

Maor Lipchuk has submitted this change and it was merged. Change subject: rest: Add shareable and allow snapshot properties ...................................................................... rest: Add shareable and allow snapshot properties Add shareable and allow snapshot properties to disk entity in rest. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I523dcdf3f98bd81c6ca5edc07fa81bf1caf7959e --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDisksResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DiskMapperTest.java 5 files changed, 21 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I523dcdf3f98bd81c6ca5edc07fa81bf1caf7959e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Adding CDA messages for shareable disk
by mlipchuk＠redhat.com 15 May '12

15 May '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Adding CDA messages for shareable disk ...................................................................... core: Adding CDA messages for shareable disk Adding validation messages for shareable disk. The validation massages should be used when adding/updating a disk. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I5f280674744807dffc9c333d357a08fab08c309c --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 8 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f280674744807dffc9c333d357a08fab08c309c Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use cache for disk list
by mlipchuk＠redhat.com 15 May '12

15 May '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use cache for disk list ...................................................................... core: Use cache for disk list Using cache to get disks when creating snapshots for VM. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I45370ae18910d9b33844822d59ef293e4239796d --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45370ae18910d9b33844822d59ef293e4239796d Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: searchbackend: Add search for shared and snapshotable
by mlipchuk＠redhat.com 15 May '12

15 May '12

Maor Lipchuk has submitted this change and it was merged. Change subject: searchbackend: Add search for shared and snapshotable ...................................................................... searchbackend: Add search for shared and snapshotable Adding allow snaoshot field and shareable fields for disk search. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: Ib6ba0aea5e0d5871e11a80940eb9fdc4a3c3d496 --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DiskImageConditionFieldAutoCompleter.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6ba0aea5e0d5871e11a80940eb9fdc4a3c3d496 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup of DiskImageDaoWrapper
by mlipchuk＠redhat.com 15 May '12

15 May '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Cleanup of DiskImageDaoWrapper ...................................................................... core: Cleanup of DiskImageDaoWrapper Use final decleration. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: Ife35704bad553ea120ed7809f3d5230da7578add --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAOWrapperImpl.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4228 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife35704bad553ea120ed7809f3d5230da7578add Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0