May 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: UnPowerMock GetConfigurationValueQueryTest
by yzaslavs＠redhat.com 15 May '12

15 May '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: UnPowerMock GetConfigurationValueQueryTest ...................................................................... core: UnPowerMock GetConfigurationValueQueryTest Removed PowerMock dependency from GetConfigurationValueQueryTest using the new MockConfigRule. Change-Id: Ia804b70eda4896457ea16cf3abd59cf5333bcb4c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetConfigurationValueQueryTest.java 1 file changed, 6 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia804b70eda4896457ea16cf3abd59cf5333bcb4c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock SearchQueryTest
by yzaslavs＠redhat.com 15 May '12

15 May '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: UnPowerMock SearchQueryTest ...................................................................... core: UnPowerMock SearchQueryTest Removed PowerMock dependency from SearchQueryTest using the new MockConfigRule and spying the getDbFacade() method of the query. Change-Id: I11e14c1b5baf611de4eecde8274fd9ed89245c3f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SearchQueryTest.java 1 file changed, 38 insertions(+), 52 deletions(-) Approvals: Allon Mureinik: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4399 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11e14c1b5baf611de4eecde8274fd9ed89245c3f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock VersionSupportTest
by yzaslavs＠redhat.com 15 May '12

15 May '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: UnPowerMock VersionSupportTest ...................................................................... core: UnPowerMock VersionSupportTest Removed PowerMock dependency from VersionSupportTest and replaced it with the new MockConfigRule mechanism. Change-Id: I15aec7066dae47a540ba545037cd5885e040a6e1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/VersionSupportTest.java 1 file changed, 10 insertions(+), 23 deletions(-) Approvals: Allon Mureinik: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15aec7066dae47a540ba545037cd5885e040a6e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock StorageHandlingCommandBaseTest
by yzaslavs＠redhat.com 15 May '12

15 May '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: UnPowerMock StorageHandlingCommandBaseTest ...................................................................... core: UnPowerMock StorageHandlingCommandBaseTest Removed PowerMock dependecy from StorageHandlingCommandBaseTest and replaced with the new MockConfigRule. Change-Id: I437a40657d33e54eaa0c5af471ba864be4745bad Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBaseTest.java 1 file changed, 20 insertions(+), 16 deletions(-) Approvals: Allon Mureinik: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4397 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I437a40657d33e54eaa0c5af471ba864be4745bad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock StorageDomainSpaceCheckerTest
by yzaslavs＠redhat.com 15 May '12

15 May '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: UnPowerMock StorageDomainSpaceCheckerTest ...................................................................... core: UnPowerMock StorageDomainSpaceCheckerTest Removed PowerMock dependency from StorageDomainSpaceCheckerTest, using the new MockConfigRule. Change-Id: I6a50a72aa002467b393cefc6d23b3f1232578de1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/command/utils/StorageDomainSpaceCheckerTest.java 1 file changed, 7 insertions(+), 14 deletions(-) Approvals: Allon Mureinik: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a50a72aa002467b393cefc6d23b3f1232578de1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock MinaInstallWrapperTimeoutTest
by yzaslavs＠redhat.com 15 May '12

15 May '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: UnPowerMock MinaInstallWrapperTimeoutTest ...................................................................... core: UnPowerMock MinaInstallWrapperTimeoutTest Replaced PowerMock static mocking with MockConfigRule. Change-Id: If2dbf14afef85ef58be28ecafab249d0fba5df58 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/MinaInstallWrapperTimeoutTest.java 1 file changed, 6 insertions(+), 16 deletions(-) Approvals: Allon Mureinik: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2dbf14afef85ef58be28ecafab249d0fba5df58 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup VdsUpdateRunTimeInfoTest
by yzaslavs＠redhat.com 15 May '12

15 May '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Cleanup VdsUpdateRunTimeInfoTest ...................................................................... core: Cleanup VdsUpdateRunTimeInfoTest Added static modifiers where possible, as per Eclipse IDE warnings. Change-Id: I82f5269e24c907234a7762e9bbd031ea776f697d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsUpdateRunTimeInfoTest.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82f5269e24c907234a7762e9bbd031ea776f697d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Import VM UX improvements
by gchaplik＠redhat.com 14 May '12

14 May '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Import VM UX improvements ...................................................................... webadmin: Import VM UX improvements Change-Id: Ia35c1737226e6ed8fbb211841d4e9b2436078f5b Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.ui.xml 5 files changed, 45 insertions(+), 33 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia35c1737226e6ed8fbb211841d4e9b2436078f5b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Fixed compilation permutations issue
by gchaplik＠redhat.com 14 May '12

14 May '12

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal: Fixed compilation permutations issue ...................................................................... userportal: Fixed compilation permutations issue This patch returns the gwt-compilation of the user portal to include permutations according to the "gwt.userAgent" variable, instead of only "gecko1_8" (which was wrongfully inserted in http://gerrit.ovirt.org/4161) Change-Id: I7ebba05bb32510fdd822b00dae0bd84656468e78 Signed-off-by: Einav Cohen <ecohen(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/UserPortal.gwt.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ebba05bb32510fdd822b00dae0bd84656468e78 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Using AdUsersSearch and AdGroupsSearch
by vszocs＠redhat.com 14 May '12

14 May '12

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal: Using AdUsersSearch and AdGroupsSearch ...................................................................... userportal: Using AdUsersSearch and AdGroupsSearch It also required to create UserPortalPermissionListModel and UserPortalAdElementListModel. Change-Id: I42a0b2090b8d0bf7ad4e29966d40363b57fdb8e5 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/permissions/AbstractPermissionsPopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/UserPortalPermissionListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/AdElementListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPortalAdElementListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/permissions/PermissionsPopupPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/extended/vm/SubTabExtendedVmPermissionPresenter.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/permissions/PermissionsPopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/vm/SubTabExtendedVmPermissionView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/VmPermissionListModelProvider.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/PermissionsPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/PermissionsPopupView.java 14 files changed, 133 insertions(+), 52 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4335 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42a0b2090b8d0bf7ad4e29966d40363b57fdb8e5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0