May 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Use shareable indication when VDSM create VM.
by mlipchuk＠redhat.com 15 May '12

15 May '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use shareable indication when VDSM create VM. ...................................................................... core: Use shareable indication when VDSM create VM. Use shareable indication when creating a VM, and need to transfer the disk shareable state to the VDSM. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: Ie43bd59fee6149b6e114eed89c0fa44bd9dc9aa7 --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4226 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie43bd59fee6149b6e114eed89c0fa44bd9dc9aa7 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use allow snapshot when Adding a disk to VM.
by mlipchuk＠redhat.com 15 May '12

15 May '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use allow snapshot when Adding a disk to VM. ...................................................................... core: Use allow snapshot when Adding a disk to VM. Next changes in the patch: 1. Set allow_snapshot to a new disk. 2. If the disk which is added is shareable then set the allow_snapshot attribute accordingly, since shared disk should not used in a snapshot. 3. Move the initialization of disk alias to the execute 4. Cosmetic changes. 5. Use default null for Guid vmSnapshotId instead of empty Guid. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I135669c5f7bfb85fda561a47258834cd35d7688b --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddDiskParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesActionsParametersBase.java 4 files changed, 29 insertions(+), 5 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I135669c5f7bfb85fda561a47258834cd35d7688b Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Filter images by disk attributes.
by mlipchuk＠redhat.com 15 May '12

15 May '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Filter images by disk attributes. ...................................................................... core: Filter images by disk attributes. Use the allow snapshot field and the shareable attribute to filter disks. Those disks should be filtered on different operation such as Crating template from VM, Create snapshot, Run stateless VM, Clone VM from snapshot, and export VM. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: Ib34a90fdf7c53d80ce52aec98b7c810ece2c6ad3 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 16 files changed, 59 insertions(+), 31 deletions(-) Approvals: Michael Kublin: Looks good to me, approved Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib34a90fdf7c53d80ce52aec98b7c810ece2c6ad3 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use allow snapshot attribute on disk update.
by mlipchuk＠redhat.com 15 May '12

15 May '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use allow snapshot attribute on disk update. ...................................................................... core: Use allow snapshot attribute on disk update. Update allow snapshot field in the disk according to the shareable disk flag. Validate that disk can not be configured as shared if it contains snapshots in it or boot indication. Also update the vm snapshot id to null if the disk can not be use in a snapshot. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: Ib4488ad0d983854483aee5520ae2a233c96bfdb4 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java 1 file changed, 61 insertions(+), 4 deletions(-) Approvals: Michael Kublin: Looks good to me, approved Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4488ad0d983854483aee5520ae2a233c96bfdb4 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Shareable disk support
by derez＠redhat.com 15 May '12

15 May '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin,userportal: Shareable disk support ...................................................................... webadmin,userportal: Shareable disk support Disks main tab: added 'Shareable' Column VMs -> Disks sub-tab: added shareable status icon Add Disk dialog: added 'Is shareable' check-box Attach Disk dialog: added 'Shareable' Column Change-Id: I93987a0b3e081b60dc08f97abc9e12243ecae31c Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskImagePlugStatusColumn.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskStatusCell.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskStatusColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/disk_shareable.png M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmDiskPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmDiskPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java 17 files changed, 133 insertions(+), 28 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93987a0b3e081b60dc08f97abc9e12243ecae31c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: remove forgotten trailing whitespace
by gchaplik＠redhat.com 15 May '12

15 May '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: remove forgotten trailing whitespace ...................................................................... webadmin: remove forgotten trailing whitespace Change-Id: I31b3a4759a4106a536294d2f78753e3b338d6cbc Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmPopupView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31b3a4759a4106a536294d2f78753e3b338d6cbc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Remove Old Documentation Files
by oliel＠redhat.com 15 May '12

15 May '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Remove Old Documentation Files ...................................................................... restapi: Remove Old Documentation Files Change-Id: Ie5755f5650f4fc56e1aec37da2cafd47d26fb785 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- D backend/manager/modules/restapi/docs/Makefile D backend/manager/modules/restapi/docs/README D backend/manager/modules/restapi/docs/en-US/Authentication.xml D backend/manager/modules/restapi/docs/en-US/Book_Info.xml D backend/manager/modules/restapi/docs/en-US/Capabilities.xml D backend/manager/modules/restapi/docs/en-US/Clusters.xml D backend/manager/modules/restapi/docs/en-US/Common_Idioms.xml D backend/manager/modules/restapi/docs/en-US/Compatibility_Level_Versions.xml D backend/manager/modules/restapi/docs/en-US/Data_Centers.xml D backend/manager/modules/restapi/docs/en-US/Domains.xml D backend/manager/modules/restapi/docs/en-US/Entry_Point.xml D backend/manager/modules/restapi/docs/en-US/Event_Codes.xml D backend/manager/modules/restapi/docs/en-US/Events.xml D backend/manager/modules/restapi/docs/en-US/Example.xml D backend/manager/modules/restapi/docs/en-US/Feedback.xml D backend/manager/modules/restapi/docs/en-US/Groups.xml D backend/manager/modules/restapi/docs/en-US/HTTP_Libraries.xml D backend/manager/modules/restapi/docs/en-US/Hosts.xml D backend/manager/modules/restapi/docs/en-US/Introduction.xml D backend/manager/modules/restapi/docs/en-US/Localization.xml D backend/manager/modules/restapi/docs/en-US/Monitoring.xml D backend/manager/modules/restapi/docs/en-US/Networks.xml D backend/manager/modules/restapi/docs/en-US/Preface.xml D backend/manager/modules/restapi/docs/en-US/REST_API_Guide.ent D backend/manager/modules/restapi/docs/en-US/REST_API_Guide.xml D backend/manager/modules/restapi/docs/en-US/Roles.xml D backend/manager/modules/restapi/docs/en-US/Search.xml D backend/manager/modules/restapi/docs/en-US/Statistics.xml D backend/manager/modules/restapi/docs/en-US/Storage_Domains.xml D backend/manager/modules/restapi/docs/en-US/Tags.xml D backend/manager/modules/restapi/docs/en-US/Templates.xml D backend/manager/modules/restapi/docs/en-US/Timezones.xml D backend/manager/modules/restapi/docs/en-US/Users.xml D backend/manager/modules/restapi/docs/en-US/Users_and_Roles.xml D backend/manager/modules/restapi/docs/en-US/VM_Pools.xml D backend/manager/modules/restapi/docs/en-US/VMs.xml D backend/manager/modules/restapi/docs/en-US/images/CollectionsEntryPoint.png D backend/manager/modules/restapi/docs/en-US/images/api_diag.png D backend/manager/modules/restapi/docs/en-US/images/api_diag.svg D backend/manager/modules/restapi/docs/en-US/images/locked.png D backend/manager/modules/restapi/docs/en-US/images/readonly.png D backend/manager/modules/restapi/docs/en-US/images/required.png D backend/manager/modules/restapi/docs/installation/Makefile D backend/manager/modules/restapi/docs/installation/en-US/Book_Info.xml D backend/manager/modules/restapi/docs/installation/en-US/Feedback.xml D backend/manager/modules/restapi/docs/installation/en-US/Overview.xml D backend/manager/modules/restapi/docs/installation/en-US/Preface.xml D backend/manager/modules/restapi/docs/installation/en-US/REST_API_Installation_Guide.ent D backend/manager/modules/restapi/docs/installation/en-US/REST_API_Installation_Guide.xml D backend/manager/modules/restapi/docs/installation/en-US/images/allow_all.png D backend/manager/modules/restapi/docs/installation/en-US/images/api_entry_point.png D backend/manager/modules/restapi/docs/installation/en-US/images/copy_war_file.png D backend/manager/modules/restapi/docs/installation/en-US/images/create_certificate.png D backend/manager/modules/restapi/docs/installation/en-US/images/create_task.png D backend/manager/modules/restapi/docs/installation/en-US/images/edit_action.png D backend/manager/modules/restapi/docs/installation/en-US/images/environment_variables.png D backend/manager/modules/restapi/docs/installation/en-US/images/rest_client.png D backend/manager/modules/restapi/docs/installation/en-US/images/run_jboss.png D backend/manager/modules/restapi/docs/installation/en-US/images/run_rest_client.png D backend/manager/modules/restapi/docs/installation/en-US/images/set_environment_variable.png D backend/manager/modules/restapi/docs/installation/en-US/images/start_jboss_properties.png D backend/manager/modules/restapi/docs/installation/en-US/images/stop_task.png D backend/manager/modules/restapi/docs/installation/en-US/images/triggers.png D backend/manager/modules/restapi/docs/installation/en-US/images/unzip_directory.png D backend/manager/modules/restapi/docs/installation/en-US/images/windows_security.png D backend/manager/modules/restapi/docs/installation/en-US/images/workflow.png D backend/manager/modules/restapi/docs/installation/publican.cfg D backend/manager/modules/restapi/docs/publican.cfg 68 files changed, 0 insertions(+), 12,843 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5755f5650f4fc56e1aec37da2cafd47d26fb785 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock ImportVmCommandTest
by yzaslavs＠redhat.com 15 May '12

15 May '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: UnPowerMock ImportVmCommandTest ...................................................................... core: UnPowerMock ImportVmCommandTest Removed dependency on PowerMock from ImportVmCommandTest and replaced it with the new MockConfigRule. Change-Id: I073255c630cff8f230017d90857a80d00c5ccba5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java 1 file changed, 11 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I073255c630cff8f230017d90857a80d00c5ccba5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: UnPowerMock DirectorySearcherTest
by yzaslavs＠redhat.com 15 May '12

15 May '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: UnPowerMock DirectorySearcherTest ...................................................................... core: UnPowerMock DirectorySearcherTest Removed PowerMock dependency from DirectorySearcherTest and replaced it with the new MockConfigRule. Change-Id: I337876ececcc4dd3ae19cfd5107f628d8c31a6a2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java 1 file changed, 9 insertions(+), 16 deletions(-) Approvals: Allon Mureinik: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I337876ececcc4dd3ae19cfd5107f628d8c31a6a2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup DirectorySearcherTest
by yzaslavs＠redhat.com 15 May '12

15 May '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Cleanup DirectorySearcherTest ...................................................................... core: Cleanup DirectorySearcherTest General java cleanup, fixed warnings detected by Eclipse IDE. Change-Id: I27fc38964127cf56fe7cfe95cd72c5c7a7bb6e67 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java 1 file changed, 18 insertions(+), 21 deletions(-) Approvals: Allon Mureinik: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4401 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27fc38964127cf56fe7cfe95cd72c5c7a7bb6e67 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0