July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: call GetConfigurationValue with version
by ecohen＠redhat.com 03 Jul '12

03 Jul '12

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: call GetConfigurationValue with version ...................................................................... webadmin: call GetConfigurationValue with version https://bugzilla.redhat.com/760100 Calling GetConfigurationValue with a null version results in warnings in the log file. Change callers to explicitly pass a version (typically the default, "general") to avoid the warning. Change-Id: I191edbde4529b97d6ebca2c03cf71f3a8058419e Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetConfigurationValueParameters.java M frontend/wars/rmw-war/src/main/java/org/ovirt/engine/core/redirect/RedirectServlet.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/WebadminDynamicHostingServlet.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/AboutPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AboutPopupPresenterWidget.java 8 files changed, 96 insertions(+), 81 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5604 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I191edbde4529b97d6ebca2c03cf71f3a8058419e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: value of parameter vdsStaticData is not used.
by mkublin＠redhat.com 03 Jul '12

03 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: value of parameter vdsStaticData is not used. ...................................................................... engine: value of parameter vdsStaticData is not used. The parameter passed to method validateHostUniqueNameAndAddress() was not being used in the method. This patch also removed a redundant 'else'. Change-Id: I8f90ba9b88f533a6bcdf189b6db50a35d9242e29 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Michael Kublin: Looks good to me, approved Sharad Mishra: Verified -- To view, visit http://gerrit.ovirt.org/5904 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f90ba9b88f533a6bcdf189b6db50a35d9242e29 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Replace StringHelper with StringUtils in CreateVmVDS...
by mkublin＠redhat.com 03 Jul '12

03 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Replace StringHelper with StringUtils in CreateVmVDSCommand ...................................................................... engine: Replace StringHelper with StringUtils in CreateVmVDSCommand StringHelper is deprecated. Change-Id: I145f384da360a8c473751e6cbce4aaad6002bd79 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I145f384da360a8c473751e6cbce4aaad6002bd79 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Replace StringHelper with StringUtils in VmPropertie...
by mkublin＠redhat.com 03 Jul '12

03 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Replace StringHelper with StringUtils in VmPropertiesUtils ...................................................................... engine: Replace StringHelper with StringUtils in VmPropertiesUtils StringHelper is deprecated. Change-Id: I082fe681c07073969874a4b3f4064ef6c4fb6d07 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/vmproperties/VmPropertiesUtils.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I082fe681c07073969874a4b3f4064ef6c4fb6d07 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Add disk dialog - setting fields tabbing order (#8...
by asaf＠redhat.com 03 Jul '12

03 Jul '12

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: Add disk dialog - setting fields tabbing order (#832811) ...................................................................... webadmin: Add disk dialog - setting fields tabbing order (#832811) https://bugzilla.redhat.com/832811 Set fields tabbing order according to the order of the fields visibility in the 'Add new Disk' dialog. Change-Id: I4622a40c049a9d9f4a034055aef574239072c70e Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java 1 file changed, 11 insertions(+), 11 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4622a40c049a9d9f4a034055aef574239072c70e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: adding NonVmNetworkSupported config entry
by oourfali＠redhat.com 03 Jul '12

03 Jul '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: adding NonVmNetworkSupported config entry ...................................................................... core: adding NonVmNetworkSupported config entry The addition of non-VM networks is supported only in DC level 3.1 and above. * Adding a validation upon creating/editing a new logical network. * Fixing the validation when attaching the network to clusters. * Improve the validation message Change-Id: I56dad88b3dc3f07fcd4ba24804eb9cc1b8e80422 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/NetworkCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateNetworkCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 10 files changed, 48 insertions(+), 17 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56dad88b3dc3f07fcd4ba24804eb9cc1b8e80422 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: printing the detailed message upon authentication erro...
by oourfali＠redhat.com 03 Jul '12

03 Jul '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: printing the detailed message upon authentication error ...................................................................... core: printing the detailed message upon authentication error This patch adds log error print, that prints the AuthenticationResult detailed message to the log. Also, changing the enum for the CLIENT_NOT_FOUND_IN_KERBEROS_DATABASE error, to return the same erorr to the user. Change-Id: I996713d9bc7f97d0e9cb4305513084d88d32fa42 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapAuthenticateUserCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/AuthenticationResult.java 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I996713d9bc7f97d0e9cb4305513084d88d32fa42 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: rest api NPE fix
by lhornyak＠redhat.com 03 Jul '12

03 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: rest api NPE fix ...................................................................... core: rest api NPE fix Fixes an NPE in teh unit-tests. Change-Id: I966872e98940fc1e2ae78dd09e0d0fea97f9fab9 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I966872e98940fc1e2ae78dd09e0d0fea97f9fab9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Disks main-tab - container indication
by derez＠redhat.com 03 Jul '12

03 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Disks main-tab - container indication ...................................................................... webadmin: Disks main-tab - container indication https://bugzilla.redhat.com/819278 Added VM/Template column in disks main-tab (to differentiate between VM/Template disks). Change-Id: I42c2b11a47b05dc9a99159a8414f5ed77357679b Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42c2b11a47b05dc9a99159a8414f5ed77357679b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: filter VDS's by networks(#826593)
by lhornyak＠redhat.com 03 Jul '12

03 Jul '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: filter VDS's by networks(#826593) ...................................................................... core: filter VDS's by networks(#826593) https://bugzilla.redhat.com/826593 Filters out VDS's from the list of VDS' able to run a VM if not all networks required by the VM are available on the VDS. Change-Id: Ic8483876401260b75fff51d45dd6c66c29859935 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java 1 file changed, 35 insertions(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5838 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8483876401260b75fff51d45dd6c66c29859935 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0