July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: Engine: remove inaccurate audit log message when creating VM...
by shavivi＠redhat.com 26 Jul '12

26 Jul '12

Shahar Havivi has submitted this change and it was merged. Change subject: Engine: remove inaccurate audit log message when creating VMs in Pool ...................................................................... Engine: remove inaccurate audit log message when creating VMs in Pool When creating VMs in pool engine can never know for sure if all VMs will be created (at the execute stage) because it can fail for lack of disk space, or other error. Change-Id: Iaadcea476aedaca5de7c7bcce88437d2a8048999 Signed-off-by: Shahar Havivi<shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 2 files changed, 3 insertions(+), 10 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaadcea476aedaca5de7c7bcce88437d2a8048999 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixing lock vm
by mkublin＠redhat.com 26 Jul '12

26 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Fixing lock vm ...................................................................... core: Fixing lock vm Fixing lock vm Change-Id: I7803349223ab6b1860cdeee165a2e6a226f7cb22 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Michael Kublin: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7803349223ab6b1860cdeee165a2e6a226f7cb22 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixing vm left at status ImageLocked
by mkublin＠redhat.com 26 Jul '12

26 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Fixing vm left at status ImageLocked ...................................................................... core: Fixing vm left at status ImageLocked Fixing vm left at status ImageLocked Change-Id: I50eddbabb0f50c13dfab04b9c4151a21bdfb35a7 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50eddbabb0f50c13dfab04b9c4151a21bdfb35a7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fixing import storage domain to save additional NFS op...
by oourfali＠redhat.com 26 Jul '12

26 Jul '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: fixing import storage domain to save additional NFS options (#835961) ...................................................................... core: fixing import storage domain to save additional NFS options (#835961) https://bugzilla.redhat.com/835961 This patch uses the AddStorageServerConnectionCommand in the import NFS storage domain (same as when adding a new domain), instead of using ConnectStorageServerVDSCommand, as it saves the server connection in the database. Also, it puts the additional NFS options in the server connection object as well, so that they will be persistent. Change-Id: I87ac4a2b8a7f2083f2d5310cc9899514936d6111 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6618 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87ac4a2b8a7f2083f2d5310cc9899514936d6111 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: backend: fix verifyAddVm in VmHandler
by oourfali＠redhat.com 26 Jul '12

26 Jul '12

Oved Ourfali has submitted this change and it was merged. Change subject: backend: fix verifyAddVm in VmHandler ...................................................................... backend: fix verifyAddVm in VmHandler This patch fixes a behaviour in which the verifyAddVm method returned "true", although the data center wasn't valid. Change-Id: If0346714a4cd8af2c541e7680c93bc3249fda63c Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java 2 files changed, 23 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0346714a4cd8af2c541e7680c93bc3249fda63c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: added remote db upgrade.
by ydary＠redhat.com 26 Jul '12

26 Jul '12

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: added remote db upgrade. ...................................................................... packaging: added remote db upgrade. Change-Id: I2906d93831f9af53be6166d7ccfed80cc34172b5 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-dwh-setup.py 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6642 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2906d93831f9af53be6166d7ccfed80cc34172b5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Clean up of HandleVdsVersionCommand
by mkublin＠redhat.com 26 Jul '12

26 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Clean up of HandleVdsVersionCommand ...................................................................... core: Clean up of HandleVdsVersionCommand These patch is clean up: 1. Annotattion for warnings 2. Disable global transaction, no update operations are done 3. Removed logger 4. Removed unneeded query for vdsGroup 5. Simplify code Change-Id: I280b72f963776068a60a77ff45d9ec21bf27fbca Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java 2 files changed, 14 insertions(+), 22 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I280b72f963776068a60a77ff45d9ec21bf27fbca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removing unneeded select during unlockVM
by mkublin＠redhat.com 26 Jul '12

26 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Removing unneeded select during unlockVM ...................................................................... core: Removing unneeded select during unlockVM The following patch will remove unneeded selects for vm during unlockVM operations Change-Id: I15df3a5222831d8de15cabceb410c4d84bc3d7ef Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 7 files changed, 13 insertions(+), 18 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15df3a5222831d8de15cabceb410c4d84bc3d7ef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: revert 5fc51d2f89cb9e5ec90868f30bd6987ba6a58185
by rgolan＠redhat.com 26 Jul '12

26 Jul '12

Roy Golan has submitted this change and it was merged. Change subject: core: revert 5fc51d2f89cb9e5ec90868f30bd6987ba6a58185 ...................................................................... core: revert 5fc51d2f89cb9e5ec90868f30bd6987ba6a58185 reverts commit 5fc51d2f89cb9e5ec90868f30bd6987ba6a58185 Change-Id: Ie17e2cbe3c221a099747e3829986602375d2586b Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/dbscripts/vds_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAOWrapperImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDAOTest.java 6 files changed, 134 insertions(+), 88 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie17e2cbe3c221a099747e3829986602375d2586b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: UI: Wrong cluster level version when editing the cluster
by shavivi＠redhat.com 26 Jul '12

26 Jul '12

Shahar Havivi has submitted this change and it was merged. Change subject: UI: Wrong cluster level version when editing the cluster ...................................................................... UI: Wrong cluster level version when editing the cluster when editing cluster level the version is always the first selected-item. Change-Id: Iab4f88b69514da3ccba5a99bdfa6b49a039732e0 Signed-off-by: Shahar Havivi<shavivi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab4f88b69514da3ccba5a99bdfa6b49a039732e0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0