March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine-cli[cli_3.2]: cli: rephrase status command help
by mpastern＠redhat.com 28 Mar '13

28 Mar '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: rephrase status command help ...................................................................... cli: rephrase status command help Change-Id: Ic264504caff5ed0590474ad188b2688520a1a5bd Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/command/status.py 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic264504caff5ed0590474ad188b2688520a1a5bd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: rephrase status command help
by mpastern＠redhat.com 28 Mar '13

28 Mar '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: rephrase status command help ...................................................................... cli: rephrase status command help Change-Id: Ic264504caff5ed0590474ad188b2688520a1a5bd Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/command/status.py 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic264504caff5ed0590474ad188b2688520a1a5bd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: #853739 - Actions Should Return Entities In Body
by mpastern＠redhat.com 28 Mar '13

28 Mar '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: #853739 - Actions Should Return Entities In Body ...................................................................... restapi: #853739 - Actions Should Return Entities In Body On actions api returns parameters in response body instead of actual action result. https://bugzilla.redhat.com/853739 Change-Id: Ic636b7205fa7b6fbb5d98efdbcd7976e9beb2187 Signed-off-by: Ori Liel <oliel(a)redhat.com> Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendActionableResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResourceTest.java 6 files changed, 146 insertions(+), 46 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9466 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic636b7205fa7b6fbb5d98efdbcd7976e9beb2187 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : Missing RSDL descriptor for host.install(image)(#9...
by mpastern＠redhat.com 28 Mar '13

28 Mar '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : Missing RSDL descriptor for host.install(image)(#919856) ...................................................................... restapi : Missing RSDL descriptor for host.install(image)(#919856) When installing host using RESTapi, there is no option in the API to select which iso should be used, unlike the UI. Also there is on indication which ISO is selected. Change-Id: I103e75154ce025e82ff7c51f358f527436ab30dc Bug-Url: https://bugzilla.redhat.com/919856 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13013 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I103e75154ce025e82ff7c51f358f527436ab30dc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi: allow client to define the HTTP session TTL #921013
by mpastern＠redhat.com 28 Mar '13

28 Mar '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: allow client to define the HTTP session TTL #921013 ...................................................................... restapi: allow client to define the HTTP session TTL #921013 Session TTL can be explicitly set by user now via "Session-TTL:xxx" HTTP header, Session-TTL is the time between client requests before the servlet container will invalidate this session. An interval value of zero or less indicates that the session should never timeout. (default TTL is 180 min) https://bugzilla.redhat.com/show_bug.cgi?id=921013 Change-Id: I753a379c60b2d7f88867cd0123ee69321a331f0f Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/SessionUtils.java M backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/security/auth/ChallengerTest.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/EntryPointBuilder.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml 8 files changed, 220 insertions(+), 13 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I753a379c60b2d7f88867cd0123ee69321a331f0f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-cli[cli_3.2]: cli: Ping command success message need to be rephrased(#9187...
by mpastern＠redhat.com 28 Mar '13

28 Mar '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: Ping command success message need to be rephrased(#918749) ...................................................................... cli: Ping command success message need to be rephrased(#918749) ovirt-shell ping success message needs to be rephrased. Change-Id: I9db7fa5c022713448674f4204470a7c502a1cfe5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=918749 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/cli/messages.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/13379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9db7fa5c022713448674f4204470a7c502a1cfe5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: cli_3.2 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi : NullPointerException when Authorization header is ...
by mpastern＠redhat.com 28 Mar '13

28 Mar '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : NullPointerException when Authorization header is passed(#916085) ...................................................................... restapi : NullPointerException when Authorization header is passed(#916085) When invalid authorization header is passed a null pointer exception is thrown on the server resulting in internal server error. Change-Id: I10b580dcc3fddbec8ccd80130e977aeb4ef37fb2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=916085 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10b580dcc3fddbec8ccd80130e977aeb4ef37fb2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : NullPointerException when Authorization header is ...
by mpastern＠redhat.com 28 Mar '13

28 Mar '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : NullPointerException when Authorization header is passed(#916085) ...................................................................... restapi : NullPointerException when Authorization header is passed(#916085) When invalid authorization header is passed a null pointer exception is thrown on the server resulting in internal server error. Change-Id: I10b580dcc3fddbec8ccd80130e977aeb4ef37fb2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=916085 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10b580dcc3fddbec8ccd80130e977aeb4ef37fb2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi : Missing RSDL descriptor for host.install(image)(#9...
by mpastern＠redhat.com 28 Mar '13

28 Mar '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : Missing RSDL descriptor for host.install(image)(#919856) ...................................................................... restapi : Missing RSDL descriptor for host.install(image)(#919856) When installing host using RESTapi, there is no option in the API to select which iso should be used, unlike the UI. Also there is on indication which ISO is selected. Change-Id: I103e75154ce025e82ff7c51f358f527436ab30dc Bug-Url: https://bugzilla.redhat.com/919856 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/13372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I103e75154ce025e82ff7c51f358f527436ab30dc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: clean up businessentity hashCode() methods [part 2]
by lhornyak＠redhat.com 28 Mar '13

28 Mar '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: clean up businessentity hashCode() methods [part 2] ...................................................................... core: clean up businessentity hashCode() methods [part 2] Organize hashCode() methods into a consistent format and consistent ordering with equals(). This will make field-by-field comparison and maintenance easier. Change-Id: If925715cc91c1b4a53a7f6d212ac51043412db53 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePoolIsoMap.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsVmMap.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsVmPoolMap.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPool.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_pool.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/tags.java 21 files changed, 108 insertions(+), 214 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved Greg Padgett: Verified -- To view, visit http://gerrit.ovirt.org/12538 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If925715cc91c1b4a53a7f6d212ac51043412db53 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0