October 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Clean up of AddVdsVDSCommand
by mkublin＠redhat.com 10 Oct '12

10 Oct '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Clean up of AddVdsVDSCommand ...................................................................... engine: Clean up of AddVdsVDSCommand I have not any idea why that code was there and what was reason for it, but these code is wrong, I removed it Change-Id: I070093a2afb352e635b07673b720f37a56d543fd Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/AddVdsVDSCommand.java 1 file changed, 1 insertion(+), 19 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I070093a2afb352e635b07673b720f37a56d543fd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Clean up and improve ResourceManager
by mkublin＠redhat.com 10 Oct '12

10 Oct '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Clean up and improve ResourceManager ...................................................................... core: Clean up and improve ResourceManager The following patch is a clean up of ResourceManager: 1. Removed unneeded sleep during init, should reduce start up time of JBOSS 2. Removed unneeded code Change-Id: Ie17e5fe3ec4fc89fcb63bfe1d2717c222ef39b53 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8466 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie17e5fe3ec4fc89fcb63bfe1d2717c222ef39b53 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Failed to attach vlan over bond
by mkolesni＠redhat.com 10 Oct '12

10 Oct '12

Mike Kolesnik has submitted this change and it was merged. Change subject: restapi: Failed to attach vlan over bond ...................................................................... restapi: Failed to attach vlan over bond When attempt to attach a vlan over bond, a NPE is thrown on SetupNetwork command since the interfaces aren't provided with their information. Instead, the interface list contains a shallow interface with its id and bond-name only. The patch verifies that a slave is exists and assure it is sent with its data as obtained from engine. Change-Id: I3f05a11b91e2fd5a0367c0be3904b97d5dcb190e Bug-Url: https://bugzilla.redhat.com/863105 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f05a11b91e2fd5a0367c0be3904b97d5dcb190e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: removed disks:format from search(bug 859041)
by derez＠redhat.com 10 Oct '12

10 Oct '12

Daniel Erez has submitted this change and it was merged. Change subject: core: removed disks:format from search(bug 859041) ...................................................................... core: removed disks:format from search(bug 859041) There's no indication to COW or RAW in the UI. Hence removed from search. Change-Id: Icb5e02d0d48f4b348a6f14946271a9cbcda16f21 Bug-Url: https://bugzilla.redhat.com/859041 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DiskConditionFieldAutoCompleter.java 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8430 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb5e02d0d48f4b348a6f14946271a9cbcda16f21 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove Serializable class
by mkublin＠redhat.com 10 Oct '12

10 Oct '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Remove Serializable class ...................................................................... core: Remove Serializable class For some reason we had additional Serializable, I removed it. Change-Id: I603cb61368a9aa8525c9b96a4bf1237e032d00f4 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmOnceParams.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/image_storage_domain_map_id.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vm_template_image_map.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vm_template_image_map_id.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/RegisterVdsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/users/VdcUser.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Guid.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/KeyValuePairCompat.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/NGuid.java D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Serializable.java 11 files changed, 17 insertions(+), 20 deletions(-) Approvals: Michael Kublin: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I603cb61368a9aa8525c9b96a4bf1237e032d00f4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Performance improvements - replacing search by query
by mkublin＠redhat.com 10 Oct '12

10 Oct '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Performance improvements - replacing search by query ...................................................................... core: Performance improvements - replacing search by query The following patch will replace a search of host in status Up by query which will retrieve all hosts in status Up from Db. A query should be more efficient than search Change-Id: I1c1adda55bd27beef2907bf0ed8a0f8bc274e495 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/dbscripts/vds_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAOWrapperImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsDAOTest.java 8 files changed, 53 insertions(+), 237 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c1adda55bd27beef2907bf0ed8a0f8bc274e495 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Changed illegal error msg to locked(#840304)
by mkublin＠redhat.com 10 Oct '12

10 Oct '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Changed illegal error msg to locked(#840304) ...................................................................... core: Changed illegal error msg to locked(#840304) Replaced VM in illegal state error message to locked VM in ImagesHandler.PerformImagesChecks() when the VM is indeed locked. The specific flow of actions to introduce the wrong message was Trying to export a VM while committing a preview. This yielded a statement that the VM's state is illegal while it should only say that it's locked. This should correct other flow of events as well. ACTION_TYPE_FAILED_VM_IS_LOCKED message is added and used in the appropriate place - ImagesHandler.PerformImagesChecks() - if the VM is locked and disks are not. Change-Id: I2edb7b8c946589f3bbad251d533704fe856bc175 Bug-Url: https://bugzilla.redhat.com/840304 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 13 insertions(+), 4 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8078 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2edb7b8c946589f3bbad251d533704fe856bc175 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: fixed dr20 filtering (#857683)
by ydary＠redhat.com 10 Oct '12

10 Oct '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed dr20 filtering (#857683) ...................................................................... reports: fixed dr20 filtering (#857683) The clause to filter only to highly available vm was commented out by mistake. bug-url: https://bugzilla.redhat.com/857683 Change-Id: I668399794e84a33ccb7c8734c332b5f2093564d8 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/reports_resources/embedded_reports/webadmin_dashboards/cluster_dashboard/top_five_ha_virtual_servers_downtime_dr20_files/top_five_ha_virtual_servers_downtime_dr20_jrxml.data M reports/repository_files/resources/reports_resources/webadmin_dashboards/ce/cluster_dashboard_files/top_five_ha_virtual_servers_downtime_dr20_jrxml.data 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8459 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I668399794e84a33ccb7c8734c332b5f2093564d8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: fixed date display on br16 (#863763)
by ydary＠redhat.com 10 Oct '12

10 Oct '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed date display on br16 (#863763) ...................................................................... reports: fixed date display on br16 (#863763) Had missing field in date display that caused error. Changed query to contain the field required. bug-url: https://bugzilla.redhat.com/857683 Change-Id: I74a083e6a6c1d78d3f0d09da8b0e2ab7b8cf23e7 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/Reports/Trend/Virtual_machines/multiple_vms_resource_usage_over_time_br16_files/report3.jrxml.data 1 file changed, 31 insertions(+), 32 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74a083e6a6c1d78d3f0d09da8b0e2ab7b8cf23e7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Allow empty quota in audit mode (#855633)
by gchaplik＠redhat.com 10 Oct '12

10 Oct '12

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: Allow empty quota in audit mode (#855633) ...................................................................... engine: Allow empty quota in audit mode (#855633) https://bugzilla.redhat.com/855633 this is a known issue since preliminary design, when in permissive (audit) mode, we fail any quota related command. changed it now to allow 'no-quota' in permissive (audit) mode, and a proper message will be delivered to audit log in this case, to inform the user. Change-Id: Ib52cfc882ea07223b69041cc4fc2ccc7aae77752 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tree/AbstractSubTabTree.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/storage/TemplatesTree.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/storage/VMsTree.java 9 files changed, 59 insertions(+), 15 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib52cfc882ea07223b69041cc4fc2ccc7aae77752 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0