October 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Moved generic methods from GlusterCoreUtil
by mkublin＠redhat.com 11 Oct '12

11 Oct '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Moved generic methods from GlusterCoreUtil ...................................................................... engine: Moved generic methods from GlusterCoreUtil Generic methods like objectsEqual, listsEquel have been moved to appropriate new/existing utility classes like ListUtils and ObjectUtils. Change-Id: I723c44dd08d29454de4bb77c43eadf6de3e57bad Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterBrickEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterServerInfo.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ListUtils.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ObjectUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/gluster/GlusterCoreUtil.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ListUtilsTest.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ObjectUtilsTest.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 10 files changed, 95 insertions(+), 63 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8434 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I723c44dd08d29454de4bb77c43eadf6de3e57bad Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Don't raise 404 if slave not found
by mkolesni＠redhat.com 11 Oct '12

11 Oct '12

Mike Kolesnik has submitted this change and it was merged. Change subject: restapi: Don't raise 404 if slave not found ...................................................................... restapi: Don't raise 404 if slave not found If slave wasn't found, then just map without template, otherwise the 404 is not clear when thrown in the context of setup networks. Change-Id: I20c86e56b102e4c6318608f8d4ba50757fcce12f Bug-Url: https://bugzilla.redhat.com/?????? Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Mike Kolesnik: Verified -- To view, visit http://gerrit.ovirt.org/8490 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20c86e56b102e4c6318608f8d4ba50757fcce12f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: If slave id is not set, lookup by name
by mkolesni＠redhat.com 11 Oct '12

11 Oct '12

Mike Kolesnik has submitted this change and it was merged. Change subject: restapi: If slave id is not set, lookup by name ...................................................................... restapi: If slave id is not set, lookup by name If slave ID for bonding is not set, then need to look for the existing interface by name instead. Change-Id: Iea876e039c98665d01314bc73661044e33db6291 Bug-Url: https://bugzilla.redhat.com/863105 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Looks good to me, approved Mike Kolesnik: Verified -- To view, visit http://gerrit.ovirt.org/8489 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea876e039c98665d01314bc73661044e33db6291 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: PM configuration during host installation sometime f...
by yzaslavs＠redhat.com 11 Oct '12

11 Oct '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: PM configuration during host installation sometime fails due to a race ...................................................................... engine: PM configuration during host installation sometime fails due to a race The following bug was caused because of we are not setting serverUniqueId when it retrieved and we are saving a new vdsm object to DB without serverUniqueId. Change-Id: I03fc1f4a6ad07430b5e583103d2ae1d5878940f5 Bug-Url: https://bugzilla.redhat.com/833382 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Michael Kublin: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03fc1f4a6ad07430b5e583103d2ae1d5878940f5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine:Cannot remove iscsi master storage right after removi...
by yzaslavs＠redhat.com 11 Oct '12

11 Oct '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine:Cannot remove iscsi master storage right after removing the storage pool ...................................................................... engine:Cannot remove iscsi master storage right after removing the storage pool The problem is sipmle domain was moved to UnAttached status before it was disconnected from pool, that's why remove failed. Solution change status of domain after performing an operation Change-Id: I5e6b57cd772e6fb7b35b22972131331349a04c09 Bug-Url: https://bugzilla.redhat.com/836168 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java 1 file changed, 10 insertions(+), 25 deletions(-) Approvals: Michael Kublin: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e6b57cd772e6fb7b35b22972131331349a04c09 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: minor cleanup in VdsSelector
by lhornyak＠redhat.com 10 Oct '12

10 Oct '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: minor cleanup in VdsSelector ...................................................................... core: minor cleanup in VdsSelector - Arrays.asList does not need an array instantiated. Change-Id: I04b29f4b484ad4dcaaa8946020fb952e3eef1a25 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04b29f4b484ad4dcaaa8946020fb952e3eef1a25 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: removed unused fqn from VdsSelector
by lhornyak＠redhat.com 10 Oct '12

10 Oct '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: removed unused fqn from VdsSelector ...................................................................... core: removed unused fqn from VdsSelector - removed unused java.util FQN's from VdsSelector Change-Id: Ic768c5c1e0e6a8e9d1c268eb6f4c2a7f44bc25dd Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8404 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic768c5c1e0e6a8e9d1c268eb6f4c2a7f44bc25dd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix stuck progress in add Posix FS storage (#85524...
by tnisan＠redhat.com 10 Oct '12

10 Oct '12

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix stuck progress in add Posix FS storage (#855244) ...................................................................... webadmin: Fix stuck progress in add Posix FS storage (#855244) When adding new Posix FS based storage the dialog got stuck on progress indicator, this was caused due to an obsolete callback which was left after a cleanup and contained the cleanup logic Change-Id: I0512ee572069330fcc748e3d078702836dc9b446 Bug-Url: https://bugzilla.redhat.com/855244 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 2 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8471 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0512ee572069330fcc748e3d078702836dc9b446 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Validate maximum number of hosts in DC.(#771699)
by derez＠redhat.com 10 Oct '12

10 Oct '12

Daniel Erez has submitted this change and it was merged. Change subject: core: Validate maximum number of hosts in DC.(#771699) ...................................................................... core: Validate maximum number of hosts in DC.(#771699) http://bugzilla.redhat.com/show_bug.cgi?id=771699 when a host is added, there should be a check whether the maximum number of hosts attached to DC has been exceeded. If max number of hosts is exceeded, user should be presented with an appropriate message. Change-Id: If375400f3e12e3e0452053dea12ac6e28bc0ff61 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/dbscripts/vds_spm_id_map_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsSpmIdCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsSpmIdMapDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsSpmIdMapDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsSpmIdMapDAOTest.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties 15 files changed, 104 insertions(+), 85 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If375400f3e12e3e0452053dea12ac6e28bc0ff61 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Improve UpdateVdsCommand
by mkublin＠redhat.com 10 Oct '12

10 Oct '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Improve UpdateVdsCommand ...................................................................... engine: Improve UpdateVdsCommand Improvements: 1. Command should be Nontransactive 2. Some code clean ups Change-Id: Icd0565b03266e5686d9b03e1c7d9f863da8952be Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd0565b03266e5686d9b03e1c7d9f863da8952be Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0