October 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: break down spaghetti-code in VdsSelector
by lhornyak＠redhat.com 09 Oct '12

09 Oct '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: break down spaghetti-code in VdsSelector ...................................................................... core: break down spaghetti-code in VdsSelector - This is a minor cleanup that breaks down the big if-else statement into validator objects, and just iterates over the validator objects. No functional change in VdsSelector. Change-Id: I6b4535e050790434b12180fc0bae55dd26fe43b5 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java 1 file changed, 117 insertions(+), 36 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8401 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b4535e050790434b12180fc0bae55dd26fe43b5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixing find bugs errors
by mkublin＠redhat.com 09 Oct '12

09 Oct '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Fixing find bugs errors ...................................................................... core: Fixing find bugs errors The following patch will fix a find bugs warning 1. Possible NullPointerException, by removing unneeded log 2. Not java method name Change-Id: I61c73c2be5a0f24dcd7554ff41a04c6cf7754140 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java 1 file changed, 2 insertions(+), 8 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8438 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61c73c2be5a0f24dcd7554ff41a04c6cf7754140 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VdsSelector cleanup
by lhornyak＠redhat.com 09 Oct '12

09 Oct '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: VdsSelector cleanup ...................................................................... core: VdsSelector cleanup - merged the nested 'if' into the parent 'if', since there was nothing else in the parent 'if' Change-Id: I6151f86a3fc176da3ddae8eac83a6a388f022005 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6151f86a3fc176da3ddae8eac83a6a388f022005 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove unused code from VdsSelector
by lhornyak＠redhat.com 09 Oct '12

09 Oct '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: remove unused code from VdsSelector ...................................................................... core: remove unused code from VdsSelector private method was not invoked at all, it can be deleted Change-Id: I99b710353c920d0f65aa3c2c77cce63988615973 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java 1 file changed, 1 insertion(+), 16 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8399 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99b710353c920d0f65aa3c2c77cce63988615973 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixing possible ConcurrentModificationException
by mkublin＠redhat.com 09 Oct '12

09 Oct '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Fixing possible ConcurrentModificationException ...................................................................... core: Fixing possible ConcurrentModificationException The following class is used all around the code, the map is shared and should be thread safe Change-Id: I3ea0bc0cfd3452ff71ddb4ed9f9b1939b0f76238 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/EnumUtils.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8436 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ea0bc0cfd3452ff71ddb4ed9f9b1939b0f76238 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: open up firewall rules for console and migration ...
by juan.hernandez＠redhat.com 09 Oct '12

09 Oct '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: open up firewall rules for console and migration in aio mode ...................................................................... packaging: open up firewall rules for console and migration in aio mode These ports are required for proper application use. Change-Id: Id2fb5346eaf8c800952df28657df701911586faa Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=857496 --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/plugins/all_in_one_100.py 3 files changed, 27 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2fb5346eaf8c800952df28657df701911586faa Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: clean up iptables rules
by juan.hernandez＠redhat.com 09 Oct '12

09 Oct '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: clean up iptables rules ...................................................................... packaging: clean up iptables rules RH-Firewall-1-INPUT was a symbol used in RHEL5, no need to keep it around. Fix syntax to match default fedora chain generation. Clear statistics. Change-Id: I8cfbabc31c964c9ff2374e32e1c65d3611f0883c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/iptables.default 2 files changed, 8 insertions(+), 10 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8377 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cfbabc31c964c9ff2374e32e1c65d3611f0883c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: cleanup _configIptables
by juan.hernandez＠redhat.com 09 Oct '12

09 Oct '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: cleanup _configIptables ...................................................................... packaging: cleanup _configIptables 1. use template file, do not search for comments. 2. remove code duplications. 3. handle files correctly. 4. misc cleanups. Change-Id: Ic08891752b537ea04c56e8aef2040cc5e89cbea3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/iptables.default 2 files changed, 21 insertions(+), 29 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8373 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic08891752b537ea04c56e8aef2040cc5e89cbea3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Clean up of EnumUtils
by mkublin＠redhat.com 09 Oct '12

09 Oct '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Clean up of EnumUtils ...................................................................... core: Clean up of EnumUtils Removed unused and unneeded methods. Change-Id: I939be2b873812d00fe33b2d3a498f6f0a90e8ec1 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/EnumUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/EnumUtilsTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 3 files changed, 2 insertions(+), 75 deletions(-) Approvals: Michael Kublin: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I939be2b873812d00fe33b2d3a498f6f0a90e8ec1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removing annotattion Singelton from GlusterUtils and C...
by mkublin＠redhat.com 09 Oct '12

09 Oct '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Removing annotattion Singelton from GlusterUtils and ClusterUtils ...................................................................... core: Removing annotattion Singelton from GlusterUtils and ClusterUtils The following annotattion is used in order to point that a following class is bean and is singelton, the following classes did not used as beans, that's why annottation was removed Change-Id: I18234409bf136701ca83058601ebdda4eaf9e1f3 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/ClusterUtils.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtils.java 2 files changed, 2 insertions(+), 14 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8425 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18234409bf136701ca83058601ebdda4eaf9e1f3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0