October 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: VmPayload serialVersionUID should be final
by lhornyak＠redhat.com 09 Oct '12

09 Oct '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: VmPayload serialVersionUID should be final ...................................................................... core: VmPayload serialVersionUID should be final - serialVersionUID should be final Change-Id: Ic84dcba15a773edf034e0af13dec2bafb83461d5 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8405 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic84dcba15a773edf034e0af13dec2bafb83461d5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix a utils method to detect compat level lower than 3...
by rgolan＠redhat.com 09 Oct '12

09 Oct '12

Roy Golan has submitted this change and it was merged. Change subject: core: fix a utils method to detect compat level lower than 3.1 ...................................................................... core: fix a utils method to detect compat level lower than 3.1 Change-Id: Ie9b8325bb1999af689a167709f2a8c3d3855e84e Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtilsTest.java 2 files changed, 24 insertions(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8349 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9b8325bb1999af689a167709f2a8c3d3855e84e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove Redundant Char (#858719)
by msalem＠redhat.com 09 Oct '12

09 Oct '12

Muli Salem has submitted this change and it was merged. Change subject: core: Remove Redundant Char (#858719) ...................................................................... core: Remove Redundant Char (#858719) See subject above. Change-Id: If8686ffb1964f204f69da7fd03fe922554979120 Bug-Url: https://bugzilla.redhat.com/858719 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8424 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8686ffb1964f204f69da7fd03fe922554979120 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Clean up of AddVdsCommand and UpdateVdsCommand
by mkublin＠redhat.com 09 Oct '12

09 Oct '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Clean up of AddVdsCommand and UpdateVdsCommand ...................................................................... core: Clean up of AddVdsCommand and UpdateVdsCommand The following patch is simple clean up of two commands, it is obvious that clean up is not full. The following clean up is: 1. Removing unused CommandParametersInitializer class 2. Clean up of ArraysList 3. Some small code clean ups Change-Id: Ibf3a2c67ea5dbae8458844beaa98c175513b483c Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/CommandParametersInitializer.java 3 files changed, 8 insertions(+), 88 deletions(-) Approvals: Michael Kublin: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf3a2c67ea5dbae8458844beaa98c175513b483c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixing comparison bug at UpdateVdsCommand
by mkublin＠redhat.com 09 Oct '12

09 Oct '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Fixing comparison bug at UpdateVdsCommand ...................................................................... core: Fixing comparison bug at UpdateVdsCommand The following bug is simple: comparison should be done by using equals and not != operator Change-Id: I6155a06800b738d7238e919d6311591d82851baf Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Kublin: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8421 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6155a06800b738d7238e919d6311591d82851baf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Improving RegisterVdsQuery
by mkublin＠redhat.com 09 Oct '12

09 Oct '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Improving RegisterVdsQuery ...................................................................... core: Improving RegisterVdsQuery The following patch is clean up and improving of RegisterVdsQuery. The patch doesn't contains all improvements, these is only a first step Current improvements: 1. Removed unneeded opening of threads - we opened a thread but still wait until it will finished, no reason for that 2. Removed unneeded global transaction - never good 3. Some small code clean ups Change-Id: Ida0d776fa5d24a2b68c774a82d5cda0b67c70f44 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 3 files changed, 116 insertions(+), 246 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8419 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida0d776fa5d24a2b68c774a82d5cda0b67c70f44 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: #855890 - Direct-LUN Disk Creation - Dont Require S...
by oliel＠redhat.com 09 Oct '12

09 Oct '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: #855890 - Direct-LUN Disk Creation - Dont Require Size ...................................................................... restapi: #855890 - Direct-LUN Disk Creation - Dont Require Size Change-Id: Ie8dba8d1e1b20ff5f81d9cfa944d3bfcd5630bc1 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResourceTest.java 3 files changed, 55 insertions(+), 5 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie8dba8d1e1b20ff5f81d9cfa944d3bfcd5630bc1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Refactored getInterfaceDAO in ActivateDeactivateVmNic...
by lhornyak＠redhat.com 08 Oct '12

08 Oct '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Refactored getInterfaceDAO in ActivateDeactivateVmNicCommand ...................................................................... core: Refactored getInterfaceDAO in ActivateDeactivateVmNicCommand Renamed to conform to camel case convention. Change-Id: Icb8e35e3e44b83da67badb632f4ddf6c0fc20c6b Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateDeactivateVmNicCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb8e35e3e44b83da67badb632f4ddf6c0fc20c6b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: FB: AddEmpgfetyStoragePoolCommand.AddStoragePoolToDb
by lhornyak＠redhat.com 08 Oct '12

08 Oct '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: FB: AddEmpgfetyStoragePoolCommand.AddStoragePoolToDb ...................................................................... core: FB: AddEmpgfetyStoragePoolCommand.AddStoragePoolToDb Renamed AddStoragePoolToDb() to addStoragePoolToDb() in AddEmptyStoragePoolCommand in order to solve the FindBugs warning about it (NM_METHOD_NAMING). Change-Id: I405838674d2a19fa83cef1378efd7c3059ab5386 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I405838674d2a19fa83cef1378efd7c3059ab5386 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: FB: ISingleAsyncOperationFactory.CreateSingleAsyncOper...
by lhornyak＠redhat.com 08 Oct '12

08 Oct '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: FB: ISingleAsyncOperationFactory.CreateSingleAsyncOperation ...................................................................... core: FB: ISingleAsyncOperationFactory.CreateSingleAsyncOperation Renamed the CreateSingleAsyncOperation() method to createSingleAsyncOperation() in ISingleAsyncOperationFactory and its implementing classes, in order to solve the FindBugs warning about it (NM_METHOD_NAMING_CONVENTION). Change-Id: I505809682c70082f7176c6d7365a31a4bf3dca8a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateDeactivateSingleAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AfterDeactivateSingleAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectSingleAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectStoragePoolAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshPoolSingleAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshStoragePoolAndDisconnectAsyncOperationFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ISingleAsyncOperationFactory.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SyncronizeNumberOfAsyncOperations.java 9 files changed, 9 insertions(+), 9 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I505809682c70082f7176c6d7365a31a4bf3dca8a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0