October 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: Revert "webadmin: "Fully configured" message for guide me di...
by gchaplik＠redhat.com 04 Oct '12

04 Oct '12

Gilad Chaplik has submitted this change and it was merged. Change subject: Revert "webadmin: "Fully configured" message for guide me dialogs (#850439)" ...................................................................... Revert "webadmin: "Fully configured" message for guide me dialogs (#850439)" This reverts commit 6727acdc6a3bec6e638a5410dcc07628c26636e0. causes regression because it reveals another bug. Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> Change-Id: Id85c8527684fbf6b5b54db37e524aac5c7a309d4 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.java 4 files changed, 30 insertions(+), 66 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/8350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id85c8527684fbf6b5b54db37e524aac5c7a309d4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated UI prompts in wizard
by juan.hernandez＠redhat.com 04 Oct '12

04 Oct '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated UI prompts in wizard ...................................................................... packaging: Updated UI prompts in wizard Change-Id: Iad3fd914c62669f67f134f269f6f6a8d08a5c8c5 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/output_messages.py 1 file changed, 11 insertions(+), 10 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8307 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad3fd914c62669f67f134f269f6f6a8d08a5c8c5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: use yum API
by juan.hernandez＠redhat.com 04 Oct '12

04 Oct '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: use yum API ...................................................................... packaging: use yum API PREVIOUS IMPLEMENTATION Use hybrid of yum API, yum cli, rpm cli NEW IMPLEMENTATION Use the yum python API, use single transaction, only top-level components, proper logging. The minyum module is shared between this module and bootstrap. Change-Id: I01c0c10c3bca42770bf05222c8b2b82b01fee0a6 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine-upgrade.py A packaging/fedora/setup/miniyum.py M packaging/fedora/setup/output_messages.py M packaging/fedora/spec/ovirt-engine.spec.in 8 files changed, 1,054 insertions(+), 346 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8221 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01c0c10c3bca42770bf05222c8b2b82b01fee0a6 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Stephen Gordon <sgordon(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: fixed NPE in RunVmOnceCommand
by tjelinek＠redhat.com 04 Oct '12

04 Oct '12

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: fixed NPE in RunVmOnceCommand ...................................................................... engine: fixed NPE in RunVmOnceCommand The patch I32e59783 has introduced a NPE. This patch fixes it. The problem was that the API can send empty boot sequence even for run once, and expects that the default boot sequence is set up in this case. Change-Id: I7c26fce5a7598f5d1a8ae4aa2b2c917bf8149d2c Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c26fce5a7598f5d1a8ae4aa2b2c917bf8149d2c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: #854371 - Create User - Validate That Domain Was Pa...
by oliel＠redhat.com 04 Oct '12

04 Oct '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: #854371 - Create User - Validate That Domain Was Passed ...................................................................... restapi: #854371 - Create User - Validate That Domain Was Passed Change-Id: I2dff7fbca4d3f410e37387922937380f38f7e06e Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResourceBase.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUsersResourceTest.java 3 files changed, 8 insertions(+), 11 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dff7fbca4d3f410e37387922937380f38f7e06e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix updating running VM details
by yzaslavs＠redhat.com 04 Oct '12

04 Oct '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: fix updating running VM details ...................................................................... core: fix updating running VM details - add images and interfaces to the allowed fields to be changed while VM is running. Since those entities are relational they are not update-able anyway throw update command but rather through updating interfaces or images directly. Change-Id: I4fb7d141f429d3931caab7ac0ee7b20fa946234b Signed-off-by: Roy Golan <rgolan(a)redhat.com> bug-url: https://bugzilla.redhat.com/show_bug.cgi?id=858610 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java 2 files changed, 47 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fb7d141f429d3931caab7ac0ee7b20fa946234b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: bootstrap: remove MAC address from vds unique id
by yzaslavs＠redhat.com 04 Oct '12

04 Oct '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: remove MAC address from vds unique id ...................................................................... bootstrap: remove MAC address from vds unique id CURRENT IMPLEMENTATION vds unique id is at format: @BIOS UUID@_@Low(MAC)@ If BIOS UUID was not available either empty or "Not" were used. PROBLEMS IN CURRENT IMPLEMENTATION BIOS UUID may be missing or duplicate. MAC may change either because of bonding (resolved) or because of physical adapter change. ASSUMPTION Hosts with no BIOS UUID or with duplicate UUID are less than 0.05% of the hosts we manage. CONCLUSION No need to add great complexity malformed UUID hosts 0.05%. But remove the MAC issues from the solution. METHOD Remove the MAC address from vds unique id. Allow to bypass BIOS UUID with configuration. DETAILS If /etc/vdsm/vdsm.id exists at host, content is the vds unique id. If dmidecode -s system-uuid is not '.*Not.*' this is the vds unique id. Else uuidgen > /var/lib/vdsm/host.id and use this as vds unique id. engine will strip '_.*' from vdsm unique id reported by vdsm, to allow communication with older vdsm, and to allow vdsm to continue to communicate with older engines. SIDE EFFECTS If RHEV-H is reinstalled on malformed host (one with no BIOS UUID) it will be treated as a new host. RHEV-H without the complimentary vdsm fix will not be able to register if installed on BIOS that does not support UUID, as it will not generate logical UUID before registration. If BIOS contains duplicate UUID, manual intervention should apply, creating /etc/vdsm/vdsm.id manually. UPGRADE During engine-upgrade all vds unique ids will be stripped out from MAC address. If there are duplicate vds unique ids or empty ids, warn user and list IP addresses of these problematic hosts, suggest host reinstall. Do not allow upgrade to be performed if malformed hosts are not in maintenance mode. Change-Id: I4f3e3fa01b4baa4120ffd765ded31c83ba40e299 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstallHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/wars/rmw-war/src/main/java/org/ovirt/engine/core/register/RegisterServlet.java M packaging/fedora/setup/engine-upgrade.py 9 files changed, 170 insertions(+), 35 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8125 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f3e3fa01b4baa4120ffd765ded31c83ba40e299 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Resizable columns in main tab grids
by vszocs＠redhat.com 03 Oct '12

03 Oct '12

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: Resizable columns in main tab grids ...................................................................... webadmin: Resizable columns in main tab grids This patch enables column resizing for all main tab grids, updating column widths as necessary. Column widths were updated for 1280 x <height> layout. In this layout, the sum of table column widths can take up to ~1000 pixels before a horizontal scroll-bar is shown. Note that some grids contain columns which don't fit into above mentioned ~1000 pixel boundary, which means that a horizontal scroll-bar is shown by default for such grids. This is simply a consequence of having many columns in the given grid, the user can always shrink (decrease width) of such columns if necessary. Change-Id: I16973df7a28b972e6ef7987f72aabe729715584b Bug-Url: https://bugzilla.redhat.com/767924 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabClusterView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDataCenterView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabEventView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabPoolView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabQuotaView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabTemplateView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabUserView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java 12 files changed, 145 insertions(+), 89 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8199 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16973df7a28b972e6ef7987f72aabe729715584b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Resizable table columns
by vszocs＠redhat.com 03 Oct '12

03 Oct '12

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Resizable table columns ...................................................................... webadmin,userportal: Resizable table columns This patch introduces resizable table columns feature into gwt-common module through the action table widget. Table columns can now be resized (have their widths changed) by dragging their right-hand border using mouse. Each resizable column has a 'resize bar area' on the right-hand side of its header. Whenever mouse hovers over this area, mouse cursor changes shape to indicate that column resize operation can begin. This implementation is suitable for HTML tables with 'table-layout:fixed' and 'width:100%' CSS attributes. An empty, no-width column at the end of the table is used to avoid actual columns being proportionally stretched (or shrinked) by the browser's table layout engine. As a result, resizing one column will have no impact on other columns, given that all columns (except the empty one) have their widths defined in pixel (PX) units. Furthermore, this implementation adds following features: 1. support horizontal scroll bar when total column width exceeds table display width 2. support minimum column width 3. visually highlight column header during column resize operation Each column SHOULD have an explicit width defined in pixel (PX) units. Any columns without explicit width will be proportionally resized by the browser's table layout engine. This feature is turned off by default. Following code shows how to turn it on. void initTable() { getTable().enableColumnResizing(); // must be called first getTable().addColumn(columnOne, "Foo", "50px"); // explicit PX width getTable().addColumn(columnTwo, "Bar", "200px"); // explicit PX width ... } Tested on FireFox 10 and Internet Explorer 8. Change-Id: Idbb8c32e1858a6e7810d1af9a82166e3790803f8 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractSubTabPresenter.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractSubTabFormView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractSubTabTableWidgetView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractSubTabTreeWidgetView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.ui.xml A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeHandler.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/HasResizableColumns.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ResizableHeader.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ResizableHeaderCell.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/PopupCellTable.css M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/PopupSimpleCellTable.css M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/SanStorageListLunTable.css M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/SanStorageListTargetTable.css M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/TabCellTable.css M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/TabCellTableHeaderless.css M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/AbstractSideTabWithDetailsPresenter.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/AbstractSideTabWithDetailsView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AbstractMainTabWithDetailsPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AbstractMainTabWithDetailsTableView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AbstractSubTabTableView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/css/FooterHeaderlessTable.css M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/css/IVdcQueryableCellTable.css 23 files changed, 501 insertions(+), 99 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbb8c32e1858a6e7810d1af9a82166e3790803f8 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: add a method to work with parsed sql output
by juan.hernandez＠redhat.com 03 Oct '12

03 Oct '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: add a method to work with parsed sql output ...................................................................... packaging: add a method to work with parsed sql output New function parseRemoteSqlCommand() to return the result within an array of dictionaries, keys are the table rows. Change-Id: I7a6e0461a3e31d31b2f3c8ef82a92c0e047b8e82 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/common_utils.py 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a6e0461a3e31d31b2f3c8ef82a92c0e047b8e82 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0