December 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: Fix comment in /etc/sysconfig/ovirt-engine
by juan.hernandez＠redhat.com 13 Dec '12

13 Dec '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Fix comment in /etc/sysconfig/ovirt-engine ...................................................................... packaging: Fix comment in /etc/sysconfig/ovirt-engine The /etc/sysconfig/ovirt-engine file contains a comment indicating the location of the defaults file, but it is wrong. Change-Id: Ie5d3e787645431b64a5bf6813f7b960c9240aeff Bug-Url: https://bugzilla.redhat.com/886433 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/engine-service.sysconfig 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie5d3e787645431b64a5bf6813f7b960c9240aeff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: API: Cannot remove the payload via REST
by shavivi＠redhat.com 13 Dec '12

13 Dec '12

Shahar Havivi has submitted this change and it was merged. Change subject: API: Cannot remove the payload via REST ...................................................................... API: Cannot remove the payload via REST Change-Id: I01cf3b6cf0bae68ec0797c0585ee55b19e54463d Bug-Url: https://bugzilla.redhat.com/882649 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 6 files changed, 116 insertions(+), 34 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01cf3b6cf0bae68ec0797c0585ee55b19e54463d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove unused ldap class.
by yzaslavs＠redhat.com 13 Dec '12

13 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: remove unused ldap class. ...................................................................... core: remove unused ldap class. org/ovirt/engine/core/common/businessentities/ad_vm_pool_group_map.java is unused. Change-Id: I9881423db29fc9933b31016fc6452a4e0b878156 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ad_vm_pool_group_map.java 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Sharad Mishra: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9881423db29fc9933b31016fc6452a4e0b878156 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Newly added domain is always before the old one
by yzaslavs＠redhat.com 13 Dec '12

13 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Newly added domain is always before the old one ...................................................................... core: Newly added domain is always before the old one When a domain is added using engine-manage-domains the list of domains in the frontend login screen and engine-manage-domains -action=list shows the newly added domain first. A natural ordering of domain names has been implemented in the backend and in ManageDomains code. Change-Id: I90b32678f8184ac39570e15aa840a8563bb350cf Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=731763 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDomainListQuery.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/DomainsConfigurationEntry.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java 3 files changed, 7 insertions(+), 3 deletions(-) Approvals: Ravi Nori: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90b32678f8184ac39570e15aa840a8563bb350cf Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: search disks does not complete bootable and shareabl...
by amureini＠redhat.com 13 Dec '12

13 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: engine: search disks does not complete bootable and shareable ...................................................................... engine: search disks does not complete bootable and shareable Search engine does not complete values for boolean fields like Disks : bootable = and Disks : shareable = Change-Id: Ia0a3a9c1fa6186c426d764afd11875e80478912b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=859762 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DiskConditionFieldAutoCompleter.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Allon Mureinik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0a3a9c1fa6186c426d764afd11875e80478912b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImportVm test cleanup: remove spring
by amureini＠redhat.com 13 Dec '12

13 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVm test cleanup: remove spring ...................................................................... core: ImportVm test cleanup: remove spring Remove wrongfully used spring validation assertions and replaced with standard JUnit 4 calls. Change-Id: I67e7593ea28751cd6c4c50a54ec0bdf46174107f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67e7593ea28751cd6c4c50a54ec0bdf46174107f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImportVm test cleanup: createVm return
by amureini＠redhat.com 13 Dec '12

13 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVm test cleanup: createVm return ...................................................................... core: ImportVm test cleanup: createVm return Inline the return statement in createVm(), for better readability. Change-Id: Ieec82913fbb116544293d2aeabbd86d00d08374c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieec82913fbb116544293d2aeabbd86d00d08374c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImportVm cleanup: iterate maps values()
by amureini＠redhat.com 13 Dec '12

13 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVm cleanup: iterate maps values() ...................................................................... core: ImportVm cleanup: iterate maps values() Iterate of VM's disks map values() instead of iterating over the keySet() and using get() to retrieve the value when the key is not interesting. The main purpose for this change is the added readability, and the (slight) performance gain is just a bonus. Change-Id: I687810d5619603aab135a7d5d8e8fcef11685e9a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 9 insertions(+), 11 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9616 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I687810d5619603aab135a7d5d8e8fcef11685e9a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Modify excepted exception to match impl
by masayag＠redhat.com 13 Dec '12

13 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Modify excepted exception to match impl ...................................................................... engine: Modify excepted exception to match impl The patch modifies the expected exception to the correct package so test could pass successfully. Change-Id: I016ced1da2d86e27497149fac82fea832ce01a1e Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/NetworkDAOHibernateImplTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I016ced1da2d86e27497149fac82fea832ce01a1e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Modify Network Assign to Cluster Command permissions
by mkolesni＠redhat.com 13 Dec '12

13 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Modify Network Assign to Cluster Command permissions ...................................................................... engine: Modify Network Assign to Cluster Command permissions The patch modifies the required permissions for performing Network assignment, update or removing a network from a Cluster. These operations require a permission on the Network or a permission on the Cluster when updating the network on the cluster. Change-Id: Iff1edaeaf323a7a5b7c407e06d2ff9e3dae3430a Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkOnClusterCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 4 files changed, 106 insertions(+), 10 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/9540 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff1edaeaf323a7a5b7c407e06d2ff9e3dae3430a Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0