December 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: adding loginUserId and loginUserName provider func...
by oourfali＠redhat.com 18 Dec '12

18 Dec '12

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: adding loginUserId and loginUserName provider functions ...................................................................... webadmin: adding loginUserId and loginUserName provider functions It is useful for UI plugins to get the user name and ID. This patch adds this functionality to the plugin manager. Change-Id: I932e329668d7fc8d0a3608d2984d2645a98fe053 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/auth/CurrentUser.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginEventHandler.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/PluginManager.java 3 files changed, 20 insertions(+), 9 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I932e329668d7fc8d0a3608d2984d2645a98fe053 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove redundant constructors from VmStatistics
by lhornyak＠redhat.com 18 Dec '12

18 Dec '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: remove redundant constructors from VmStatistics ...................................................................... core: remove redundant constructors from VmStatistics Only the default constructor was used, so the constructors could be deleted. Change-Id: Ic99ac3f32534edfe5007f8e7a8b4873a680a3ab1 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java 1 file changed, 0 insertions(+), 16 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic99ac3f32534edfe5007f8e7a8b4873a680a3ab1 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: change gracefully shutdown message (#854218)
by ofrenkel＠redhat.com 18 Dec '12

18 Dec '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: change gracefully shutdown message (#854218) ...................................................................... core: change gracefully shutdown message (#854218) Change message that is shown to the user when vm is shutdown by the admin. Change-Id: Ife750533205a716af4adafa2874d3c958246aae4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=854218 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife750533205a716af4adafa2874d3c958246aae4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImportVm cleanup: action and type params
by amureini＠redhat.com 18 Dec '12

18 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVm cleanup: action and type params ...................................................................... core: ImportVm cleanup: action and type params The $action and $type params were set in canDoAction_afterCloneVm, which caused them to be empty if the command failed during canDoAction_beforeCloneVm. This patch moves them to the setActionMessagesParameters() method, so they are set if any failure occurred, regardless of its stage. Change-Id: I9b3148cd54146ac0b90924464cd27fb54160889b Bug-Url: https://bugzilla.redhat.com/885459 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b3148cd54146ac0b90924464cd27fb54160889b Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImportVm test cleanup: property generation
by amureini＠redhat.com 18 Dec '12

18 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImportVm test cleanup: property generation ...................................................................... core: ImportVm test cleanup: property generation Added new functionality to RandomUtils to randomly generate Strings that are valid property strings (i.e., may contain the characters a-z, A-Z, 0-9,"_" and "."), and used it in the test instead of the hard coded string100 and string5000 variables. A RandomUtilsSeedingRule was also added to the test to make this pseudo-random output predictable, or at least reproducible. Change-Id: I1f04e067e8bce2c6cd1010f83a44809a3c8c464c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/RandomUtils.java 2 files changed, 42 insertions(+), 30 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f04e067e8bce2c6cd1010f83a44809a3c8c464c Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Brick status shows 'UP' even after brick process is ...
by ofrenkel＠redhat.com 18 Dec '12

18 Dec '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Brick status shows 'UP' even after brick process is killed ...................................................................... engine: Brick status shows 'UP' even after brick process is killed Vdsm sends "N/A" for Pid in case of brick status is offline. So Port and Pid will be parsed only if the brick status is online. Change-Id: I323d9c5c30d707619e7403b76bd33cc43bc90499 Bug-Url: https://bugzilla.redhat.com/886471 Signed-off-by: Dhandapani <dgopal(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GlusterVolumeStatusReturnForXmlRpc.java 1 file changed, 15 insertions(+), 15 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I323d9c5c30d707619e7403b76bd33cc43bc90499 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add UserVmManager to VM PowerUsers on upgrade (#883365...
by oourfali＠redhat.com 18 Dec '12

18 Dec '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: Add UserVmManager to VM PowerUsers on upgrade (#883365) ...................................................................... core: Add UserVmManager to VM PowerUsers on upgrade (#883365) https://bugzilla.redhat.com/883365 Recently the PowerUser was changed to be a creator role. Thus, users with PowerUser on a VM can't run it, which doesn't make much sense. This upgrade script fixes that issue by adding a UserVmManager permission on such VMs to the user which had direct PowerUser on them. Change-Id: Id0d51bc27e9f6d5318744a73fbd1ed870cccf85d Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_02_0080_add_user_vm_manager_to_vm_power_users.sql 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/10183 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0d51bc27e9f6d5318744a73fbd1ed870cccf85d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: fix upgrade number due to duplicate
by amureini＠redhat.com 18 Dec '12

18 Dec '12

Allon Mureinik has submitted this change and it was merged. Change subject: fix upgrade number due to duplicate ...................................................................... fix upgrade number due to duplicate Change-Id: I39f1831f919fb80fcc4e269aff4ea78715a6262e Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- R backend/manager/dbscripts/upgrade/03_02_0070_ha_vm_event_notifications.sql 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39f1831f919fb80fcc4e269aff4ea78715a6262e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Upgrade PowerMock to 1.5
by mpastern＠redhat.com 18 Dec '12

18 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: core: Upgrade PowerMock to 1.5 ...................................................................... core: Upgrade PowerMock to 1.5 Upgraded PowerMock to 1.5 in order to support a future move to Java 7. This change is required since PowerMock 1.4.10 uses javassit 3.15.0-GA, which does not handle Java 7's byte-code properly. PowerMock 1.5 upgrades the dependency to javassit 3.17.1-GA, which can handle the new bytcode instructions. Change-Id: Ia3799efcc82e04b0a2aad7b2735f32ace7e10bb0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10179 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3799efcc82e04b0a2aad7b2735f32ace7e10bb0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core+ui: add HA events to notification service
by oourfali＠redhat.com 18 Dec '12

18 Dec '12

Oved Ourfali has submitted this change and it was merged. Change subject: core+ui: add HA events to notification service ...................................................................... core+ui: add HA events to notification service Previous patch introduced two new events to the HA VM. This patch adds them to the notification service. Change-Id: I0d378cd041bb7b47085acfadb706ff745228a161 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_02_0060_ha_vm_event_notifications.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 4 files changed, 12 insertions(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10162 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d378cd041bb7b47085acfadb706ff745228a161 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0