December 2012 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: engine: Changed "Host" to "Server"

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Changed "Host" to "Server" ...................................................................... engine: Changed "Host" to "Server" Changed existing "Host" to "Server" in Add Gluster Server related sources, since server is more appropriate in gluster context. Updated the event_map table value Host to Server by introducing upgrade script. Change-Id: Ia37048f232b40387f6871050926df6815280fe1e Signed-off-by: Dhandapani <dgopal(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_02_0060_change_host_to_server_event_map.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/AddGlusterServerVDSParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterHostAddVDSParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AddGlusterServerVDSCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterHostAddVDSCommand.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 15 files changed, 69 insertions(+), 64 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Dhandapani Gopal: Verified -- To view, visit http://gerrit.ovirt.org/9821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia37048f232b40387f6871050926df6815280fe1e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: correlation ID should not be localized

by ecohen＠redhat.com

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: correlation ID should not be localized ...................................................................... webadmin: correlation ID should not be localized When using non-English localization, 'Configure Local Storage' throws VALIDATION_INVALID_CORRELATION_ID error. Therefore, disabled correlationId non-mandatory localization. Change-Id: If09925567472fb546b62942c1c51d36b49a62289 Bug-Url: https://bugzilla.redhat.com/886824 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 2 files changed, 1 insertion(+), 6 deletions(-) Approvals: Ayal Baron: Looks good to me, but someone else must approve Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10176 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If09925567472fb546b62942c1c51d36b49a62289 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-host-deploy[master]: doc: minor cleanups

by Alon Bar-Lev

Alon Bar-Lev has submitted this change and it was merged. Change subject: doc: minor cleanups ...................................................................... doc: minor cleanups Change-Id: Ic623c9d644287c1ca1cbe8260f78b35f80e04f87 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M README M README.environment 3 files changed, 9 insertions(+), 9 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic623c9d644287c1ca1cbe8260f78b35f80e04f87 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: [es_ES] heading "Virtual size" is truncated in Spa...

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: [es_ES] heading "Virtual size" is truncated in Spanish (#871379) ...................................................................... webadmin: [es_ES] heading "Virtual size" is truncated in Spanish (#871379) https://bugzilla.redhat.com/871379 Increased the size of the "Virtual Size" column to fit all locales. Change-Id: I8a00c8f1ad60c0f551664630bb2f375cc224aa21 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a00c8f1ad60c0f551664630bb2f375cc224aa21 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: tools: engine-manage-domains should not write passwd to log

by yzaslavs＠redhat.com

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: engine-manage-domains should not write passwd to log ...................................................................... tools: engine-manage-domains should not write passwd to log Running "engine-manage-domains -action=validate" records password in log in clear text. Change-Id: Iff044f9c331dad9cc3b923c955dcad41fabdf48d Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/ConfigKey.java 2 files changed, 17 insertions(+), 1 deletion(-) Approvals: Ravi Nori: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff044f9c331dad9cc3b923c955dcad41fabdf48d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: restapi: Add permissions sub collections to Networks

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: restapi: Add permissions sub collections to Networks ...................................................................... restapi: Add permissions sub collections to Networks The patch adds the permissions sub collections to Network resource. Change-Id: Ib2d2fab5f0e546fe92c9f5add7fc2a83b2c1d159 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/NetworkResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendNetworksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworkResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworksResource.java 5 files changed, 67 insertions(+), 12 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/10033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2d2fab5f0e546fe92c9f5add7fc2a83b2c1d159 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Use "Power Off" instead of "Stop" VM action (#8696...

by achub＠redhat.com

Alexey Chub has submitted this change and it was merged. Change subject: webadmin: Use "Power Off" instead of "Stop" VM action (#869634) ...................................................................... webadmin: Use "Power Off" instead of "Stop" VM action (#869634) Change-Id: I06b60e5fa3159ff74c857418cd058b39916a32dd Signed-off-by: Alexey Chub <achub(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 2 files changed, 7 insertions(+), 7 deletions(-) Approvals: Alexey Chub: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9377 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06b60e5fa3159ff74c857418cd058b39916a32dd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: NullPointerException detected when selecting hosts

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: NullPointerException detected when selecting hosts ...................................................................... webadmin: NullPointerException detected when selecting hosts libvirtVersion attribute causes NullPointerException Change-Id: I7398439d3c7dfe59750213fe94c06899b9d2cacd Signed-off-by: Libor Spevak <lspevak(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10152 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7398439d3c7dfe59750213fe94c06899b9d2cacd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspevak(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: Refactor MigrateVmCommand#getAuditLogTypeValue

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: Refactor MigrateVmCommand#getAuditLogTypeValue ...................................................................... core: Refactor MigrateVmCommand#getAuditLogTypeValue - Remove the usage of local field "startMessage" that was used only once - Move the comment which explains the logic of this method outside of the method to improve its readability Change-Id: Ic6f16b4dcf51de74898291b52d18a9d0eddac1c4 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10113 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6f16b4dcf51de74898291b52d18a9d0eddac1c4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: Fix IndexOutOfBoundsException in plug FC disk

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix IndexOutOfBoundsException in plug FC disk ...................................................................... core: Fix IndexOutOfBoundsException in plug FC disk Attach/Detach and plug disk throws an indexOutOfBoundsException. The reason for that is that the FC LUN which the disk is related to does not contains any connections in it, as opposed to ISCSI lun which must have connections related to it. The proposed fix is to use FCP storage type if the LUN does not contain any connections in it. Change-Id: I6414445b9a74be299205ff7fc9a21d1388a29687 Bug-Url: https://bugzilla.redhat.com/882825 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java 2 files changed, 61 insertions(+), 4 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6414445b9a74be299205ff7fc9a21d1388a29687 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: liron aravot <liron.aravot(a)gmail.com>

12 years, 1 month

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits December 2012