December 2012 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: webadmin: "No message" is displayed in Japanese environment

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: "No message" is displayed in Japanese environment ...................................................................... webadmin: "No message" is displayed in Japanese environment New/Edit VM dialog -> fill a japanese chars into the description field. An error dialog with message "No message" will be displayed. The problem was, that the ErrorTranslator expected, that when a message is in form: "$AAA b" is a variable $AAA with value "b". Than it expected that the ${AAA} in other messages can be replaced by "b". The problem was, that the decision, if the specific message is a variable declaration or a message was decided in a following way: - if the string starts with "$" character, than it is a variable declaration - it is a message otherwise The problem with this is, that when a message looks like "${AAA} b" than it is considered to be a variable declaration, even it is a message with reference to the declaration. Fixed by enriching this decision if somethin is a variable declaratition to the following: - if the string starts with "$" but it is does not start with something like "${some string}" it is a variable - it is a message otherwise Change-Id: I04b32be4cf4c05873bcf9643dd5b9acb3695a54a Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ErrorTranslator.java A frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/ErrorTranslatorTest.java 2 files changed, 47 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9818 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04b32be4cf4c05873bcf9643dd5b9acb3695a54a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine-cli[master]: cli: auto complete suggests "from_event_id" while it shouldn...

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: cli: auto complete suggests "from_event_id" while it shouldnt #886792 ...................................................................... cli: auto complete suggests "from_event_id" while it shouldnt #886792 https://bugzilla.redhat.com/show_bug.cgi?id=886792 Change-Id: I76fa563cb5a1d35b71eec01670b03239ddb92379 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/utils/autocompletionhelper.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76fa563cb5a1d35b71eec01670b03239ddb92379 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine-cli[master]: cli: filter out _Base__context prop in txt formating

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: cli: filter out _Base__context prop in txt formating ...................................................................... cli: filter out _Base__context prop in txt formating _Base__context prop belongs to sdk internals Change-Id: Idc8765c4bcaa1f4787b65e90f8d866ae60564d56 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/format/text.py 1 file changed, 1 insertion(+), 70 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc8765c4bcaa1f4787b65e90f8d866ae60564d56 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine-cli[master]: cli: negative numbers wrapped as strings #880216

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: cli: negative numbers wrapped as strings #880216 ...................................................................... cli: negative numbers wrapped as strings #880216 https://bugzilla.redhat.com/show_bug.cgi?id=880216 Change-Id: Ib5ff2aa8a22a0a6059e717214c88f686943e0533 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/cli/parser.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5ff2aa8a22a0a6059e717214c88f686943e0533 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine-cli[master]: cli: missing acknowledgement for remove commands #886941

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: cli: missing acknowledgement for remove commands #886941 ...................................................................... cli: missing acknowledgement for remove commands #886941 https://bugzilla.redhat.com/show_bug.cgi?id=886941 Change-Id: Ib612a6bb69fb9319131cddc02a84c715a4786286 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/cli/messages.py M src/ovirtcli/command/remove.py 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib612a6bb69fb9319131cddc02a84c715a4786286 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine-cli[master]: cli: update prompt status upon "Connection failure" #880559

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: cli: update prompt status upon "Connection failure" #880559 ...................................................................... cli: update prompt status upon "Connection failure" #880559 https://bugzilla.redhat.com/show_bug.cgi?id=880559 Change-Id: I18c7ec8c986315e30fd4ae0e8e7598cef960fa05 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/cli/context.py M src/cli/messages.py M src/ovirtcli/command/connect.py M src/ovirtcli/context.py M src/ovirtcli/shell/engineshell.py 5 files changed, 40 insertions(+), 28 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18c7ec8c986315e30fd4ae0e8e7598cef960fa05 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine-cli[master]: cli: support fetching new sdk proxy

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: cli: support fetching new sdk proxy ...................................................................... cli: support fetching new sdk proxy Change-Id: I9dd0e827fd1347be5a2299abae8eeadb930c1a48 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/command/connect.py M src/ovirtcli/command/console.py M src/ovirtcli/command/info.py M src/ovirtcli/context.py 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10027 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9dd0e827fd1347be5a2299abae8eeadb930c1a48 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine-cli[master]: cli: Wrong name of section in .rhevmshell causes to tracebac...

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: cli: Wrong name of section in .rhevmshell causes to traceback #880641 ...................................................................... cli: Wrong name of section in .rhevmshell causes to traceback #880641 https://bugzilla.redhat.com/show_bug.cgi?id=880641 Change-Id: Ie29d9d5e26e7a69097dd199bee0192971cc8324d Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/cli/settings.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie29d9d5e26e7a69097dd199bee0192971cc8324d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: userportal: allow connection to guest with non resp agent

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: allow connection to guest with non resp agent ...................................................................... userportal: allow connection to guest with non resp agent Change the way we treat non responding agent error received from VDSM when trying to connect to guest using spice. Instead of showing an error dialog and canceling the spice connection, we now present a confirmation dialog (saying that the user will have reduced capabilities due to the fact the agent is non-responsibe) - if the user choose to cancel, the spice console won't opened, and if the user choose to continue, spice console will be opened without SSO. FrontendEventsHandlerImpl was changed such that it won't show error dialog in case the returned error is 'nonresp' (non responding guest agent) from logon command. In addition, the confirmation dialog described above for the spice console connection operation was added. Change-Id: I4eaf009f5ff99946dbb421459ccdec9c536aea58 Bug-Url: https://bugzilla.redhat.com/871083 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/IFrontendEventsHandler.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceToGuestWithNonRespAgentModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/basic/UserPortalBasicListProvider.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/UserPortalListProvider.java 11 files changed, 120 insertions(+), 27 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/10030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4eaf009f5ff99946dbb421459ccdec9c536aea58 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: engine: Adding VmGuestInfoInterface

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Adding VmGuestInfoInterface ...................................................................... engine: Adding VmGuestInfoInterface As part of the Reporting Internal Vnic Information feature, this patch adds a new table, Dao and entity called vm_guest_agent_interface, VmGuestAgentInterfaceDao and VmGuestAgentInterface respectively. Each row in this table is related to a specific VM, and will be presented through REST API under that VM. Also, it will be associated with Vm Interfaces according to Mac address. Change-Id: I0d25018f94c2b4d29c01be85a222460335603569 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/dbscripts/network_sp.sql A backend/manager/dbscripts/upgrade/03_02_0050_add_vm_guest_agent_interfaces_table.sql A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmGuestAgentInterface.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmGuestAgentInterfaceDao.java A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmGuestAgentInterfaceDaoDbFacadeImpl.java M backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmGuestAgentInterfaceDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml 10 files changed, 433 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d25018f94c2b4d29c01be85a222460335603569 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

12 years, 1 month

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits December 2012