June 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: Fix NPE when importing VMs that have no ExportDate
by shavivi＠redhat.com 18 Jun '12

18 Jun '12

Shahar Havivi has submitted this change and it was merged. Change subject: Fix NPE when importing VMs that have no ExportDate ...................................................................... Fix NPE when importing VMs that have no ExportDate Change-Id: I6490142bd0c8b6bdd908015aaab7a633d57865b7 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5449 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6490142bd0c8b6bdd908015aaab7a633d57865b7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: webadmin: edit pool- disable fields
by vszocs＠redhat.com 18 Jun '12

18 Jun '12

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: edit pool- disable fields ...................................................................... webadmin: edit pool- disable fields in edit pool we cannot edit fields except description, num of vms and prestarted vms. created another view, presenter and widget for edit pool (originaly new pool) and disabled all the popup except the field above. Change-Id: I73888cb2536ce0607413c3bb8bf971f8a150897b Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolEditPopupWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/PoolModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/pool/PoolEditPopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/pool/PoolEditPopupView.java 6 files changed, 85 insertions(+), 5 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73888cb2536ce0607413c3bb8bf971f8a150897b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Consolidate HasEnabled interface
by vszocs＠redhat.com 18 Jun '12

18 Jun '12

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: Consolidate HasEnabled interface ...................................................................... webadmin,userportal: Consolidate HasEnabled interface Created HasEnabledWithHints interface that extends GWT HasEnabled interface. Updated UiCommonEditorVisitor to work with HasEnabledWithHints interface. Change-Id: Idd95db2826f303747d88ead918f0eaf5d90b7caf Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorVisitor.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HasEnabled.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HasEnabledWithHints.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/WidgetWithLabelEditor.java 5 files changed, 36 insertions(+), 46 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5452 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd95db2826f303747d88ead918f0eaf5d90b7caf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Send empty collection for spec params
by mkolesni＠redhat.com 18 Jun '12

18 Jun '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Send empty collection for spec params ...................................................................... core: Send empty collection for spec params The patch sends empty map value for spec params as the xml rpc requires it. Change-Id: I37f3b4dbe932c723c125f588259e6650ab217c8d Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37f3b4dbe932c723c125f588259e6650ab217c8d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Validating brick directory in Add Bricks (#829664)
by gchaplik＠redhat.com 18 Jun '12

18 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Validating brick directory in Add Bricks (#829664) ...................................................................... webadmin: Validating brick directory in Add Bricks (#829664) https://bugzilla.redhat.com/829664 Validations added for brick directory length and space in the path. Apropriate error messages will be shown in case of any validation errors. Change-Id: I889c2f69701571ebab9fa376e63f2df5344fae48 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 2 files changed, 34 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5435 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I889c2f69701571ebab9fa376e63f2df5344fae48 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Setup networks- edit dialogs
by gchaplik＠redhat.com 18 Jun '12

18 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Setup networks- edit dialogs ...................................................................... webadmin: Setup networks- edit dialogs https://bugzilla.redhat.com/show_bug.cgi?id=823881 - The "edit pencil" should be on: - Bond - networks (attached to a nic/bond) - The bond edit should be always enabled (even if there are no networks attached), and contain just- - bond name- disabled - bonding mode - The network edit should contain- - network name- disabled - boot protocol (if management- none is disabled) - if management- contains deafult gateway Also contains- - Fixed the "bond" edit form size (Network name was cropped) - Fixed NPE when choosing - static boot protocol - Adding missing enum to LocalizedEnums (VdcActionType___UpdateNetworkToVdsInterface) Change-Id: I16d3134a5ad14943851031b22ac6c9d7b0675d28 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostManagementPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/BondPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NicPanel.java 10 files changed, 142 insertions(+), 126 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16d3134a5ad14943851031b22ac6c9d7b0675d28 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: LOCALFS storage path regex validation.
by gchaplik＠redhat.com 18 Jun '12

18 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: LOCALFS storage path regex validation. ...................................................................... webadmin: LOCALFS storage path regex validation. LOCALFS storage path is not validated with regex in frontend, being sent to the backend/vdsm as is, even invalid. On the other hand, adding a NFS storage, the path is validated in frontend, avoiding extra processing and quickly/clearly informing user about what's wrong. This patch adds the LOCALFS path validation in frontend, in order to standardize according with the NFS regex path validation. Change-Id: I89a768957974b67754f5a3b78ec8f773e25adc7b Signed-off-by: Amador Pahim <apahim(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/LocalStorageModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/LocalfsLinuxMountPointValidation.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 3 files changed, 39 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89a768957974b67754f5a3b78ec8f773e25adc7b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amador Pahim <apahim(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Amador Pahim <apahim(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix logging in StorageHelperDirector
by yzaslavs＠redhat.com 18 Jun '12

18 Jun '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: fix logging in StorageHelperDirector ...................................................................... core: fix logging in StorageHelperDirector change log output to debug in case of ClassNotFoundException while looking for helper classes Change-Id: I30de67a9aa1f629295582b160df753e362371686 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperDirector.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30de67a9aa1f629295582b160df753e362371686 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Don't modifiy limits.conf during setup
by oschreib＠redhat.com 18 Jun '12

18 Jun '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Don't modifiy limits.conf during setup ...................................................................... packaging: Don't modifiy limits.conf during setup Instead of modifying the /etc/security/limits.conf it is better to drop a small file in the /etc/security/limits.d directory. For platforms using systemd to manage services the above will not work ans systemd ignores completely the limits.conf and limits.d directory. Instead of that the limits have to be specified in the file defining the service. This also fixes the name of the user, which should be ovirt instead of jbossas. Change-Id: Ib64ce87bd7ddf2749d2d1de85668250d5c59f779 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile A packaging/fedora/engine-service.limits M packaging/fedora/engine-service.systemd M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/output_messages.py M packaging/fedora/spec/ovirt-engine.spec.in 7 files changed, 9 insertions(+), 65 deletions(-) Approvals: Juan Hernandez: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib64ce87bd7ddf2749d2d1de85668250d5c59f779 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Update disk hot-plug availability
by derez＠redhat.com 18 Jun '12

18 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Update disk hot-plug availability ...................................................................... webadmin: Update disk hot-plug availability https://bugzilla.redhat.com/833040 Calling UpdateIsDiskHotPlugAvailable on 'OnEntityChanged' method. Change-Id: I622d10214a2b12b3e32ce53f7e844c7234a4b39d Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Daniel Erez: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I622d10214a2b12b3e32ce53f7e844c7234a4b39d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0