Change in ovirt-engine[master]: engine: Added dynamic message in the can do action message
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Added dynamic message in the can do action message
......................................................................
engine: Added dynamic message in the can do action message
- Volume name added dynamically in the can do action message
for the following commands
- Create Gluster Volume
- Delete Gluster Volume
- Start Gluster Volume
- Stop Gluster Volume
Change-Id: I30329ef5b95f1bc18b160bf0887f9e2cbae25a4f
Signed-off-by: Dhandapani <dgopal(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
6 files changed, 21 insertions(+), 11 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Dhandapani Gopal: Verified
--
To view, visit http://gerrit.ovirt.org/5374
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I30329ef5b95f1bc18b160bf0887f9e2cbae25a4f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: engine: getUpServer will return null instead of throwing exc...
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: getUpServer will return null instead of throwing exception, if no up server
......................................................................
engine: getUpServer will return null instead of throwing exception, if no up server
- Changed the code to return null and put the code that checks for null
and adds canDoActionError/fault in a common place to avoiding
too many null checks all over the place.
- Done the related changes in the test class.
Change-Id: I0be9452aeda1cf8574d896e75d0c29fa77ed5cac
Signed-off-by: Dhandapani <dgopal(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ReplaceGlusterVolumeBrickCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetGlusterVolumeOptionsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGlusterVolumeOptionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartRebalanceGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/ClusterUtils.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/DeleteGlusterVolumeCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StartRebalanceGlusterVolumeCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeCommandTest.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
21 files changed, 70 insertions(+), 39 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Dhandapani Gopal: Verified
--
To view, visit http://gerrit.ovirt.org/5271
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0be9452aeda1cf8574d896e75d0c29fa77ed5cac
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: packaging: Remove 0001 suffix from version number
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: packaging: Remove 0001 suffix from version number
......................................................................
packaging: Remove 0001 suffix from version number
As far as I understand this was needed to workaround a bug in
maven 2, but is no longer needed.
This patch also changes the release number in the spec to 3 to
match the changelog.
Change-Id: I7db84a5bcd5dd09a57506ddb73491e0e7e00dd70
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M Makefile
M backend/manager/dbscripts/pom.xml
M backend/manager/modules/beans/pom.xml
M backend/manager/modules/beans/scheduler/pom.xml
M backend/manager/modules/bll/pom.xml
M backend/manager/modules/common/pom.xml
M backend/manager/modules/compat/pom.xml
M backend/manager/modules/dal/pom.xml
M backend/manager/modules/engineencryptutils/pom.xml
M backend/manager/modules/pom.xml
M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml
M backend/manager/modules/restapi/interface/common/pom.xml
M backend/manager/modules/restapi/interface/definition/pom.xml
M backend/manager/modules/restapi/interface/pom.xml
M backend/manager/modules/restapi/jaxrs/pom.xml
M backend/manager/modules/restapi/pom.xml
M backend/manager/modules/restapi/types/pom.xml
M backend/manager/modules/restapi/webapp/pom.xml
M backend/manager/modules/root/pom.xml
M backend/manager/modules/searchbackend/pom.xml
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/vdsbroker/pom.xml
M backend/manager/pom.xml
M backend/manager/tools/engine-config/pom.xml
M backend/manager/tools/engine-notifier/engine-notifier-resources/pom.xml
M backend/manager/tools/engine-notifier/engine-notifier-service/pom.xml
M backend/manager/tools/engine-notifier/pom.xml
M backend/manager/tools/engine-tools-common/pom.xml
M backend/manager/tools/pom.xml
M backend/pom.xml
M build-tools-root/checkstyles/pom.xml
M build-tools-root/ovirt-checkstyle-extension/pom.xml
M build-tools-root/pom.xml
M ear/pom.xml
M frontend/api/genericapi/pom.xml
M frontend/api/pom.xml
M frontend/pom.xml
M frontend/wars/pom.xml
M frontend/wars/rmw-war/pom.xml
M frontend/webadmin/modules/frontend/pom.xml
M frontend/webadmin/modules/gwt-common/pom.xml
M frontend/webadmin/modules/gwt-extension/pom.xml
M frontend/webadmin/modules/pom.xml
M frontend/webadmin/modules/uicommonweb/pom.xml
M frontend/webadmin/modules/uicompat/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
M frontend/webadmin/pom.xml
M packaging/fedora/spec/ovirt-engine.spec.in
M pom.xml
50 files changed, 56 insertions(+), 64 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4914
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7db84a5bcd5dd09a57506ddb73491e0e7e00dd70
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Providing clear job name for VdsNonRespondingTreatment...
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Providing clear job name for VdsNonRespondingTreatmentCommand
......................................................................
core: Providing clear job name for VdsNonRespondingTreatmentCommand
This patch provides a better job description to be presented in case
Vds undergoes non responding treatment
Change-Id: I05ea7eb334eb5f246d035faeca085b052a68961f
Acked-by:
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
2 files changed, 15 insertions(+), 0 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5404
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05ea7eb334eb5f246d035faeca085b052a68961f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: using user_disk_permissions_view in get vm disks
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: using user_disk_permissions_view in get vm disks
......................................................................
core: using user_disk_permissions_view in get vm disks
This patch uses user_disk_permissions_view instead of the user_vm_permissions view, when
querying for user's VM disks.
The result is that when querying for VM/Template disks, you'll get the
disks you have permissions on, either directly or inheritable.
Also, changing the user_disk_permissions_view to use the
user_vm/template_permissions view.
Change-Id: I46608ffd60cd2f60af8a23c85776ac6cb92f3c25
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/dbscripts/all_disks_sp.sql
M backend/manager/dbscripts/create_views.sql
2 files changed, 10 insertions(+), 10 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I46608ffd60cd2f60af8a23c85776ac6cb92f3c25
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: packaging: Update broken links in welcome page
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Update broken links in welcome page
......................................................................
packaging: Update broken links in welcome page
Updated link to reports protal and dropped non-ssl link to webadmin.
Change-Id: I7f611a849c336c5fce2622aa50a00aff784be03c
Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com>
---
M backend/manager/modules/root/src/main/webapp/index.html
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f611a849c336c5fce2622aa50a00aff784be03c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Explicit permission when adding a template
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Explicit permission when adding a template
......................................................................
core: Explicit permission when adding a template
When creating a new VM Template, its owner should be given
TEMPLATE_OWNER role on it (a new USER role, also defined in this
patch), so he can adminster it.
Change-Id: I7885c03a09c9315fd8eb2f554bc266250fa7e181
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
A backend/manager/dbscripts/upgrade/03_01_1240_add_template_owner_role.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PredefinedRoles.java
3 files changed, 46 insertions(+), 7 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5267
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7885c03a09c9315fd8eb2f554bc266250fa7e181
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Add validation for not null cpu
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Add validation for not null cpu
......................................................................
core: Add validation for not null cpu
Not null cpu (for virt service upon adding a new
Cluster) should be added.
Current behavior (prior to this patch) will produce
a canDoAction of "cpu is not supported" but this is
a wrong message in case of null cpu (this
message should be kept for a non null cpu which
indeed is not supported for a given compatbility
version)
Change-Id: I7f6433390ad85e9ba7431b206d15a5f8d6846736
Acked-by:
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/VdsGroupValidator.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/ValidVdsGroup.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 61 insertions(+), 0 deletions(-)
Approvals:
Roy Golan: Looks good to me, approved
Yair Zaslavsky: Verified
--
To view, visit http://gerrit.ovirt.org/5399
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f6433390ad85e9ba7431b206d15a5f8d6846736
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Increase file servlet size warning threshold to 1 MiB
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: Increase file servlet size warning threshold to 1 MiB
......................................................................
core: Increase file servlet size warning threshold to 1 MiB
Right now the file servlet warns when requested files are larger
than 8 KiB, this generates a warning each time the deployUtil.py
files is downloaded, for example. This is confusing some users.
This patch changes the warning threshold to 1 MiB.
Change-Id: Ie428065b0e9cde3ee6d4aab1d779a1023230b9ce
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/root/src/main/java/org/ovirt/engine/core/ServletUtils.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4969
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie428065b0e9cde3ee6d4aab1d779a1023230b9ce
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: packaging: Add key-alias to SSL connector
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Add key-alias to SSL connector
......................................................................
packaging: Add key-alias to SSL connector
The "key-alias" attribute for the SSL connector has a default
value of "jboss", but the application server used to take the
first key pair from the keystore when it was missing. Starting
with version 7.1.2 it will always use it, and thus fail with our
keystore which only contains the "engine" alias. This patch
changes the setup tool so that it will always add the attribute.
Change-Id: I2921ad93b2b10de935ae98ef8bc5815e5aa4ecee
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M packaging/fedora/setup/engine-setup.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified
Ofer Schreiber: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5276
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2921ad93b2b10de935ae98ef8bc5815e5aa4ecee
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months