Change in ovirt-engine[master]: webadmin: display SD status Templates-Storage
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: display SD status Templates-Storage
......................................................................
webadmin: display SD status Templates-Storage
https://bugzilla.redhat.com/819307
Display StorageDomainSharedStatus instead of
StorageDomainStatus in Templates -> Storage sub-tab
Change-Id: I653f0cd2cba13d255f6cbf2850d597eb0e02a940
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/template/StoragesTree.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5394
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I653f0cd2cba13d255f6cbf2850d597eb0e02a940
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: user level queries - filtered entities
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: user level queries - filtered entities
......................................................................
core: user level queries - filtered entities
This patch enables to filter data vertically in addition to the
horizontal filtering support.
Up to now, we had filtered some SPs that are accessible by users
horizontally (i.e. returning part of the resulted query rows by adding
a where clause)
Now, we will enable to filter those SPs returned data also vertically
(i.e set NULL as the value of some columns in the returned result set)
This is done by:
1) Adding a table called object_column_white_list that holds for each relevant
table/view for which we want to show, other columns are filtered vertically,
the column names that should have NULL values in the returned result.
The script adding this table and inserting its initial data is reentrant
and run the in pre-upgrade step.
A second table object_column_white_list_sql stores the generated sql per
object. This sql is cleaned upon upgrade to reflect schema changes since
if a column was added to an object that is already participating in
vertical filtering, this column will be automatically filtered out
unless added specifically in the
upgrade/pre_upgrade/add_object_column_white_list_table.sql script.
2) A function fn_db_mask_object that accepts the object to filter and
returns the result with filtered column values.
3) a function to add new object columns to the white list
fn_db_add_column_to_object_white_list
Currently, we have only 2 user queries that returns the Power Management
details and can be accessed by users. The SPs that are executed by those
queries were modified to add a vertical filter on top of the existing
horizontal one.
This can be easily expanded to other queries by adding the relevant
meta data in the pre_upgrade/add_object_column_white_list_table.sql script and
modify the relevant SPs to filter data vertically.
Change insures that admin portal is not affected by this change, so any
query running from admin portal will run natively without any change.
Vertical filtering takes place when the v_is_filtered flag passed to the
SP is true.
The work in building the SQL is done once per object so it will not
affect performance for users as well.
Change-Id: If68b290aaacc0eea5d117ef64536cbf94d195cee
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/dbscripts/common_sp.sql
A backend/manager/dbscripts/upgrade/pre_upgrade/add_object_column_white_list_table.sql
M backend/manager/dbscripts/vds_sp.sql
3 files changed, 158 insertions(+), 21 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If68b290aaacc0eea5d117ef64536cbf94d195cee
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: NFS options expander
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: NFS options expander
......................................................................
webadmin: NFS options expander
Change-Id: Ibb11fc6aff471f6c526e8c53745275c6a9539739
Signed-off-by: Alexey Chub <achub(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.ui.xml
7 files changed, 142 insertions(+), 82 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5279
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb11fc6aff471f6c526e8c53745275c6a9539739
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexey Chub <achub(a)redhat.com>
Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: display tool-tip for disabled editors
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: display tool-tip for disabled editors
......................................................................
webadmin: display tool-tip for disabled editors
Display 'Model -> getChangeProhibitionReasons()'
as a tool-tip when applicable:
* 'UiCommonEditorVisitor -> onIsChangablePropertyChange',
passing to 'setEnabled' the 'changeProhibitionReasons' string list
* 'AbstractValidatedWidgetWithLabel -> setEnabled',
set widget's title with the first hint string
(similar to 'AbstractValidatedWidget -> markAsInvalid').
[we might want to extend it to a 'multi disability hints
tool-tip later on]
Change-Id: Id74f1f082219fbd4d0042ec08f926b8861500745
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/UiCommonEditorVisitor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/HasEnabled.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/WidgetWithLabelEditor.java
4 files changed, 60 insertions(+), 4 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5163
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id74f1f082219fbd4d0042ec08f926b8861500745
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: Limit new block device disk size to 8TB
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Limit new block device disk size to 8TB
......................................................................
webadmin: Limit new block device disk size to 8TB
* Block device disk size should be limited to 8TB
* File level disk size should not be limited
(the maximal size is reflected by the underlining file system,
which is not known by the VDSM).
Change-Id: Ia9e9e95e60460ba49399c5d9eccafef90b22df05
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java
3 files changed, 14 insertions(+), 15 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5296
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9e9e95e60460ba49399c5d9eccafef90b22df05
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Limit new block device disk size to 8TB
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: Limit new block device disk size to 8TB
......................................................................
core: Limit new block device disk size to 8TB
https://bugzilla.redhat.com/823437
* New block device disk size should be limited to 8TB
* File level disk size should not be limited
(the maximal size is reflected by the underlining file system,
which is not known by the VDSM).
Change-Id: I5730004f09120ef3866afbb2e1c61144f5fa2b51
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
5 files changed, 16 insertions(+), 8 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5295
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5730004f09120ef3866afbb2e1c61144f5fa2b51
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: text: fix Vnc to VNC
by ecohen＠redhat.com
Einav Cohen has submitted this change and it was merged.
Change subject: text: fix Vnc to VNC
......................................................................
text: fix Vnc to VNC
VNC is used when visible to user.
this patch fixes a few places which used Vnc incorrectly
Change-Id: Ib2be487cf7d6d380af4472514f096cd8d0addfd4
Signed-off-by: Itamar Heim <iheim(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
5 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Einav Cohen: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5388
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2be487cf7d6d380af4472514f096cd8d0addfd4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: remove an old postgres conversion script
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: remove an old postgres conversion script
......................................................................
remove an old postgres conversion script
this nostalgic (and hacky) script was used to auto change the java code to work with postgres while converting to it from ms-sql.
no longer relevant
Change-Id: I7a788b04ec08ee9ae73d1b7195f96f5acb269d53
Signed-off-by: Itamar Heim <iheim(a)redhat.com>
---
D backend/manager/dbscripts/postgres_seds.sh
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5363
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a788b04ec08ee9ae73d1b7195f96f5acb269d53
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: restapi: non admin user api - Filtering Storage Domains (#78...
by asaf＠redhat.com
Asaf Shakarchi has submitted this change and it was merged.
Change subject: restapi: non admin user api - Filtering Storage Domains (#783087)
......................................................................
restapi: non admin user api - Filtering Storage Domains (#783087)
https://bugzilla.redhat.com/783087
- Support for filtering Storage Domain(s) when 'filter' header set to true
when accessing /api/storagedomains & /api/storagedomains/{id} urls.
- Added the 'filter' header to the rsdl metadata file in the appropriate names.
Change-Id: I3369d42f8d1b421280e0f3dd90fd228afd1faba5
Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java
2 files changed, 8 insertions(+), 3 deletions(-)
Approvals:
Asaf Shakarchi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3369d42f8d1b421280e0f3dd90fd228afd1faba5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: CustomPublicConfig_AppsWebSite should be empty by default
by ecohen＠redhat.com
Einav Cohen has submitted this change and it was merged.
Change subject: CustomPublicConfig_AppsWebSite should be empty by default
......................................................................
CustomPublicConfig_AppsWebSite should be empty by default
Change-Id: Ice0daec27705905a9cc4949e2292e9e13d39e8d3
Signed-off-by: Itamar Heim <iheim(a)redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Einav Cohen: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5364
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice0daec27705905a9cc4949e2292e9e13d39e8d3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
12 years, 7 months