June 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: cluster selection handling in volume dialog
by gchaplik＠redhat.com 12 Jun '12

12 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: cluster selection handling in volume dialog ...................................................................... webadmin: cluster selection handling in volume dialog User can change the selected cluster after adding the bricks in the create volume dialog. The brick list will be cleared whenever the user selects a different cluster. Change-Id: Ia964bf27cc1ddf8f101a728ac25aa2dfa48250c1 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumePopupView.java 2 files changed, 5 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia964bf27cc1ddf8f101a728ac25aa2dfa48250c1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Formatting the message in Error Popup
by gchaplik＠redhat.com 12 Jun '12

12 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Formatting the message in Error Popup ...................................................................... webadmin: Formatting the message in Error Popup Before showing the error message in the popup, all the new lines(\n) will be replaced with <br/> tag. Change-Id: I468c1e43f6f174c38bcf3d0193f2a3e56c90778b Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ErrorPopupView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I468c1e43f6f174c38bcf3d0193f2a3e56c90778b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Showing multiple transport type in volume (#830493...
by gchaplik＠redhat.com 12 Jun '12

12 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Showing multiple transport type in volume (#830493) ...................................................................... webadmin: Showing multiple transport type in volume (#830493) https://bugzilla.redhat.com/830493 As a gluster volume can have multiple transport types, now the UI will show the mutiple transport types with comma separated. Change-Id: I7b297b220e6cb5be9c3a0686a0d454d583df9eb8 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java 2 files changed, 31 insertions(+), 8 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5237 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b297b220e6cb5be9c3a0686a0d454d583df9eb8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Gluster Volume - Stop, Remove messages changed(#829...
by gchaplik＠redhat.com 12 Jun '12

12 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Gluster Volume - Stop,Remove messages changed(#829748) ...................................................................... webadmin: Gluster Volume - Stop,Remove messages changed(#829748) https://bugzilla.redhat.com/829748 A NOTE will be shown in the bottom of the confirmation dialog about the effect on executing the action. Change-Id: I34a61872d0e33079b573c138735cc7daa948490a Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java 3 files changed, 11 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34a61872d0e33079b573c138735cc7daa948490a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Gluster volume - add, remove bricks validation
by gchaplik＠redhat.com 12 Jun '12

12 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Gluster volume - add,remove bricks validation ...................................................................... webadmin: Gluster volume - add,remove bricks validation Validation of add/remove bricks changed as following. 1. While adding bricks, replica/stripe count can be increased by only one. 2. While removing bricks, replica count can be reduced by 1 and stripe count cannot be reduced Change-Id: I39af20b00ab4ee9247e0a6a337f76f24275308a8 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/RemoveBrickModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 6 files changed, 340 insertions(+), 19 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39af20b00ab4ee9247e0a6a337f76f24275308a8 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: fix create VM from template
by gchaplik＠redhat.com 12 Jun '12

12 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: fix create VM from template ...................................................................... webadmin: fix create VM from template the ui BL used the disk imageId instead of disk id, changed because of backend refactoring Change-Id: I385f5a062edaf9eed85194da02dd7340d5bccf7c Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I385f5a062edaf9eed85194da02dd7340d5bccf7c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: simplify ValidationResult
by lhornyak＠redhat.com 12 Jun '12

12 Jun '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: simplify ValidationResult ...................................................................... core: simplify ValidationResult - since the field 'valid' is always false if 'message' is null and always true when not null, it is redundant. It is deleted. - message field never changes, can be final - class marked as final to make it fully immutable Change-Id: I848ce2bd35bd97549348e7ef1a07297b0a66aa10 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java 1 file changed, 7 insertions(+), 9 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I848ce2bd35bd97549348e7ef1a07297b0a66aa10 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: OVF writer should not depend on LANG setting
by oourfali＠redhat.com 12 Jun '12

12 Jun '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: OVF writer should not depend on LANG setting ...................................................................... core: OVF writer should not depend on LANG setting The XML writer used to write OVF doesn't specify the character encoding when creating files. As a result the system selects the encoding according to the setting of the LANG variable. This will usually result in selecting UTF-8, but if it happens to be ASCII the StAX writer will fail and complain that the header of the XML document doesn't match the encoding of the string. This patch changes the XML writer so that it always uses the UTF-8 encoding, regardless of the LANG setting. Change-Id: I2d3f1693cb0f1c2490360350936a4bff09549e72 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlTextWriter.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5289 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d3f1693cb0f1c2490360350936a4bff09549e72 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: Change messages for Power Management alert
by shavivi＠redhat.com 12 Jun '12

12 Jun '12

Shahar Havivi has submitted this change and it was merged. Change subject: Change messages for Power Management alert ...................................................................... Change messages for Power Management alert Change-Id: Ia8f23f20aa7e389b273b6aa5193d490fef786320 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8f23f20aa7e389b273b6aa5193d490fef786320 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: When can not take VM from pool, UP throws an exc...
by vszocs＠redhat.com 12 Jun '12

12 Jun '12

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal: When can not take VM from pool, UP throws an exception ...................................................................... userportal: When can not take VM from pool, UP throws an exception When tring to take a VM from a pool, but it did not succeeded (e.g. because there are no available VMs in the pool), than the UP throws an UnsupportedOperationException, the model gets in incorrect state and the UP is not functional any more. The problem was, that the PoolItemBehaviour.TakeVm() was not checking the result of the AttachUserToVmFromPoolAndRun callback and tried to work with the taken VM immediately. Because the taking of the VM failed, the VM was null and the UserPoralItemModel.OnEntityChanged() did throw an UnsupportedOperationException. Solved by adding a check if the operation succeeded to the PoolItemBehaviour.TakeVm() and continue only if yes. Change-Id: If110f01cf2abcd8866ac970b6ac4dabf2df7c4cc Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/PoolItemBehavior.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4888 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If110f01cf2abcd8866ac970b6ac4dabf2df7c4cc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0