June 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: restapi fix
by lhornyak＠redhat.com 13 Jun '12

13 Jun '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: restapi fix ...................................................................... core: restapi fix Since the map's key type is String, the original code will always evaluate to false, because the map.containsKey is invoked with a TypeVariable. Change-Id: Ib790a9c64a0cc533ad36842903c7481531a8f5c7 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib790a9c64a0cc533ad36842903c7481531a8f5c7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: audit log for failed login users
by oourfali＠redhat.com 13 Jun '12

13 Jun '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: audit log for failed login users ...................................................................... core: audit log for failed login users Introducing new audit log types for logging events in case a user fails to authenticate due to account that is locked or disabled, or in case the password got expired for the user. In order to prevent event log flooding due to login retries per a given user, the event will be logged only once per hour. Change-Id: I7b99d86a329512ffaeff3c73ed1701b1212889a9 Acked-by: Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/GSSAPIDirContextAuthenticationStrategy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/AuthenticationResult.java 5 files changed, 34 insertions(+), 3 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b99d86a329512ffaeff3c73ed1701b1212889a9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Missing RemoveDisk enum to LocalizedEnums
by mkublin＠redhat.com 13 Jun '12

13 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: webadmin: Missing RemoveDisk enum to LocalizedEnums ...................................................................... webadmin: Missing RemoveDisk enum to LocalizedEnums * Adding missing 'RemoveDisk' signature to LocalizedEnums. * Removing redundant 'RemoveDiskFromVm' and 'RemoveDisksFromVm'. Change-Id: Ie17a2ee99421b49d5ba0510a3bb79616ad5f8ace Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 2 files changed, 2 insertions(+), 5 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie17a2ee99421b49d5ba0510a3bb79616ad5f8ace Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Set Spice & VNC console models to use different qu...
by tnisan＠redhat.com 13 Jun '12

13 Jun '12

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Set Spice & VNC console models to use different query ...................................................................... webadmin: Set Spice & VNC console models to use different query Spice & VNC models used get GetVdsInterfacesByVdsId to get all interfaces and iterate on them to find the management interface and then used the address for the connection, now they use the GetManagementInterfaceAddressByVdsId query to get the management interface address directly Change-Id: Ie73fffcc684f4230e11eadb2e61f126e57d84ab4 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java 2 files changed, 30 insertions(+), 62 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4855 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie73fffcc684f4230e11eadb2e61f126e57d84ab4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Added GetManagementInterfaceAddressByVdsId query
by tnisan＠redhat.com 13 Jun '12

13 Jun '12

Tal Nisan has submitted this change and it was merged. Change subject: core: Added GetManagementInterfaceAddressByVdsId query ...................................................................... core: Added GetManagementInterfaceAddressByVdsId query Added a query to retrieve a host management interface ip by the vds guid, used mainly for User Portal Spice console connection Change-Id: Ic6d855734c6cdec937de6ec91d1c80a23333eec8 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/dbscripts/network_sp.sql A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetManagementInterfaceAddressByVdsIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/InterfaceDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/InterfaceDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/InterfaceDAOTest.java 6 files changed, 135 insertions(+), 35 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4854 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6d855734c6cdec937de6ec91d1c80a23333eec8 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: fix typo ImportVmTemplateParameters
by gchaplik＠redhat.com 13 Jun '12

13 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: fix typo ImportVmTemplateParameters ...................................................................... engine: fix typo ImportVmTemplateParameters ImprotVmTemplateParameters to ImportVmTemplateParameters Change-Id: Idfe72db145a6270f818d2405d6efd50a891d2098 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmTemplateCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TestHelperImportVmTemplateCommand.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmTemplateParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResourceTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java 7 files changed, 25 insertions(+), 25 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfe72db145a6270f818d2405d6efd50a891d2098 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: webadmin: import more than once - validate new name
by gchaplik＠redhat.com 13 Jun '12

13 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: import more than once - validate new name ...................................................................... webadmin: import more than once - validate new name in case importing as cloned, a new name is given (old name + suffix), this name ought to be validated Change-Id: I973d301e3880fb5977c495f8ac137d00775d4e14 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 3 files changed, 75 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5221 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I973d301e3880fb5977c495f8ac137d00775d4e14 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: import more than once - validate new name
by gchaplik＠redhat.com 13 Jun '12

13 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: import more than once - validate new name ...................................................................... core: import more than once - validate new name in case importing as cloned, a new name is given (old name + suffix), this name ought to be validated Change-Id: I7ec3341e862bcceac3446f28dc8def9d20e28e13 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmTemplateCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImprotVmTemplateParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/group/ImportClonedEntity.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/group/ImportEntity.java 10 files changed, 208 insertions(+), 4 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5220 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ec3341e862bcceac3446f28dc8def9d20e28e13 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove dependency on org.jboss.interceptor
by oourfali＠redhat.com 13 Jun '12

13 Jun '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: Remove dependency on org.jboss.interceptor ...................................................................... core: Remove dependency on org.jboss.interceptor This module will be removed from the application server starting with version 7.1.2. Change-Id: Iae16a1095b2b788053b9d22aae4ba95e16bbe4d9 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5277 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae16a1095b2b788053b9d22aae4ba95e16bbe4d9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removing @Remote annotattion from Backend bean
by mkublin＠redhat.com 13 Jun '12

13 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Removing @Remote annotattion from Backend bean ...................................................................... core: Removing @Remote annotattion from Backend bean Removing @Remote annottation form Backend bean, because of we don't need to perform a remote lookup Change-Id: Ic6d41f23dd53f0700285aa50c446bba4589e7b27 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BackendRemote.java D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/IntegrationTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/BeanProxyType.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/EJBUtilsStrategy.java 5 files changed, 2 insertions(+), 109 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5302 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6d41f23dd53f0700285aa50c446bba4589e7b27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0