June 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal: design improvements
by vszocs＠redhat.com 12 Jun '12

12 Jun '12

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal: design improvements ...................................................................... userportal: design improvements includes: - the action buttons on the template side tab and VM side tab where hidden, when was a scroll bar scrolled down (e.g. the action buttons were scrolled out). Solved by creating a new UserPortalSimpleActionTable which sets up the styles specially for user portal - styling of the splitter on the extended view. It required to create a new ExtendedViewSplitLayoutPanel the same way as the BasicViewSplitLayoutPanel while the common functionality extracted to common parent class UserPortalSplitLayoutPanel - Added padding around the extended view details panels. - Styling of the main tab buttons to look the same as in the old user portal Change-Id: I2256032e1a903ddc9d974289cf8000cdd80bc54f Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResources.java A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/SideTabWithDetailsViewStyle.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/AbstractSideTabWithDetailsView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/HeaderView.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedTemplateView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/UserPortalSplitLayoutPanel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/BasicViewSplitLayoutPanel.java A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/extended/ExtendedViewSplitLayoutPanel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/tab/HeadlessTabPanel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/tab/SimpleTabPanel.ui.xml A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/tab/UserPortalMainTab.java A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/tab/UserPortalMainTab.ui.xml A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/column/UserPortalSimpleActionTable.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/css/ExtendedTemplateListTable.css M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/css/ExtendedVmListTable.css A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/css/SideTabWithDetailsViewStyle.css A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/images/splitter/extendedViewSplitterSnap.png 19 files changed, 365 insertions(+), 54 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2256032e1a903ddc9d974289cf8000cdd80bc54f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: [rmd] remove RefObject usage from VdsSelector
by mkolesni＠redhat.com 12 Jun '12

12 Jun '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: [rmd] remove RefObject usage from VdsSelector ...................................................................... core: [rmd] remove RefObject usage from VdsSelector remove RefObject from VdsSelector Change-Id: Iba063e42ded77b8f7c008cb4878d3c27f440f167 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java 1 file changed, 11 insertions(+), 27 deletions(-) Approvals: Laszlo Hornyak: Verified Mike Kolesnik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba063e42ded77b8f7c008cb4878d3c27f440f167 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: change default USB policy to DISABLED in VmBase
by oourfali＠redhat.com 12 Jun '12

12 Jun '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: change default USB policy to DISABLED in VmBase ...................................................................... core: change default USB policy to DISABLED in VmBase This patch changes the default for the USB policy to DISABLED, as it no longer needs to be enabled by default. Change-Id: Id481ed9d200febc84b4967a6c43510d432c8ab96 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id481ed9d200febc84b4967a6c43510d432c8ab96 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Change VLAN being sent as bond (#826401)
by mkolesni＠redhat.com 12 Jun '12

12 Jun '12

Mike Kolesnik has submitted this change and it was merged. Change subject: webadmin: Change VLAN being sent as bond (#826401) ...................................................................... webadmin: Change VLAN being sent as bond (#826401) https://bugzilla.redhat.com/826401 In setup networks, the VLAN over bond was being sent as bond, but it shouldn't be sent this way since engine can't know if the interface represents a bond or a VLAN. Change-Id: Ida00d31f8461c92c078bd4c3545d9e5abdb446eb Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5181 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida00d31f8461c92c078bd4c3545d9e5abdb446eb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Enable VLAN & no network over bond (#826401)
by mkolesni＠redhat.com 12 Jun '12

12 Jun '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Enable VLAN & no network over bond (#826401) ...................................................................... core: Enable VLAN & no network over bond (#826401) https://bugzilla.redhat.com/826401 Removed check for network name over bond, and added check that bond exists if adding VLAN over the bond. This enables to request to create bond with no network from engine side. Added tests to verify that this behaves as expected. Change-Id: I03457629327e6b0f9b3c9e575f8ad76bd8f9e62f Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java 2 files changed, 142 insertions(+), 14 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03457629327e6b0f9b3c9e575f8ad76bd8f9e62f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Improve SetupNetworksVDSCommandTest
by mkolesni＠redhat.com 12 Jun '12

12 Jun '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Improve SetupNetworksVDSCommandTest ...................................................................... core: Improve SetupNetworksVDSCommandTest Refactored tests to keep them DRY. Also added tests for VLAN over NIC/bond. Change-Id: I5f24f5236c91845452c6d3b6c6716cca6a4f0af6 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java 1 file changed, 146 insertions(+), 42 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5232 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f24f5236c91845452c6d3b6c6716cca6a4f0af6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix VLAN base iface type being sent to host
by mkolesni＠redhat.com 12 Jun '12

12 Jun '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Fix VLAN base iface type being sent to host ...................................................................... core: Fix VLAN base iface type being sent to host If VLAN is sent over NIC/Bond then the key sent to the host in the network map should be determined by the base iface that the VLAN is defined on. Change-Id: I315acf3275cd7f6bf981777bb40ad04bdde3aace Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java 1 file changed, 18 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5231 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I315acf3275cd7f6bf981777bb40ad04bdde3aace Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: removal of RefObject use in HostListModel
by lhornyak＠redhat.com 12 Jun '12

12 Jun '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: removal of RefObject use in HostListModel ...................................................................... core: removal of RefObject use in HostListModel removed from HostListModel the use of the deprecated RefObject. Change-Id: I70a315dfb6788ffbbe18ef7e6228c9fc1b728c1a Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M frontend/webadmin/modules/uicommon/src/main/java/org/ovirt/engine/ui/uicommon/models/hosts/HostListModel.java 1 file changed, 118 insertions(+), 116 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70a315dfb6788ffbbe18ef7e6228c9fc1b728c1a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removing GenericapiService bean from start up
by mkublin＠redhat.com 12 Jun '12

12 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Removing GenericapiService bean from start up ...................................................................... engine: Removing GenericapiService bean from start up GenericapiService bean is belongs to deprecated project, no need to load it during start up of jboss Motivation: performance Change-Id: I8fd7fd463bf9a490d3ce54d57767f28faadbd566 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M frontend/api/genericapi/src/main/java/org/ovirt/engine/ui/genericapi/GenericApiService.java 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5275 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fd7fd463bf9a490d3ce54d57767f28faadbd566 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: click on line in roster doesn't select desired lin...
by vszocs＠redhat.com 12 Jun '12

12 Jun '12

Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: click on line in roster doesn't select desired line (#806248) ...................................................................... webadmin: click on line in roster doesn't select desired line (#806248) https://bugzilla.redhat.com/806248 On many places (adding users, host-networks, etc) in webadmin has to be chosen check-box precisely. During mouse hover above line is that line properly coloured, but nothing happened when user want to click on it. There where two different widgets which had to be enriched by this behaviour: 1: EntityModelCellTable - responsible for adding new users. It has been solved by adding a CellPreviewHandler to the EntityModelCellTable which notifies the selection model that the selection should be changed. The support is implemented only for cases where the hideCheckbox is false, because the opposite scenario is used in special cases where the selection does not necessarily make sense (e.g. table headers, trees etc.). 2: HostInterfaceForm and it's panels - responsible for configuring network interfaces. It has been solved by adding click handler to the specific panels (InterfacePanel, BondPanel and VLanPanel) which which updates the model according to the selection. The TogglePanel than listens to this change event and updates the row coloring accordingly. Change-Id: I1b485e70e6319084f1764aeb72287ccb84cce511 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ModelBoundCheckBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/TogglePanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java 4 files changed, 57 insertions(+), 12 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b485e70e6319084f1764aeb72287ccb84cce511 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0