Change in ovirt-engine[master]: core: report properly RunVmOnce task completion (#818165)
by rgolan@redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: report properly RunVmOnce task completion (#818165)
......................................................................
core: report properly RunVmOnce task completion (#818165)
https://bugzilla.redhat.com/818165
Change-Id: I5d77377c3b1bb120d68ca1511263081f4a719eaa
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
2 files changed, 13 insertions(+), 1 deletion(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4992
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d77377c3b1bb120d68ca1511263081f4a719eaa
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Failed to create bond on 3.0 cluster (#827114)
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: Failed to create bond on 3.0 cluster (#827114)
......................................................................
core: Failed to create bond on 3.0 cluster (#827114)
https://bugzilla.redhat.com/827114
The patch fixes a NPE caused by accessing a network entity for the MTU
value, when it wasn't provided for the AddBondCommand (or other command
using that parameters class).
Change-Id: Iea96b848f5b16c1a62185410f255cdf1a7dfc69d
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/AddNetworkVDSCommand.java
1 file changed, 8 insertions(+), 6 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5038
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea96b848f5b16c1a62185410f255cdf1a7dfc69d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Failed to create bond on 3.0 cluster (#827114)
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Failed to create bond on 3.0 cluster (#827114)
......................................................................
core: Failed to create bond on 3.0 cluster (#827114)
https://bugzilla.redhat.com/827114
The patch fixes a NPE caused by accessing a network entity for the MTU
value, when it wasn't provided for the AddBondCommand (or other command
using that parameters class).
Change-Id: I9d545f039cf0a9687ed3818086a50cbc39f7d861
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/EditNetworkVDSCommand.java
1 file changed, 8 insertions(+), 7 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4960
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d545f039cf0a9687ed3818086a50cbc39f7d861
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Code cleanup for network parameters class
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Code cleanup for network parameters class
......................................................................
core: Code cleanup for network parameters class
Handling class organization and properties name for 3.0 network
parameters classes.
Change-Id: I1cd93595509d9eacc89215dca1e3817d2ab91cbe
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachNetworkToVdsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateNetworkToVdsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/NetworkVdsmVDSCommandParameters.java
3 files changed, 235 insertions(+), 253 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4959
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1cd93595509d9eacc89215dca1e3817d2ab91cbe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
12 years, 7 months
Change in ovirt-engine[master]: restapi: non admin user api - Filtering user queries (#78308...
by asaf@redhat.com
Asaf Shakarchi has submitted this change and it was merged.
Change subject: restapi: non admin user api - Filtering user queries (#783087)
......................................................................
restapi: non admin user api - Filtering user queries (#783087)
https://bugzilla.redhat.com/783087
- A global support for filtering content based on user permissions for all
query executions based on the 'filter' HTTP header.
Note: The 'filter' attribute header is stateless and must be specified by the client per HTTP request.
- Added a unit test for BackendResourceTest currently for testing the 'filter' HTTP header.
- Abstracted base test class from resource centric base test class
- Changed TestHelper.getMethod to seek for 'isMethod()' if 'getMethod()' wasn't found.
Change-Id: I8e5e23cbb8e883f6005f69be46fa528ac6e7518c
Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java
7 files changed, 490 insertions(+), 387 deletions(-)
Approvals:
Asaf Shakarchi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4360
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e5e23cbb8e883f6005f69be46fa528ac6e7518c
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: packaging: Updated error message for preallocated http port ...
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Updated error message for preallocated http port (#813688)
......................................................................
packaging: Updated error message for preallocated http port (#813688)
https://bugzilla.redhat.com/show_bug.cgi?id=813688
* Updated an error message that is shown when a user selects
an http port that is already preallocated in selinux.
Change-Id: Id8cbfa82b0b939e6b79a955568a211c2fc6a06a3
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/fedora/setup/engine_validators.py
M packaging/fedora/setup/output_messages.py
2 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
Alex Lourie: Verified; Looks good to me, but someone else must approve
Ofer Schreiber: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8cbfa82b0b939e6b79a955568a211c2fc6a06a3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: packaging: Added the ability to get y/n for answers (#733292...
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Added the ability to get y/n for answers (#733292)
......................................................................
packaging: Added the ability to get y/n for answers (#733292)
https://bugzilla.redhat.com/show_bug.cgi?id=733292
* Added the feature to the setup to get "y" and "n"
as valid answers to "yes"/"no" questions.
Change-Id: Id33694030d2bf88111394185005653cc5b96faa8
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/fedora/setup/engine-setup.py
M packaging/fedora/setup/engine_validators.py
2 files changed, 8 insertions(+), 0 deletions(-)
Approvals:
Alex Lourie: Verified; Looks good to me, but someone else must approve
Ofer Schreiber: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4904
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id33694030d2bf88111394185005653cc5b96faa8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: packaging: Renamed 'rhevm' to 'ovirt-engine' in iptables (#7...
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Renamed 'rhevm' to 'ovirt-engine' in iptables (#773583)
......................................................................
packaging: Renamed 'rhevm' to 'ovirt-engine' in iptables (#773583)
https://bugzilla.redhat.com/show_bug.cgi?id=773583
* Renamed 'rhevm-installer' to "ovirt-engine installer" in
iptables.default template.
Change-Id: Ifa0bad148c4a4861598829ca53b5c08cfe3e62cb
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/fedora/setup/iptables.default
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4908
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa0bad148c4a4861598829ca53b5c08cfe3e62cb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: Gluster Volume - events tab issues fixed
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Gluster Volume - events tab issues fixed
......................................................................
webadmin: Gluster Volume - events tab issues fixed
Events sub tab in Gluster volume was not showing the
events of the selected volume. This issue is now fixed.
Change-Id: Iac221552fcc08144c109284c249a735a74b80a77
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/gluster/SubTabVolumeEventPresenter.java
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5028
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac221552fcc08144c109284c249a735a74b80a77
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: oVirt Modes - hide CPU, Version in cluster
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: oVirt Modes - hide CPU, Version in cluster
......................................................................
webadmin: oVirt Modes - hide CPU, Version in cluster
CPU and Compatibility version in Cluster dialog
will be hidden in GlusterOnly mode.
Change-Id: Ieb447cc9e9e7f42c7d1d56fe0393e049f5440611
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5026
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb447cc9e9e7f42c7d1d56fe0393e049f5440611
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 7 months