July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: remove disk dialog - unchecked latch by default
by tnisan＠redhat.com 10 Jul '12

10 Jul '12

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: remove disk dialog - unchecked latch by default ...................................................................... webadmin: remove disk dialog - unchecked latch by default VMs main-tab -> Disks sub-tab: 'Remove permanently' latch - unchecked by default Change-Id: I147c47e5cf92324a1923e59f82b59ff9f95f9e1d Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I147c47e5cf92324a1923e59f82b59ff9f95f9e1d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: ctrl+alt+del for spice enabled by default
by derez＠redhat.com 10 Jul '12

10 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: userportal: ctrl+alt+del for spice enabled by default ...................................................................... userportal: ctrl+alt+del for spice enabled by default The "Pass Ctrl-Alt-Del to virtual machine" was by default disabled. Changed to be enabled. On the client OS Windows 7 or newer (e.g. NT version 6.1 or higher) it is not possible to take the ctrl+alt+del from the OS, so this checkbox is not editable. Change-Id: Ia825023360d0b64f7242406200e4565e01ddefe5 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceInterfaceImpl.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/console/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/console/ConsolePopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/ConsoleUtils.java 5 files changed, 74 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia825023360d0b64f7242406200e4565e01ddefe5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: support adding disk while VM is UP
by derez＠redhat.com 10 Jul '12

10 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: core: support adding disk while VM is UP ...................................................................... core: support adding disk while VM is UP http://bugzilla.redhat.com/838604 Adding a support for adding a disk while VM is UP. Change-Id: I475ab7ccc2e1a016aa1909f9b60bf2c4c9f3b11a Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I475ab7ccc2e1a016aa1909f9b60bf2c4c9f3b11a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: build: do not override MAVEN_OPTS
by dfediuck＠redhat.com 10 Jul '12

10 Jul '12

Doron Fediuck has submitted this change and it was merged. Change subject: build: do not override MAVEN_OPTS ...................................................................... build: do not override MAVEN_OPTS User should be able to set MAVEN_OPTS with some maven options to affect all build steps. Makefile should use MAVEN_OPTS by appending options, not override it entirely to allow customization. Change-Id: I541cfe03548640814b6fc241eae3e1c07f663826 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I541cfe03548640814b6fc241eae3e1c07f663826 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Handle the new way to handle passwords in engine-...
by dfediuck＠redhat.com 10 Jul '12

10 Jul '12

Doron Fediuck has submitted this change and it was merged. Change subject: packaging: Handle the new way to handle passwords in engine-config ...................................................................... packaging: Handle the new way to handle passwords in engine-config The engine-config tool has been changed to require the use of temporary files when changing passwords. The setup tool needs to be changed accordingly. Change-Id: I2b18c6911f87b369561a7edbde2002bc1d7ce9df Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py 2 files changed, 76 insertions(+), 42 deletions(-) Approvals: Juan Hernandez: Verified Doron Fediuck: Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b18c6911f87b369561a7edbde2002bc1d7ce9df Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-dwh[master]: history: moved minimal etl version set to pre upgrade.
by ydary＠redhat.com 10 Jul '12

10 Jul '12

Yaniv Dary has submitted this change and it was merged. Change subject: history: moved minimal etl version set to pre upgrade. ...................................................................... history: moved minimal etl version set to pre upgrade. - This is because in 3.1 configuration changed are done in pre upgrade step. - Also changed minimal etl version to 3.1.0, since this is The current release. Change-Id: Ibe221debca3410aa156f68ae0f5b788277980e27 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- D data-warehouse/historydbscripts_postgres/upgrade/03_00_0010_add_history_db_minimal_etl_version.sql A data-warehouse/historydbscripts_postgres/upgrade/pre_upgrade/set_etl_minimal_version.sql 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5944 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe221debca3410aa156f68ae0f5b788277980e27 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: etl: removed last start time from vm stats
by ydary＠redhat.com 10 Jul '12

10 Jul '12

Yaniv Dary has submitted this change and it was merged. Change subject: etl: removed last start time from vm stats ...................................................................... etl: removed last start time from vm stats This column is not present in the 3.1 or 3.0 APIs and is not valuable for reporting. Change-Id: I3aa8ee13f8b09f45df13af0140ec07a587e803c4 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/aggregationtodaily_3_1/AggregationToDaily.java M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/aggregationtohourly_3_1/AggregationToHourly.java M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/statisticssync_3_1/StatisticsSync.java M data-warehouse/history_etl/tos_project/process/AggregationToDaily_3.1.item M data-warehouse/history_etl/tos_project/process/AggregationToDaily_3.1.properties M data-warehouse/history_etl/tos_project/process/AggregationToHourly_3.1.item M data-warehouse/history_etl/tos_project/process/AggregationToHourly_3.1.properties M data-warehouse/history_etl/tos_project/process/DailyTimeKeepingJob_3.1.properties M data-warehouse/history_etl/tos_project/process/DeleteTimeKeepingJob_3.1.properties M data-warehouse/history_etl/tos_project/process/HostConfigCheck_3.1.properties M data-warehouse/history_etl/tos_project/process/HourlyTimeKeepingJob_3.1.properties M data-warehouse/history_etl/tos_project/process/MinimalVersionCheck_3.1.properties M data-warehouse/history_etl/tos_project/process/ParallelRun_3.1.properties M data-warehouse/history_etl/tos_project/process/SampleRunJobs_3.1.properties M data-warehouse/history_etl/tos_project/process/StatisticsSync_3.1.item M data-warehouse/history_etl/tos_project/process/StatisticsSync_3.1.properties M data-warehouse/history_etl/tos_project/talend.project A data-warehouse/historydbscripts_postgres/upgrade/03_00_0130_remove_unused_columns.sql 18 files changed, 539 insertions(+), 1,242 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3aa8ee13f8b09f45df13af0140ec07a587e803c4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removing very bad code
by mkublin＠redhat.com 10 Jul '12

10 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Removing very bad code ...................................................................... core: Removing very bad code I will not explain why I removed a following code, I think it obvious, but I will provide an issues which were solved only by small clean up: 1. Using a wrong API at IrsBrokerCommand, instead of doing some logic a log message was written 2. Removed unneeded ejb look ups at *VDSCommand, small performance improvement 3. Removed statless been cache - should improve so many things: performance, memory, reduce load on jboss, etc... (By the way in java 1.4 sometimes was used J2EE pattern for caching statefull bean but statless) Change-Id: I5420f7446c8e2b0d082e2ca6f1a0c54432321fd0 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VDSBrokerFrontendImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResumeVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 7 files changed, 30 insertions(+), 181 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5420f7446c8e2b0d082e2ca6f1a0c54432321fd0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: GWT localization interface cleanup
by ecohen＠redhat.com 10 Jul '12

10 Jul '12

Einav Cohen has submitted this change and it was merged. Change subject: webadmin,userportal: GWT localization interface cleanup ...................................................................... webadmin,userportal: GWT localization interface cleanup To make oVirt UI translation process as simple as possible, we should centralize all constant/message declarations into few well-defined GWT localization interfaces. This includes: - CommonApplicationConstants/Messages for gwt-common - ApplicationConstants for WebAdmin and UserPortal In other words, we should avoid creating context-specific localization interfaces, as this will add more properties files for translators to manage. This patch performs following cleanup: 1. Removed FeatureNotImplementedYetPopup's PopupConstants interface, with its methods moved to CommonApplicationConstants 2. Removed MainTabBasicListItemMessages interface, with its methods moved to UserPortal ApplicationConstants Change-Id: Ibb1dbd808bad447aa53fec782dfaaa410b92451a Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/FeatureNotImplementedYetPopup.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/SystemModule.java D frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemMessages.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemView.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/MainTabBasicListItemMessagesTranslator.java 8 files changed, 109 insertions(+), 119 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb1dbd808bad447aa53fec782dfaaa410b92451a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: Clean gen directory before GWT compilat...
by ecohen＠redhat.com 10 Jul '12

10 Jul '12

Einav Cohen has submitted this change and it was merged. Change subject: webadmin,userportal: Clean gen directory before GWT compilation ...................................................................... webadmin,userportal: Clean gen directory before GWT compilation WebAdmin and UserPortal POM files tell GWT compiler to generate normally-transient types for review into 'gen' directory. These files are particularly useful to understand what GWT deferred binding generators are producing during GWT compilation. This patch makes sure that the 'gen' directory is cleaned before each GWT compilation. Change-Id: I0295c12c7f9d119c57e5ae3f7d7c7d10e5596d61 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml 3 files changed, 21 insertions(+), 3 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5847 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0295c12c7f9d119c57e5ae3f7d7c7d10e5596d61 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0