July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: remove StringUtils use from common and pom.xml
by rgolan＠redhat.com 31 Jul '12

31 Jul '12

Roy Golan has submitted this change and it was merged. Change subject: core: remove StringUtils use from common and pom.xml ...................................................................... core: remove StringUtils use from common and pom.xml Change-Id: Ia1906d83a162e8ed8a68ded62e33f88b401dcb28 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/pom.xml M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/users/VdcUser.java 2 files changed, 2 insertions(+), 6 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6777 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1906d83a162e8ed8a68ded62e33f88b401dcb28 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engin-setup - Drop DB before restore when upgrade...
by oschreib＠redhat.com 31 Jul '12

31 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engin-setup - Drop DB before restore when upgrade fails (BZ#844341) ...................................................................... packaging: engin-setup - Drop DB before restore when upgrade fails (BZ#844341) When the DB upgrade fails, the setup tries to restore the backed up DB. In a specific case, when the upgrade succeeded, but engine-config execution fails, the DB restore fails, since the DB already exists. This patch fixes the restore flow, by adding a call to db drop method. Also, it fixes the reason for the engine-config setup, and always configure the db connection string and password. Change-Id: Ic465815c683c0e4241f520960d4acc0dfa59f95a Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py 1 file changed, 12 insertions(+), 3 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic465815c683c0e4241f520960d4acc0dfa59f95a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Enable Setting Correlation-ID For Add Commands
by oliel＠redhat.com 31 Jul '12

31 Jul '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Enable Setting Correlation-ID For Add Commands ...................................................................... restapi: Enable Setting Correlation-ID For Add Commands Change-Id: I8075ef5da527fa1e55877ef64fb5b6aa8ee3bc2f Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResource.java 2 files changed, 2 insertions(+), 13 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6717 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8075ef5da527fa1e55877ef64fb5b6aa8ee3bc2f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: store the username owning the current spice session ti...
by rgolan＠redhat.com 30 Jul '12

30 Jul '12

Roy Golan has submitted this change and it was merged. Change subject: core: store the username owning the current spice session ticket ...................................................................... core: store the username owning the current spice session ticket when Setting a VM ticket for a spice session store the username owning it. Change-Id: Idbd763f6b7b20f7f791f1589102f080ef196ea59 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/dbscripts/vms_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java M backend/manager/modules/common/pom.xml M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/IVdcUser.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/users/VdcUser.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/users/VdcUserTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java 7 files changed, 47 insertions(+), 2 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idbd763f6b7b20f7f791f1589102f080ef196ea59 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: BZ#838276: vds_installer.py - force del deployUtil
by dfediuck＠redhat.com 30 Jul '12

30 Jul '12

Doron Fediuck has submitted this change and it was merged. Change subject: BZ#838276: vds_installer.py - force del deployUtil ...................................................................... BZ#838276: vds_installer.py - force del deployUtil Executing a host installation by REST API fails if deployUtil already exists. This patch will force remove deployUtil in case it already exists in the host. Change-Id: I2af79abccba8da92f812345a3a330953b792f781 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M backend/manager/conf/vds_installer.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6356 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2af79abccba8da92f812345a3a330953b792f781 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: del unnecessary port mirroring and activate
by derez＠redhat.com 30 Jul '12

30 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: del unnecessary port mirroring and activate ...................................................................... webadmin: del unnecessary port mirroring and activate https://bugzilla.redhat.com/834887 https://bugzilla.redhat.com/841219 port mirroring- should be just on webadmin vm nic (not template ands to user portal vm) activate- should be on vm nic (webadmin and user portal) not on template. Change-Id: Id3215fb8dfead4abcb2367c6d023ebe77f9afbfe Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/template/TemplateNetworkInterfacePopupWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/PresenterModule.java C frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/template/TemplateInterfacePopupPresenterWidget.java R frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/vm/VmInterfacePopupPresenterWidget.java A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/vm/VmNetworkInterfacePopupWidget.java D frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/networkinterface/NetworkInterfacePopupView.java A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/template/TemplateInterfacePopupView.java A frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmInterfacePopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/template/TemplateInterfaceListModelProvider.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/VmInterfaceListModelProvider.java 11 files changed, 97 insertions(+), 41 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3215fb8dfead4abcb2367c6d023ebe77f9afbfe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Ports 8006, 8007 and 8008 are not required
by oschreib＠redhat.com 30 Jul '12

30 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Ports 8006, 8007 and 8008 are not required ...................................................................... packaging: Ports 8006, 8007 and 8008 are not required The message presented by engine-setup when the installation finishes states that the ports 8006, 8007 and 8008 have to be open in the firewall, but we don't use them for anything currently. The only ports we need to open in the firewall are the HTTP and HTTPS ports, as selected by the user. Change-Id: I77be99f09e8b392c337739d5b88d028dbdc73e77 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/setup/output_messages.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77be99f09e8b392c337739d5b88d028dbdc73e77 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Disable HTTP and HTTPS when using Apache as proxy
by oschreib＠redhat.com 30 Jul '12

30 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Disable HTTP and HTTPS when using Apache as proxy ...................................................................... packaging: Disable HTTP and HTTPS when using Apache as proxy This patch changes the setup application and the JBoss configuration file so that the HTTP and HTTPS connectors will be completely disabled and only the AJP connector will be enabled if Apache is used as a proxy. On the other hand, if Apache is not used as a proxy the HTTP and HTTPS connectors will be enabled but the AJP connector will be disabled. This reduces the use of resources in the application server (thread pools) and reduces also the attack surface. It is convenient to be able to enable/disable the connectors at will after the installation. This can be done changing the /etc/sysconfig/ovirt-engine file, without running the setup again. For example, in order to enable the HTTP connector it is enough to add (or just uncomment) the following lines: ENGINE_HTTP_ENABLED=true ENGINE_HTTP_PORT=8080 Then restart the engine and the connector will be available. Same for the HTTPS and AJP connectors. Change-Id: I0d9443d18f1eee928a2fe594527ac0d59c14a5df Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/engine-service.py M packaging/fedora/engine-service.sysconfig M packaging/fedora/engine-service.xml.in M packaging/fedora/setup/engine-setup.py 4 files changed, 121 insertions(+), 69 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d9443d18f1eee928a2fe594527ac0d59c14a5df Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Refactor bridgeless network indication in VBOB
by masayag＠redhat.com 30 Jul '12

30 Jul '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Refactor bridgeless network indication in VBOB ...................................................................... core: Refactor bridgeless network indication in VBOB The patch extracts a method for evaluating if a given network is bridged or bridge-less so same logic could be used elsewhere. Change-Id: Ibc9fd626d168d00f5585ba6d3d3211acbcf3a7fd Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 14 insertions(+), 6 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6715 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc9fd626d168d00f5585ba6d3d3211acbcf3a7fd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Rename typo in method name of VBOB
by masayag＠redhat.com 30 Jul '12

30 Jul '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Rename typo in method name of VBOB ...................................................................... core: Rename typo in method name of VBOB A typo in method name was fixed and iterating over map is a proper way. Change-Id: I7d7acbbbd8afa9bea57af035a65cbc14440ac954 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6713 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d7acbbbd8afa9bea57af035a65cbc14440ac954 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0