July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Refactor networks handling in VBOB
by masayag＠redhat.com 30 Jul '12

30 Jul '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Refactor networks handling in VBOB ...................................................................... core: Refactor networks handling in VBOB The patch extracts the networks handling into a separate method. Change-Id: I10d84d5c5bf125b7595cfe6cc569160c7e1d6071 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 18 insertions(+), 11 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10d84d5c5bf125b7595cfe6cc569160c7e1d6071 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Refactor network bond data in VBOB
by masayag＠redhat.com 30 Jul '12

30 Jul '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Refactor network bond data in VBOB ...................................................................... core: Refactor network bond data in VBOB The patch extracts bond devices handling into a separate method. Change-Id: Icf83a939a4033de730b08051c1d9e3592d923dd8 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 44 insertions(+), 45 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf83a939a4033de730b08051c1d9e3592d923dd8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Refactor network vlan data in VBOB
by masayag＠redhat.com 30 Jul '12

30 Jul '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Refactor network vlan data in VBOB ...................................................................... core: Refactor network vlan data in VBOB The patch extracts the host vlan devices update into a method. Change-Id: Iafc5d6b63ba2f2234024db3907df91aadb09bb27 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 51 insertions(+), 36 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafc5d6b63ba2f2234024db3907df91aadb09bb27 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove use of XmlStruct as wrapper of Map
by masayag＠redhat.com 30 Jul '12

30 Jul '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Remove use of XmlStruct as wrapper of Map ...................................................................... core: Remove use of XmlStruct as wrapper of Map The patch removes the use of XmlStruct as a wrapper of Map. In addition, AddBootProtocol method name changed to lower case to meet java naming convention. Change-Id: I2bf77000a224e962217e0ac4b77e943a87aaf0fc Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 12 insertions(+), 14 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bf77000a224e962217e0ac4b77e943a87aaf0fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Modify the condition of detecting network type (#84298...
by masayag＠redhat.com 30 Jul '12

30 Jul '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Modify the condition of detecting network type (#842986) ...................................................................... core: Modify the condition of detecting network type (#842986) https://bugzilla.redhat.com/842986 The condition for updating the network information in interface is modified to rely on the bridged attribute rather on the interface property. Change-Id: Ia06581aa75dbd6719b1c0633e27c82e8d6995cc3 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 28 insertions(+), 29 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia06581aa75dbd6719b1c0633e27c82e8d6995cc3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Refactor network data update in VBOB
by masayag＠redhat.com 30 Jul '12

30 Jul '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Refactor network data update in VBOB ...................................................................... core: Refactor network data update in VBOB The patch pulls the update of of the host network interfaces into their owns method to shorten a lengthy method. Change-Id: I2433ba372c88c9382f6ef02b161114a41bfbc063 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 64 insertions(+), 38 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2433ba372c88c9382f6ef02b161114a41bfbc063 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: force update VM to down
by gchaplik＠redhat.com 30 Jul '12

30 Jul '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: force update VM to down ...................................................................... core: force update VM to down In case unlock VM is called, the action should be performed with no consideration to the vm that passes as a parameter. this vm may be cached. so we want to force update. if the command is called and in th vm in the DB is already down, that is another problem (why we called the method). Change-Id: I01cb0b7c939ee506d752b34dc0d7a16e46e36687 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 1 file changed, 5 insertions(+), 9 deletions(-) Approvals: Michael Kublin: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/6765 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01cb0b7c939ee506d752b34dc0d7a16e46e36687 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add quota to template disks
by gchaplik＠redhat.com 30 Jul '12

30 Jul '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: add quota to template disks ...................................................................... core: add quota to template disks when validating a quota on disks there is a bug in adding vmTemplate; the disk are iterated wrongfully on all images instead of disks thats causes a NPE Change-Id: I3661d1401247cfb26bba43c6b979116c485a33cd Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Michael Kublin: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/6764 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3661d1401247cfb26bba43c6b979116c485a33cd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixing AddVdsSpmId
by mkublin＠redhat.com 30 Jul '12

30 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Fixing AddVdsSpmId ...................................................................... core: Fixing AddVdsSpmId The following patch will allow to simintenious registration of couple vdsms at the same pool In order to do these will be used acquire and wait lock Change-Id: I7c12d4b9ac8cc756063ebbc09341fbd8e7d0f2ed Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6752 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c12d4b9ac8cc756063ebbc09341fbd8e7d0f2ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Changing and improving acquire and wait lock
by mkublin＠redhat.com 30 Jul '12

30 Jul '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Changing and improving acquire and wait lock ...................................................................... core: Changing and improving acquire and wait lock The following patch will change acquire and lock mechanism. The following mechanism will allow for command to wait for one exclusive lock. I am using only one exclusive lock in order to simplify a process , also with assumption that the acquire and lock mechanism should not use widely Change-Id: Id6fe46556eddad9bc2812320872fd3b99f7d2b7b Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LockIdNameAttribute.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lock/InMemoryLockManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/lock/EngineLock.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/lock/LockManager.java 6 files changed, 44 insertions(+), 17 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6fe46556eddad9bc2812320872fd3b99f7d2b7b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0