August 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Formatting- replace /tab/space/g
by dfediuck＠redhat.com 15 Aug '12

15 Aug '12

Doron Fediuck has submitted this change and it was merged. Change subject: webadmin: Formatting- replace /tab/space/g ...................................................................... webadmin: Formatting- replace /tab/space/g Turn tabs into spaces to comply with project policy. Change-Id: Ic54f4b3e6cb65687bfbd2abc50567ef2b639272f Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 1 file changed, 843 insertions(+), 845 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7210 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic54f4b3e6cb65687bfbd2abc50567ef2b639272f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add message when no host with network found on run vm
by ofrenkel＠redhat.com 15 Aug '12

15 Aug '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: add message when no host with network found on run vm ...................................................................... core: add message when no host with network found on run vm when running vm, there is a check when selection host to run, that the host has all the networks used by the vm. currently when this happens, the vm is just not run without any message. this patch adds a message in CanDoAction in addition, as done for other run failure reasons. Change-Id: I6f4066b80f0ec7db0b640fc818f833fdb387fdf8 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 22 insertions(+), 5 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7130 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f4066b80f0ec7db0b640fc818f833fdb387fdf8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin- Bond with unmanaged network(#840825)
by alkaplan＠redhat.com 15 Aug '12

15 Aug '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin- Bond with unmanaged network(#840825) ...................................................................... webadmin- Bond with unmanaged network(#840825) https://bugzilla.redhat.com/840825 when creating a bond- 1. nic + bond - 1.1 nic contains unmanaged networks- action blocked 1.2 bond contains unmanaged networks- action permitted 2. nic1 + nic2- nic1 or nic2 contains unmanaged networks- action blocked Change-Id: I95995e21e2c6b2ad5c8a1b224ecdd6ee2cebf084 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java 6 files changed, 82 insertions(+), 75 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95995e21e2c6b2ad5c8a1b224ecdd6ee2cebf084 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Change descriptions of LocalAdminPassword and AdminPassword
by iheim＠redhat.com 15 Aug '12

15 Aug '12

Itamar Heim has submitted this change and it was merged. Change subject: Change descriptions of LocalAdminPassword and AdminPassword ...................................................................... Change descriptions of LocalAdminPassword and AdminPassword The descriptions were misleading. Change-Id: Ic7e28c3138938404fb0f27c1cc060ec4fd632c8c Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/tools/engine-config/src/main/resources/engine-config.properties 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7126 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7e28c3138938404fb0f27c1cc060ec4fd632c8c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: build: sync packaging with engine
by ydary＠redhat.com 15 Aug '12

15 Aug '12

Yaniv Dary has submitted this change and it was merged. Change subject: build: sync packaging with engine ...................................................................... build: sync packaging with engine 1. Support branding. 2. Support rpmbuild -tb for tarball. 3. Accept file locations from spec file. 4. Handle pom artifacts per fedora requirements. 5. Probably more. Change-Id: Iaa13963a83f0e8a16fd775934e1d4cadd6e9629f Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com> --- A .gitignore M Makefile M data-warehouse/history_etl/etl_sources/advancedPersistentLookupLib/pom.xml M data-warehouse/history_etl/etl_sources/historyETLProcedure/pom.xml M data-warehouse/history_etl/etl_sources/talendRoutines/pom.xml M data-warehouse/history_etl/history_service/history_service.sh M packaging/ovirt-engine-dwh.spec.in M pom.xml 8 files changed, 279 insertions(+), 84 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa13963a83f0e8a16fd775934e1d4cadd6e9629f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: fixed problem with show deleted input control (#846...
by ydary＠redhat.com 15 Aug '12

15 Aug '12

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed problem with show deleted input control (#846627) ...................................................................... reports: fixed problem with show deleted input control (#846627) Was loading forever due to bad value passed when choosing to show deleted entities. https://bugzilla.redhat.com/846627 Change-Id: Ic6ef5c0fee8937be70a672f2e6ccd3e553f3907e Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Period_Affected/non-002dquery_IC/is_deleted.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_Hosts/active_hosts_select.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_Storage/active_storage.xml M reports/repository_files/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_VMs/Active_VMs.xml 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7203 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6ef5c0fee8937be70a672f2e6ccd3e553f3907e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Irregular behavior of checkbox in QuotaPopupView -...
by gchaplik＠redhat.com 15 Aug '12

15 Aug '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Irregular behavior of checkbox in QuotaPopupView -> QuotaStorageTable (#846267) ...................................................................... webadmin: Irregular behavior of checkbox in QuotaPopupView -> QuotaStorageTable (#846267) https://bugzilla.redhat.com/846267 Problem: In QuotaPopupView -> QuotaStorageTable the checkbox was not behaving as intended It would require two "clicks" to select or deselect it, resaulting in bad states Soulution: Changed the constructor call to CheckboxCell from (false, true) to (true, true) this flag is called "dependsOnSelection". internally the gwt code use it to indicate that the state of the checkbox should not be saved from the gwt code: /* * Save the new value. However, if the cell depends on the selection, then * do not save the value because we can get into an inconsistent state. */ if (value != isChecked && !dependsOnSelection()) { setViewData(context.getKey(), isChecked); } else { clearViewData(context.getKey()); } Change-Id: I5094d701be9f2e634eec787f780ad913160dd96e Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7168 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5094d701be9f2e634eec787f780ad913160dd96e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: returning InternalAuthenticateUserCommand as it is use...
by yzaslavs＠redhat.com 15 Aug '12

15 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: returning InternalAuthenticateUserCommand as it is used ...................................................................... core: returning InternalAuthenticateUserCommand as it is used Previous ACK removed this file, which is still in use. Returning it. Change-Id: I1e27744f2e0d2a5c7894b8143b46d89fc26a6af2 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/InternalAuthenticateUserCommand.java 1 file changed, 47 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e27744f2e0d2a5c7894b8143b46d89fc26a6af2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: InternalAuthenticateUserCommand is not used.
by oourfali＠redhat.com 15 Aug '12

15 Aug '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: InternalAuthenticateUserCommand is not used. ...................................................................... core: InternalAuthenticateUserCommand is not used. Removing unused classes. Change-Id: I84a16792c99c5b5454d2ad3e5a75ac843f81faa6 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/InternalAuthenticateUserCommand.java 1 file changed, 0 insertions(+), 47 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84a16792c99c5b5454d2ad3e5a75ac843f81faa6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ldap - no need to set default to AD.
by yzaslavs＠redhat.com 15 Aug '12

15 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: ldap - no need to set default to AD. ...................................................................... core: ldap - no need to set default to AD. LdapProviderType should come from constructor so there is no need to default to AD. Also, made ldapProviderType final. Change-Id: I96778af79f9fd6e7b57e169085393062ea578c48 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96778af79f9fd6e7b57e169085393062ea578c48 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0