Change in ovirt-engine[master]: core: validate storage format by data center version
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: core: validate storage format by data center version
......................................................................
core: validate storage format by data center version
https://bugzilla.redhat.com/843502
https://bugzilla.redhat.com/840558
When creating a new storage domain,
* Storage format version should be validated in
correlation with the data center's compatibility version.
* V2 is applicable only for block storage domain.
SupportedStorageFormats ConfigurationValue,
* V2 is supported in 3.1 (added V2 to the configuration value).
Change-Id: Ia062c1587bc6c35c7ec27270d450d1e312742086
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java
2 files changed, 37 insertions(+), 12 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6990
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia062c1587bc6c35c7ec27270d450d1e312742086
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: Redirect to index when page not found
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Redirect to index when page not found
......................................................................
core: Redirect to index when page not found
This is a fix for commit 2107a03979 (ouput index.html as error page),
which was a fix for commit 66edaab361 (redirect servlet).
Introduce error.html at root, webapp, userportal-gwtp. Use HTTP meta
refresh to redirect to root context.
As a result the index.html hrefs can be relative as they should.
Repeating the note:
HTTP Redirect causing problems with clients (GWT for example)
that follow the redirect and this don't recieve the error code.
Change-Id: I63e7992a748935347eee7b65930bc6d29fdb92db
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
A backend/manager/modules/root/src/main/webapp/404.html
M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
M backend/manager/modules/root/src/main/webapp/index.html
A frontend/webadmin/modules/userportal-gwtp/src/main/webapp/404.html
M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml
A frontend/webadmin/modules/webadmin/src/main/webapp/404.html
M frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml
7 files changed, 84 insertions(+), 6 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7153
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I63e7992a748935347eee7b65930bc6d29fdb92db
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: Improve error message on failed host install.
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Improve error message on failed host install.
......................................................................
core: Improve error message on failed host install.
I ran into this issue earlier this week when adding a host. The install
failed and the "Events" tab showed this message - Host xyz installation failed.
Please refer to log files for further details.
IMHO, This message can be improved. This patch attempts to do that.
Change-Id: Ia136a1d329f1fd82bd4b09339c04bac2aea77700
Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7076
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia136a1d329f1fd82bd4b09339c04bac2aea77700
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: engine: It is not possible to take prestared VM from pool (#...
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: engine: It is not possible to take prestared VM from pool (#844917)
......................................................................
engine: It is not possible to take prestared VM from pool (#844917)
https://bugzilla.redhat.com/844917
The problem was in AttachUserToVmFromPoolAndRunCommand
which set the "returnValue" and "succeeded" only after
the VM has been started - so ignoring the pre-stared VMs.
It is safe to set the succeeded to true in that else block
because if any error occures, the method returns earlier.
Change-Id: I2e4075119516a1447bf3036e6bdddc56abf9ad39
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6868
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e4075119516a1447bf3036e6bdddc56abf9ad39
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Anonymous Coward #1000055
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core+ui: adding isFileDomain and isBlockDomain to StorageTyp...
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core+ui: adding isFileDomain and isBlockDomain to StorageType enum
......................................................................
core+ui: adding isFileDomain and isBlockDomain to StorageType enum
This patch adds the isFileDomain and isBlockDomain methods to the
StorageType enum, and uses them in several locations in the engine core
and the UI.
Change-Id: I45b9bd6d3abf504714e3ddc01fbcf71fdfdff0ad
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageType.java
A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/StorageTypeTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java
6 files changed, 44 insertions(+), 5 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7164
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45b9bd6d3abf504714e3ddc01fbcf71fdfdff0ad
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: engine: Import linux template with legacy usb policy (#83425...
by asaf@redhat.com
Asaf Shakarchi has submitted this change and it was merged.
Change subject: engine: Import linux template with legacy usb policy (#834254)
......................................................................
engine: Import linux template with legacy usb policy (#834254)
https://bugzilla.redhat.com/834254
- Fixed bug where UsbPolicy.forStringValue returns null for old values.
- Import template forces usb policy to be disabled for Linux os.
- Consolidated usb policy update method.
Change-Id: Ib1184493dedb44c5b481a27eceaee69974b73540
Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/UsbPolicy.java
4 files changed, 12 insertions(+), 8 deletions(-)
Approvals:
Asaf Shakarchi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7138
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1184493dedb44c5b481a27eceaee69974b73540
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: packaging: Do not allow whitespaces in passwords (#BZ835363)
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Do not allow whitespaces in passwords (#BZ835363)
......................................................................
packaging: Do not allow whitespaces in passwords (#BZ835363)
https://bugzilla.redhat.com/show_bug.cgi?id=835363
Do not allow whitespaces in passwords in engine-setup.
Change-Id: Ia29fb22c53f45d735f1d722ae9a80e5ccbb2246b
Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com>
---
M backend/manager/conf/ca/encryptpasswd.sh
M packaging/fedora/setup/engine_validators.py
M packaging/fedora/setup/output_messages.py
3 files changed, 12 insertions(+), 7 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7033
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia29fb22c53f45d735f1d722ae9a80e5ccbb2246b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: webadmin: Allow edit of Direct LUN VM disks
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: Allow edit of Direct LUN VM disks
......................................................................
webadmin: Allow edit of Direct LUN VM disks
https://bugzilla.redhat.com/847094
When editing a Direct LUN VM disk, validation fails because no disk is
selected in the UI. There's no need for validation here since the LUN
is already assigned.
Fix was graciously supplied by Daniel Erez <derez(a)redhat.com>.
Change-Id: I32d956bb5cb255cccdb1814e3566505cf01f15a3
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/DiskModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7069
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32d956bb5cb255cccdb1814e3566505cf01f15a3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: packaging: redirect to TLS/SSL using application server
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: redirect to TLS/SSL using application server
......................................................................
packaging: redirect to TLS/SSL using application server
Enforce TLS/SSL on the following applications:
* restapi
* userportal
* webadmin
Remove the guessing and setup of the root welcome message
(/etc/ovirt-engine/web-conf.js), as now each context redirect
upon need.
Change-Id: If0d05ce7224548123c9f5f2a1ce09bf090625085
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M Makefile
M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml
D backend/manager/modules/root/src/main/java/org/ovirt/engine/core/WebConfServlet.java
M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
M backend/manager/modules/root/src/main/webapp/index.html
M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/WEB-INF/web.xml
M frontend/webadmin/modules/webadmin/src/main/webapp/WEB-INF/web.xml
M packaging/fedora/setup/basedefs.py
M packaging/fedora/setup/engine-setup.py
M packaging/fedora/setup/output_messages.py
M packaging/fedora/setup/ovirt_port80.py
D packaging/fedora/setup/resources/jboss/web-conf.js
M packaging/fedora/spec/ovirt-engine.spec.in
13 files changed, 48 insertions(+), 155 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6827
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If0d05ce7224548123c9f5f2a1ce09bf090625085
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: Revert "core: Option with empty name and value ..."
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: Revert "core: Option with empty name and value ..."
......................................................................
Revert "core: Option with empty name and value ..."
This reverts commit fa6988eac4c32f87680a0f6bd6571315f2c4ab95.
Storage domain cannot be activated or attached to data center.
Cannot discover targets.
Change-Id: Ia99b01a8f7e89dde1b74403fb69c72e0898a0b65
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java
1 file changed, 0 insertions(+), 9 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7142
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia99b01a8f7e89dde1b74403fb69c72e0898a0b65
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 4 months