August 2012 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: webadmin: Add Reconnect to VM action group under configure r...

by ecohen＠redhat.com

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: Add Reconnect to VM action group under configure roles dialog ...................................................................... webadmin: Add Reconnect to VM action group under configure roles dialog Added RECONNECT_TO_VM Action Group to the roles configuration dialog Change-Id: I792d889bdd2858dcdfbeb57a01af8761c0a15b81 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 4 files changed, 13 insertions(+), 2 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7125 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I792d889bdd2858dcdfbeb57a01af8761c0a15b81 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: ui: Unable to edit a template from objects tree

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: ui: Unable to edit a template from objects tree ...................................................................... ui: Unable to edit a template from objects tree In UnitVmModel, we do not have a treatment for the case the object is a template. This patch fixes that behavior. Change-Id: I3f88a3c79bf79908a1c711d00102f02e65ec991d Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f88a3c79bf79908a1c711d00102f02e65ec991d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Rephrase edit mgmt network error(#845274)

by gchaplik＠redhat.com

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Rephrase edit mgmt network error(#845274) ...................................................................... webadmin: Rephrase edit mgmt network error(#845274) https://bugzilla.redhat.com/845274 Change to- "Cannot edit Management Network when there are Clusters in the Data Center" Change-Id: I2dd989472f9196c7b32c2c08cbc7f9ba11b249d5 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dd989472f9196c7b32c2c08cbc7f9ba11b249d5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: making Volumes tab visible in system level

by alkaplan＠redhat.com

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: making Volumes tab visible in system level ...................................................................... webadmin: making Volumes tab visible in system level Volumes tab will be visible in system level when the ApplicationMode is ALL. This patch reverts the changes done in http://gerrit.ovirt.org/#/c/6607/ Change-Id: I9dd6e3ca3b190fb3eabe7a44a026012725646c01 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7020 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9dd6e3ca3b190fb3eabe7a44a026012725646c01 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Edit net- error lable is visible even if it should...

by alkaplan＠redhat.com

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Edit net- error lable is visible even if it shouldn't (#845274) ...................................................................... webadmin: Edit net- error lable is visible even if it shouldn't (#845274) https://bugzilla.redhat.com/845274 1. Rephrase to error msg on Edit Mgmt to- "Cannot edit Management Network when there are one or more Clusters in the Data Center" 2. If a network doesn't attached to any cluster. When opening the edit network dialog the error msg appears even it shouldn't. Change-Id: I09051257df435aea9f889eb7f794c109c4c05f27 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java 6 files changed, 26 insertions(+), 18 deletions(-) Approvals: Alona Kaplan: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09051257df435aea9f889eb7f794c109c4c05f27 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core:Use engine_test as a default DB for dao tests.

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core:Use engine_test as a default DB for dao tests. ...................................................................... core:Use engine_test as a default DB for dao tests. Change the configuration pgsql file for dao testing to use engine_test as a default data base for testing instead engine. This should prevent running over existing DB engine, which most of developers use as a development DB which JBOSS count on. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: Ic421ea40e2d54c90a9bea18a85f9ec671aef19a9 --- M backend/manager/modules/dal/src/test/filters/pgsql.properties 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic421ea40e2d54c90a9bea18a85f9ec671aef19a9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: Change template NICs to read/write (#846950)

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: restapi: Change template NICs to read/write (#846950) ...................................................................... restapi: Change template NICs to read/write (#846950) https://bugzilla.redhat.com/846950 The template NICs are not read-only, but in fact can be added, updated and deleted. Therefore, the return type of the getNics method was changed to reflect this behavior. Change-Id: Ia9bacfbb4e2d29827b969363fde55701f503268b Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/TemplateResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9bacfbb4e2d29827b969363fde55701f503268b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core:No need to call super method for job properties(#818295...

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core:No need to call super method for job properties(#818295) ...................................................................... core:No need to call super method for job properties(#818295) https://bugzilla.redhat.com/show_bug.cgi?id=818295 Import vm template already has the appropriate parameters to write a message, so the call for the super method is redundant. Change-Id: Ib92221db99df6d1fc4178cbab8375d6ea4d8a9c2 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib92221db99df6d1fc4178cbab8375d6ea4d8a9c2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Deny removing network which is used by VMs (#824497)

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: core: Deny removing network which is used by VMs (#824497) ...................................................................... core: Deny removing network which is used by VMs (#824497) https://bugzilla.redhat.com/824497 The patch adds a check for detach network from host nic command: It prevents removing the network if the network is being used by running VMs. Change-Id: I781df6469802e079c6346227e68312b9fbffbd27 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkFromVdsInterfaceCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 34 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I781df6469802e079c6346227e68312b9fbffbd27 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Use StringUtils and getDbFacade (#824497)

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: core: Use StringUtils and getDbFacade (#824497) ...................................................................... core: Use StringUtils and getDbFacade (#824497) https://bugzilla.redhat.com/824497 The patch replaces StringHelper with StringUtils and replaces the DbFacade.getInstance() with getDbFacade(). The next patch will use both. Change-Id: I4aa0e7119d29809cb7af094a2ea978200c22613f Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkFromVdsInterfaceCommand.java 1 file changed, 8 insertions(+), 10 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4aa0e7119d29809cb7af094a2ea978200c22613f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

11 years, 10 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits August 2012