Change in ovirt-engine[master]: packaging: Add ovirt-engine-cli to spec file (#BZ845836)
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Add ovirt-engine-cli to spec file (#BZ845836)
......................................................................
packaging: Add ovirt-engine-cli to spec file (#BZ845836)
https://bugzilla.redhat.com/show_bug.cgi?id=845836
This patch adds ovirt-engine-cli to the spec file. Engine package will
requires ovirt-engine-cli on installation.
Change-Id: If86dc7868d4ec8e6f321fd757f731822e0a5d4c4
Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com>
---
M packaging/fedora/spec/ovirt-engine.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7100
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If86dc7868d4ec8e6f321fd757f731822e0a5d4c4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine-cli[master]: cli: support utf-8 encoding
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: support utf-8 encoding
......................................................................
cli: support utf-8 encoding
Change-Id: I0353e14b1f5268bea4077c40da167d5370a02bd6
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/cli/context.py
M src/cli/terminal.py
M src/ovirtcli/format/text.py
3 files changed, 14 insertions(+), 6 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ori Liel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6978
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0353e14b1f5268bea4077c40da167d5370a02bd6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 4 months
Change in ovirt-engine-sdk[master]: codegen: do not require optional params
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: codegen: do not require optional params
......................................................................
codegen: do not require optional params
Change-Id: I83cc339b060fd8e68ac0918b5faa827355f48f76
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/codegen/collection/resource.py
M src/codegen/subcollection/subresource.py
M src/codegen/utils/paramutils.py
M src/ovirtsdk/infrastructure/brokers.py
4 files changed, 24 insertions(+), 8 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ori Liel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7007
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I83cc339b060fd8e68ac0918b5faa827355f48f76
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: fix AddDisk permission check
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: fix AddDisk permission check
......................................................................
core: fix AddDisk permission check
When someone adds a floating from the webadmin UI, the vm id is
EMPTY_GUID. However, in the permissions check, we check for null.
This patch checks for null, and if the vm id isn't null, it checks if it
is an empty guid.
Change-Id: Ibf0220700a9675d17f553df2b96f2e1da3b621b1
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7140
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf0220700a9675d17f553df2b96f2e1da3b621b1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: bootstrap: move node id creation command to configuration
by dfediuck@redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: bootstrap: move node id creation command to configuration
......................................................................
bootstrap: move node id creation command to configuration
This will enable to modify the command on demand.
Change-Id: I3a575e2bf391ca6b1cf7e8baa2d8c5813e10c97f
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstallHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
3 files changed, 18 insertions(+), 6 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7068
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a575e2bf391ca6b1cf7e8baa2d8c5813e10c97f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: utils: ssh public key entry should contain new line
by dfediuck@redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: utils: ssh public key entry should contain new line
......................................................................
utils: ssh public key entry should contain new line
A complete entry is a single line.
Change-Id: Ifd202048b8efb8f081b10651c302b9da0718035c
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/OpenSSHUtils.java
M backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/StoreUtils.java
M backend/manager/modules/engineencryptutils/src/test/java/org/ovirt/engine/core/engineencryptutils/OpenSSHUtilsTest.java
3 files changed, 13 insertions(+), 12 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7027
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd202048b8efb8f081b10651c302b9da0718035c
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: core: fix users quota check
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: fix users quota check
......................................................................
core: fix users quota check
quota check will be invoked in IsUserAutorizedToRunAction
Change-Id: Icc1298cabe3cc5e8895d31f473a76bb9ff7efdef
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 5 insertions(+), 6 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7133
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc1298cabe3cc5e8895d31f473a76bb9ff7efdef
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: userportal: allow to set quota in UP
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: userportal: allow to set quota in UP
......................................................................
userportal: allow to set quota in UP
quota wasn't set in UP for create vm & template,
now when selecting quota in the dialog it will be passed to the
server.
Change-Id: Ia3673adc00f3251a26f27926121935487d3874a5
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
1 file changed, 10 insertions(+), 3 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/7134
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3673adc00f3251a26f27926121935487d3874a5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: webadmin: Fixing vlan capitalization (#821456)
by dfediuck@redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: webadmin: Fixing vlan capitalization (#821456)
......................................................................
webadmin: Fixing vlan capitalization (#821456)
https://bugzilla.redhat.com/821456
- The Word VLAN was used in diffrent capitalization across the ui
- changed the capitalisation to be consistent
Change-Id: I67f6d44dc3ed8e5b8a165c9ab3db1d0fec99a1cd
Signed-off-by: Noam Slomianko <nslomian(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6975
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67f6d44dc3ed8e5b8a165c9ab3db1d0fec99a1cd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: UI: set focus in username field at user-portal (#847064)
by shavivi@redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: UI: set focus in username field at user-portal (#847064)
......................................................................
UI: set focus in username field at user-portal (#847064)
https://bugzilla.redhat.com/show_bug.cgi?id=847064
Change-Id: I40121d4e8cf3d4debf3336445925a0792ac4757e
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.java
1 file changed, 13 insertions(+), 1 deletion(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7131
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I40121d4e8cf3d4debf3336445925a0792ac4757e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
12 years, 4 months