September 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: adding values to engine-config(#848862)
by emesika＠redhat.com 19 Sep '12

19 Sep '12

Eli Mesika has submitted this change and it was merged. Change subject: core: adding values to engine-config(#848862) ...................................................................... core: adding values to engine-config(#848862) Adding new configuration values to engine-config Change-Id: I6e73ba5817e164ef06dd554d7eaa3589d0da3f99 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/tools/engine-config/src/main/resources/engine-config.properties 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e73ba5817e164ef06dd554d7eaa3589d0da3f99 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: adding host time-drift notification(#848862)
by emesika＠redhat.com 19 Sep '12

19 Sep '12

Eli Mesika has submitted this change and it was merged. Change subject: core: adding host time-drift notification(#848862) ...................................................................... core: adding host time-drift notification(#848862) Adding support for event notification Change-Id: I5b841724fbfe2a0bbfba7e9b4434be6d0949b782 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_01_1400_add_host_time_drift_event.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 4 files changed, 6 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7828 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b841724fbfe2a0bbfba7e9b4434be6d0949b782 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: adding host time-drift alert(#848862)
by emesika＠redhat.com 19 Sep '12

19 Sep '12

Eli Mesika has submitted this change and it was merged. Change subject: core: adding host time-drift alert(#848862) ...................................................................... core: adding host time-drift alert(#848862) Adding the new VDS_TIME_DRIFT_ALERT event Change-Id: I3d2f23a7e9312512ec4ba6c3e946d143de6bf9ae Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 5 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7827 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d2f23a7e9312512ec4ba6c3e946d143de6bf9ae Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Report event on time drift ...(#848862)
by emesika＠redhat.com 19 Sep '12

19 Sep '12

Eli Mesika has submitted this change and it was merged. Change subject: core: Report event on time drift ...(#848862) ...................................................................... core: Report event on time drift ...(#848862) Report event on time drift between engine and vdsm(#848862) This patch series adds time drift check per host. New configuration values were added EnableHostTimeDrift - indicates if time-drift check is ON (default false) HostTimeDriftInSec - Max allowed time drift in seconds (default 300) Each time that getVdsStsats is executed by the engine, it gets the host date in GMT and compare it with local engine date, if the difference in seconds exceeded HostTimeDriftInSec and EnableHostTimeDrift is ON, an ALERT is written to the log. The new configuration values are available for editing in engine-config and the new event named VDS_TIME_DRIFT_ALERT can be managed to get notifications on that event. To prevent event-flood, this event is issued once an hour per Host. Change-Id: I9544418dc49f8e9e75f6c8c7f091c96726b1f30d Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 2 files changed, 14 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7826 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9544418dc49f8e9e75f6c8c7f091c96726b1f30d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: audig_log table is not cleaned ...(#856009)
by emesika＠redhat.com 19 Sep '12

19 Sep '12

Eli Mesika has submitted this change and it was merged. Change subject: core: audig_log table is not cleaned ...(#856009) ...................................................................... core: audig_log table is not cleaned ...(#856009) core audig_log table is not cleaned properly, causing rhevm database to grow excessively(#856009) https://bugzilla.redhat.com/856009 Problem was that the DeleteAuditLogOlderThenDate removed only records with processed=true. this flag is used by rhev-notification tool to mark which events were handled (by sending events to subscribers) , so , the default of this flag is false and after rhev-notification tool handles it , it is set to true Sine the DeleteAuditLogOlderThenDate removes old data (more than 30 days by default) there is no need to relate to this flag and it should be removed from the SP condition. Change-Id: Id1e5d06751d672aa1f40f5a395234f71597289f4 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/audit_log_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1e5d06751d672aa1f40f5a395234f71597289f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Refactored EndWithFailure()
by lhornyak＠redhat.com 19 Sep '12

19 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: Refactored EndWithFailure() ...................................................................... engine: Refactored EndWithFailure() Conforms to java's standard way of naming a method starting with lower case. Change-Id: Ia5bf1d393556bfbe975930c7c81b5ade5c57f6d8 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmToPoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 29 files changed, 41 insertions(+), 41 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7938 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5bf1d393556bfbe975930c7c81b5ade5c57f6d8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix power user roles and GetAllVmPoolsAttachedToUser q...
by oourfali＠redhat.com 19 Sep '12

19 Sep '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix power user roles and GetAllVmPoolsAttachedToUser query ...................................................................... core: fix power user roles and GetAllVmPoolsAttachedToUser query Assigning user roles to System/DC/Cluster can cause weird behavior, as user will be able to see all VMs under these objects, but when looking at VM pools he won't be able to operate them. In this patch we do the following: 1. Make PowerUser role contain the following action groups (and changes the description accordingly): * login * create disk * create VM * create template 2. Mark it as "allow_viewing_children = false". 3. Fix the get pools query, to get the filtered pools from the correct view. Change-Id: I9acba40db76fbd5e8ffbeb1d615d4675b6903ccb Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/dbscripts/bookmarks_sp.sql A backend/manager/dbscripts/upgrade/03_01_1390_update_power_user_role.sql 2 files changed, 14 insertions(+), 9 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7985 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9acba40db76fbd5e8ffbeb1d615d4675b6903ccb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Incorrect syntax for String.format
by yzaslavs＠redhat.com 19 Sep '12

19 Sep '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Incorrect syntax for String.format ...................................................................... core: Incorrect syntax for String.format Changed from '%s%s' to '%2$s' Change-Id: I18a62074802f87957e57bbc2307f8d801b3536aa Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSH.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18a62074802f87957e57bbc2307f8d801b3536aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix RemoveVmTemplate regression
by derez＠redhat.com 19 Sep '12

19 Sep '12

Daniel Erez has submitted this change and it was merged. Change subject: core: Fix RemoveVmTemplate regression ...................................................................... core: Fix RemoveVmTemplate regression Refactoring task creation broke removing a VM template, since the RemoveVmTemplateCommand does not propagate it's parameters to the child commands, which causes an NPE when trying to access them. This patch fixes this flow. Change-Id: I27ebeee388b2975cd9a34250758a4bb954f5bd57 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/8049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27ebeee388b2975cd9a34250758a4bb954f5bd57 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Replaced getDiskImageDAO with getDiskImageDao
by lhornyak＠redhat.com 19 Sep '12

19 Sep '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Replaced getDiskImageDAO with getDiskImageDao ...................................................................... core: Replaced getDiskImageDAO with getDiskImageDao This should help fix Jenkins warning - "VERY confusing to have methods org.ovirt.engine.core.bll.AbstractDiskVmCommand.getDiskDao() and org.ovirt.engine.core.bll.VmCommand.getDiskDAO()" http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2475/findbugsResult/sou… http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2475/findbugsResult/sou… http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2475/findbugsResult/sou… http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2475/findbugsResult/sou… http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/2475/findbugsResult/sou… Change-Id: Ib82d0c80652c8c4a10019ce515051eb1e60dfa92 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDisksForQuotaIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImageByImageIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetImagesByStorageDomainAndTemplateQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmConfigurationBySnapshotQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreStatelessVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmConfigurationBySnapshotQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/BasicTestSetup.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainStaticDAOTest.java 29 files changed, 40 insertions(+), 62 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7846 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib82d0c80652c8c4a10019ce515051eb1e60dfa92 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0