September 2012 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: RemoveSnapshotSingleDisk ConcreteCreateTask

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: RemoveSnapshotSingleDisk ConcreteCreateTask ...................................................................... core: RemoveSnapshotSingleDisk ConcreteCreateTask Removed ConcreteCreateTask from RemoveSnapshotSingleDiskCommand, and used the new getTaskType() mechanism introduced to CommandBase. Change-Id: Ic9eb4f2b87832de1418297a543ee33570d044c93 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java 2 files changed, 8 insertions(+), 11 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9eb4f2b87832de1418297a543ee33570d044c93 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: core: RemoveImage's ConcreteCreateTask

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: RemoveImage's ConcreteCreateTask ...................................................................... core: RemoveImage's ConcreteCreateTask Removed ConcreteCreateTask from RemoveImageCommand, and used the new getTaskType() mechanism introduced to CommandBase. Change-Id: I64a8bb2c121967216719e54117b073bffbcaafbf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java 2 files changed, 25 insertions(+), 12 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64a8bb2c121967216719e54117b073bffbcaafbf Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: core: MoveOrCopyImageGroup's ConcreteCreateTask

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: MoveOrCopyImageGroup's ConcreteCreateTask ...................................................................... core: MoveOrCopyImageGroup's ConcreteCreateTask Removed ConcreteCreateTask from MoveOrCopyImageGroupCommand, and used the new getTaskType() mechanism introduced to CommandBase. Change-Id: I2a281b117b4445ac84831f4dc0db87a217a0ab9d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java 2 files changed, 12 insertions(+), 13 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7796 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a281b117b4445ac84831f4dc0db87a217a0ab9d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: core: CreateCloneOfTemplate's ConcreteCreateTask

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: CreateCloneOfTemplate's ConcreteCreateTask ...................................................................... core: CreateCloneOfTemplate's ConcreteCreateTask Removed ConcreteCreateTask from CreateCloneOfTemplateCommand, and used the new getTaskType() mechanism introduced to CommandBase. Change-Id: I0bf7de9868576d35138cff645e8bea7885085255 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java 2 files changed, 5 insertions(+), 12 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0bf7de9868576d35138cff645e8bea7885085255 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: core: CreateImageTemplate's ConcreteCreateTask

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: CreateImageTemplate's ConcreteCreateTask ...................................................................... core: CreateImageTemplate's ConcreteCreateTask Removed ConcreteCreateTask from CreateImageTemplateCommand, and used the new getTaskType() mechanism introduced to CommandBase. Change-Id: Idb72028d4f4eea8e625b7bdac0a38c52a62da7e3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java 2 files changed, 5 insertions(+), 14 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7794 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb72028d4f4eea8e625b7bdac0a38c52a62da7e3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: core: AddImageFromScratch's ConcreteCreateTask

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: AddImageFromScratch's ConcreteCreateTask ...................................................................... core: AddImageFromScratch's ConcreteCreateTask Removed the ConcreteCreateTask from the AddImageFromScratchCommand. The code is a duplication of the same method introduced to CommandBase, and the task type is createVolume, the same as in CreateImageCommand, which it extends. Change-Id: Iec993e6a365eca913e5739a4cc3165854803c5e7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java 2 files changed, 3 insertions(+), 19 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec993e6a365eca913e5739a4cc3165854803c5e7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: core: CommandsBase: refactor task creation

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: CommandsBase: refactor task creation ...................................................................... core: CommandsBase: refactor task creation In order to create async tasks, CommandBase expects inheriting classes to override the ConcreteCreateTask method. For classes that do not overwrite it, an UnsupportedOperationException is thrown. However, most places that override this method contain the exact same code, where the only difference is the type of the task created. This patch suggests a new mechanism so that each inheriting class will just need to specify what type of task it requires. For commands that do not specify the type, an UnsupportedOperationException will still be thrown. This patch contains the refactoring in CommandBase, the first usecase for this mechanism as an example (using CreateSnapshotCommand) and a test case that proves that the behavior has not changed. If this patch is approved, subsequent patches will apply the new mechanism to further commands. Change-Id: I5a4c77067d43ba5c2dbaf46ff855ac14d29de2ff Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java 3 files changed, 142 insertions(+), 20 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a4c77067d43ba5c2dbaf46ff855ac14d29de2ff Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: core: fix the fn_db_split_config_value db function and uses

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: core: fix the fn_db_split_config_value db function and uses ...................................................................... core: fix the fn_db_split_config_value db function and uses Previous patch added the fn_db_split_config_value, to take general value, and update it with a newer one, splitting to versions. The previous implementation of the function updated the newest version to the input value, which will work well on upgrade, but not for new installations. New implementation of this function takes the version from which we need to split, and updates all the versions from it and byeond. Will work well for new installation (split general to the different versions), and for upgrades (new version, if there is one, will get the input value). Also, adding new supported secured spice channels (smartcard and usbredir), both to the config and to the config tool. Change-Id: I6964750ed0f57155e7c64a2a29ee0c21e2043410 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/dbscripts/common_sp.sql M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/tools/engine-config/src/main/resources/engine-config.properties 4 files changed, 17 insertions(+), 11 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7973 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6964750ed0f57155e7c64a2a29ee0c21e2043410 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: utils: cleanup: SSHClient: add properties get methods

by yzaslavs＠redhat.com

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: cleanup: SSHClient: add properties get methods ...................................................................... utils: cleanup: SSHClient: add properties get methods This is required to allow proper messaging and probably other uses. Came up again at discussion[1]. Does not effect stability, no reason not to provide. [1] http://gerrit.ovirt.org/#/c/7584/ Change-Id: I236d6b71402b840b9c338c255b16e298cd0716fa Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSH.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/PropertiesTest.java 3 files changed, 149 insertions(+), 53 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I236d6b71402b840b9c338c255b16e298cd0716fa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: core: look for changes in view and sp files during upgrade (...

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core: look for changes in view and sp files during upgrade (#857029) ...................................................................... core: look for changes in view and sp files during upgrade (#857029) https://bugzilla.redhat.com/857029 This fixes upgrade.sh to check for changes in backend/manager/dbscripts/{create_*views.sql,*_sp.sql} like it previously did. Change-Id: I80f3842a5f368868916d9e8251f0bf66674da9bf Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/dbscripts/dbfunctions.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7983 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80f3842a5f368868916d9e8251f0bf66674da9bf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>

12 years, 4 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits September 2012