Change in ovirt-engine[master]: gluster: Wrapper method for updating volume status
by sanjal＠redhat.com
Shireesh Anjal has submitted this change and it was merged.
Change subject: gluster: Wrapper method for updating volume status
......................................................................
gluster: Wrapper method for updating volume status
Introduced a new wrapper method GlusterUtils#updateVolumeStatus() for
updating status of a volume. This internally updates status of all the
bricks of that volume as well.
Modified the start/stop gluster volume commands to make use of this new
method. Removed the method GlusterVolumeCommandBase#updateBrickStatus()
as it is not required any more.
Change-Id: Ia5ae4f24e8c70781d7f93f19c935e136ba8b702b
Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtils.java
4 files changed, 37 insertions(+), 27 deletions(-)
Approvals:
Shireesh Anjal: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11167
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5ae4f24e8c70781d7f93f19c935e136ba8b702b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: gluster: Modify calls to fnSplitterUuid
by sanjal＠redhat.com
Shireesh Anjal has submitted this change and it was merged.
Change subject: gluster: Modify calls to fnSplitterUuid
......................................................................
gluster: Modify calls to fnSplitterUuid
Patch http://gerrit.ovirt.org/9825 changed the definition of the SP
fnSplitterUuid in such a way that the older calls to this SP, that
looked like:
select ID from fnSplitterUuid(v_ids)
no longer work, and now need to be changed to something like:
select * from fnSplitterUuid(v_ids)
While this change was done in most of the *_sp.sql scripts, it was
missed out in gluster_volumes_sp.sql
Changing it now in gluster_volumes_sp.sql
Change-Id: I64e0ea2dd7bfb03494aa0346d2aa24b226a99452
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=901531
Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com>
---
M backend/manager/dbscripts/gluster_volumes_sp.sql
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Shireesh Anjal: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11169
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64e0ea2dd7bfb03494aa0346d2aa24b226a99452
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 3 months
Change in ovirt-reports[master]: reports: fixed br18a title in asian locales (#901418)
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: reports: fixed br18a title in asian locales (#901418)
......................................................................
reports: fixed br18a title in asian locales (#901418)
Bug-Url: https://bugzilla.redhat.com/901418
Change-Id: I62ae7035b424df7c4d4a06d95ce8a23101eece25
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M reports/repository_files/resources/reports_resources/embedded_reports/Inventory_Dashboard/active_entities_by_os_BR18A_files/active_entities_by_os_BR18A_jrxml.data
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11242
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I62ae7035b424df7c4d4a06d95ce8a23101eece25
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[engine_3.2]: webadmin: tiny fix for make template dialog's focus traversa...
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: tiny fix for make template dialog's focus traversal
......................................................................
webadmin: tiny fix for make template dialog's focus traversal
The tab index of 'Quota' combobox is wrong, resulting in wrong focus
traversal order.
This patch fix it by giving the 'Quota' combobox the right tab index so
that it will be focused right after 'Host Cluster' combobox.
Change-Id: If568deb65aaa03a1a422bd6cf7d41dface29ba5e
Bug-Url: https://bugzilla.redhat.com/873133
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmMakeTemplatePopupWidget.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/11209
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If568deb65aaa03a1a422bd6cf7d41dface29ba5e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: engine: Removal of a deprecated Public API moudle.
by asaf＠redhat.com
Asaf Shakarchi has submitted this change and it was merged.
Change subject: engine: Removal of a deprecated Public API moudle.
......................................................................
engine: Removal of a deprecated Public API moudle.
This patch removes a deprecated Public API module,
It also removes the module from its parent pom.
Change-Id: Ie64282709aad5854586e8dfb928076cb584f6711
Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com>
---
D frontend/api/genericapi/pom.xml
D frontend/api/genericapi/src/main/java/org/ovirt/engine/ui/GenericApi.gwt.xml
D frontend/api/genericapi/src/main/java/org/ovirt/engine/ui/genericapi/GenericApiService.java
D frontend/api/genericapi/src/main/java/org/ovirt/engine/ui/genericapi/UICommandsFactory.java
D frontend/api/genericapi/src/main/java/org/ovirt/engine/ui/genericapi/parameters/UIQueryParametersBase.java
D frontend/api/genericapi/src/main/java/org/ovirt/engine/ui/genericapi/returnvalues/UIQueryReturnValue.java
D frontend/api/genericapi/src/main/java/org/ovirt/engine/ui/genericapi/uiqueries/Get64bitOsTypesUIQuery.java
D frontend/api/genericapi/src/main/java/org/ovirt/engine/ui/genericapi/uiqueries/GetLinuxOsTypesUIQuery.java
D frontend/api/genericapi/src/main/java/org/ovirt/engine/ui/genericapi/uiqueries/GetUserActionGroupsUIQuery.java
D frontend/api/genericapi/src/main/java/org/ovirt/engine/ui/genericapi/uiqueries/GetWindowsOsTypesUIQuery.java
D frontend/api/genericapi/src/main/java/org/ovirt/engine/ui/genericapi/uiqueries/UIQueryBase.java
D frontend/api/genericapi/src/main/java/org/ovirt/engine/ui/genericapi/uiqueries/UIQueryType.java
M frontend/pom.xml
13 files changed, 0 insertions(+), 477 deletions(-)
Approvals:
Asaf Shakarchi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10244
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie64282709aad5854586e8dfb928076cb584f6711
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: engine: Improving export of xmls
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Improving export of xmls
......................................................................
engine: Improving export of xmls
The following patch is one of the first step which is done in order to improve our
xml read/write infrastructure.
The change contains:
1. During export of xml no need to create a temp file and after that load it, the following code was removed.
2. Clean up of appropriate files
3. removing un needed classes
Main benefits, perfromance should be improved on every export xml operation (removed i/o), code should become
more clean
Change-Id: If8206580740be92cac7ffdbdc1c2f53ac0021d2e
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Formatting.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlDocument.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlTextWriter.java
D backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/backendcompat/XmlDocumentTest.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/IOvfBuilder.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
10 files changed, 54 insertions(+), 159 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11221
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If8206580740be92cac7ffdbdc1c2f53ac0021d2e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: packaging: Creating ui plugins directory during installation
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Creating ui plugins directory during installation
......................................................................
packaging: Creating ui plugins directory during installation
Bug-Url: https://bugzilla.redhat.com/895933
Change-Id: I4954249bab1651cedf81d91263eaa4079e3fc8f6
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M Makefile
M packaging/fedora/spec/ovirt-engine.spec.in
2 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11200
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4954249bab1651cedf81d91263eaa4079e3fc8f6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: core: cluster dao test
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: cluster dao test
......................................................................
core: cluster dao test
Fix regression in cluster dao test from
I5847d234e396fe8a83017fb25a5139f552e7c61b
Change-Id: I4fbe12608ddf6e305d05cb869890e9e2ba018e24
Bug-Url: https://bugzilla.redhat.com/784521
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Moti Asayag: Looks good to me, approved
Yair Zaslavsky: Verified
--
To view, visit http://gerrit.ovirt.org/11236
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4fbe12608ddf6e305d05cb869890e9e2ba018e24
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: core: Remove FLOATING_DISK_NOT_SUPPORTED
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove FLOATING_DISK_NOT_SUPPORTED
......................................................................
core: Remove FLOATING_DISK_NOT_SUPPORTED
Removed all entries for the key
ACTION_TYPE_FAILED_FLOATING_DISK_NOT_SUPPORTED from the various
AppErrors*.properties, AppErrors.java and VdcBllMessages.java files, as
it is no longer used and has no references in the code.
Change-Id: Id32ee34c4e88b9443218c772d17a2d2ab1e77add
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
5 files changed, 0 insertions(+), 9 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/11233
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id32ee34c4e88b9443218c772d17a2d2ab1e77add
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 3 months
Change in ovirt-engine[master]: engine: VmDeviceUtils cleanup 2
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: engine: VmDeviceUtils cleanup 2
......................................................................
engine: VmDeviceUtils cleanup 2
removed vmdao.get call, since the result was not used at all.
Change-Id: I3a3a82cf160d58b03e3e200dc5fcc8b3e5f0ff48
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11158
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a3a82cf160d58b03e3e200dc5fcc8b3e5f0ff48
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
11 years, 3 months